Bug#736803: dh_dkms could automatically replace #MODULE_VERSION#
Package: dkms Version: 2.6.1-4 Followup-For: Bug #736803 I just ran into that as well because the manpage is ambiguously worded in a way one could think that that’s already done. Also, having an option that optionally takes an argument is likely going to fail. @Andreas: packages with a literal #MODULE_VERSION# are indeed already broken: first because of the directory structure… […] drwxr-xr-x root/root 0 2021-06-07 18:52 ./usr/src/sch-jens-#MODULE_VERSION#/ -rw-r--r-- root/root 344 2021-06-07 18:44 ./usr/src/sch-jens-#MODULE_VERSION#/dkms.conf drwxr-xr-x root/root 0 2021-06-07 18:52 ./usr/src/sch-jens-0~20210607.0/ -rw-r--r-- root/root20 2021-06-07 15:59 ./usr/src/sch-jens-0~20210607.0/Kbuild […] … and second because they won’t uninstall: the prerm has… # Automatically added by dh_dkms/UNDECLARED DKMS_NAME=sch-jens DKMS_VERSION=#MODULE_VERSION# case "$1" in remove|upgrade|deconfigure) if [ "$(dkms status -m $DKMS_NAME -v $DKMS_VERSION)" ]; then dkms remove -m $DKMS_NAME -v $DKMS_VERSION --all fi … which will end up calling 'dkms status -m name -v', which works, and 'dkms remove -m name -v --all', which will fail badly. -- System Information: Debian Release: 10.9 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-16-amd64 (SMP w/1 CPU core) Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/lksh Init: sysvinit (via /sbin/init) Versions of packages dkms depends on: ii build-essential 12.6 ii coreutils8.30-3 ii dpkg-dev 1.19.7 ii gcc 4:8.3.0-1 ii kmod 26-1 ii make 4.2.1-1.2 ii patch2.7.6-3+deb10u1 Versions of packages dkms recommends: ii fakeroot 1.23-1 ii linux-headers-amd64 4.19+105+deb10u11 ii lsb-release 10.2019051400 ii sudo 1.8.27-1+deb10u3 Versions of packages dkms suggests: ii menu2.1.47+b1 pn python3-apport -- no debconf information
Bug#736803: dh_dkms could automatically replace #MODULE_VERSION#
On Sun, 26 Jan 2014 22:19:34 +0100 Julian Andres Klode wrote: > I think it would make sense if dh_dkms automatically behaves > as if -V is present if #MODULE_VERSION# is set in the dkms > file. This would reduce the need for an override. Seconded. Does using -V on a .dkms file without #MODULE_VERSION# have any effect currently? If not, turning on -V by default (even without the option to turn it off again) should be transparent to all packages. Well, it will break packages that want a literal #MODULE_VERSION# in their installed .dkms file. But I'd consider these already broken ;-) Andreas
Bug#736803: dh_dkms could automatically replace #MODULE_VERSION#
Package: dkms Version: 2.2.0.3-1.2 Severity: wishlist I think it would make sense if dh_dkms automatically behaves as if -V is present if #MODULE_VERSION# is set in the dkms file. This would reduce the need for an override. -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (980, 'unstable'), (500, 'unstable'), (100, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.13-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages dkms depends on: ii build-essential11.6 ii coreutils 8.21-1 ii dpkg-dev 1.17.6 ii gcc4:4.8.2-2 ii make 3.81-8.3 ii module-init-tools 16-2 ii patch 2.7.1-4 Versions of packages dkms recommends: ii fakeroot1.20-3 ii linux-headers-3.10-3-amd64 [linux-headers] 3.10.11-1 ii linux-headers-amd64 3.12+55 ii linux-image-3.10-2-amd64 [linux-image] 3.10.7-1 ii linux-image-3.10-3-amd64 [linux-image] 3.10.11-1 ii sudo1.8.9p4-1 dkms suggests no packages. -- no debconf information -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. Please do not top-post if possible. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
