Bug#740543: RFS: eggdrop/1.6.21-1 [ITA #698272]
Hi Vincent, Thanks for your comments again. On Sun, 20 Apr 2014 01:33:17 -0700 Vincent Cheng vch...@debian.org wrote: - Your package FTBFS with pbuilder (full build log attached): checking for Tcl library... not found Fixed. According to http://eggwiki.org/Bugs/Tcl8.6 , eggdrop versions =1.6.20 have no particular bugs with tcl8.6, so I use it instead of 8.5. - According to debian/changelog, eggdrop was split into two separate binary packages (an additional -data package) as of 1.6.16-3, so as per Policy 7.6.1 [1], consider adding Breaks: eggdrop ( 1.6.16-3) and Replaces: eggdrop ( 1.6.16-3) relationships to your eggdrop-data binary package, otherwise dpkg will error out on updates from eggdrop 1.6.16-3 to the current eggdrop package. This would usually qualify as a RC bug, but since 1.6.16-3 was released about 10 years ago, you could possibly get away with not doing this (I don't think piuparts.debian.org tests package upgrades from 10 years back...) True, same comment and drop solution was suggested here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698599#12 So to avoid any further confusion I add the Breaks+Replaces 1.6.16-3. - debian/copyright: please give src/rfc1459.c some kind of license name on line 40. Also, the current header in that file isn't really a license...if at all possible, I'd suggest adding the license of the corresponding source file from ircd-hybrid into debian/copyright. I listed rfc1459.c as the original ircd-hybrid 5.3 match.c license (GPL-1+) with the current rfc1459.c header as a comment. I believe (and hope) that the package is now correct and incremented the version to 1.6.21-2 so that there is no confusion with the different -1 attempts. You can find it here : http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc PS: Lintian reports error debian-watch-file-pubkey-file-is-missing but it's a lintian bug now fixed (#736711) Regards, -- Cédric -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#740543: RFS: eggdrop/1.6.21-1 [ITA #698272]
Hi Vincent and Markus, Thanks for your comments on the package. I've updated the package with copyright information for - src/compat/gnu_strftime.c (LGPL-2+) - src/compat/inet_aton.c (GPL-2+ and BSD-4-clause and BSD-3-clause, with comment for the University of California BSD-4-clause portion) As well as the following files (different authors): - src/match.c (public domain) - src/compat/snprintf.c (GPL-2+) - src/md5/md5c.c (public domain) - scripts/dccwhois.tcl (GPL-2+) Finally, I've excluded the only two files with no license information from the package : scripts/autobotchk and scripts/sentinel.tcl You can find the updated package at the same place http://mentors.debian.net/package/eggdrop http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-1.dsc A quick note on the remaining open bugs: - #282437 wasn't able to reproduce (but since it is almost 10 years old...) - #596641 the UTF-8 patch indeed is simple, but it is labeled as I want Eggdrop to speak and understand UTF-8. I want it so badly that I'm willing to take the ugliest hack available! on http://eggwiki.org/Main_Page . It comes from http://forum.egghelp.org/viewtopic.php?p=82111#82111 , with the following comment : BE AWARE: This patch FORCES UTF-8 support, so only apply it if your system supports it :) [This patch overrides eggdrops own mechanism to detect the encoding system it should use based on variables (LC_ALL,...). So this is totally a HACK and nothing to put into production code for compatibility reasons] - #374568 for the same reasons as https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=374568#17 Regards, -- Cédric -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#740543: RFS: eggdrop/1.6.21-1 [ITA #698272]
Control: tag -1 + moreinfo Hi Cédric, On Sun, Mar 2, 2014 at 9:04 AM, Cédric Barboiron c...@winkie.fr wrote: Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package eggdrop * Package name: eggdrop Version : 1.6.21-1 Upstream Author : EggHeads Development Team egghe...@eggheads.org * URL : http://www.eggheads.org/ * License : GPL-2+ Section : net It builds those binary packages: eggdrop- Advanced IRC Robot eggdrop-data - Architecture independent files for eggdrop To access further information about this package, please visit the following URL: http://mentors.debian.net/package/eggdrop Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-1.dsc Changes since the last upload: * New upstream release: - debian/patches/00conf_paths.patch: updated - debian/patches/gcc-format-string-warnings: updated - debian/patches/01tcl8.5.10.patch: fixed upstream - debian/eggdrop.install: don't use hardcoded version anymore - Closes: #650718 * debian/compat: update to level 9 * debian/control: - set maintainer to Cédric Barboiron - use latest Standards-Version - add debhelper9 and autotools-dev dependencies - remove cdbs dependency * debian/rules: - switch to debhelper 9 format - Closes: #724986 as a side effect * debian/copyright: use copyright-format 1.0 * debian/watch: version 3, plus check pgp signature * debian/patches/01use_ldflags.patch: propagate LDFLAGS for eggdrop and modules (Closes: #668091) * debian/patches/02language_dir.patch: set default language directory (Closes: #661572) debian/copyright is missing a few copyright holders + license statements, e.g. LGPL-2+ for src/compat/gnu_strftime.c and (partially) 4-clause BSD for src/compat/inet_aton.c (actually, the latter is problematic because most of the upstream source is GPL-2+ licensed, which is incompatible with 4-clause BSD [1]). That's actually another RC bug right there... Regards, Vincent [1] http://www.gnu.org/licenses/license-list.html#OriginalBSD -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#740543: RFS: eggdrop/1.6.21-1 [ITA #698272]
Hi Vincent, On 12.04.2014 11:10, Vincent Cheng wrote: [...] debian/copyright is missing a few copyright holders + license statements, e.g. LGPL-2+ for src/compat/gnu_strftime.c and (partially) 4-clause BSD for src/compat/inet_aton.c (actually, the latter is problematic because most of the upstream source is GPL-2+ licensed, which is incompatible with 4-clause BSD [1]). That's actually another RC bug right there... the 4-clause BSD license should not be problematic in this case since the copyright holder is the University of California. They granted all licensees the right to delete the paragraph about advertising materials thus making the license compatible with the GPL. ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change I think it is sufficient to document this fact with a comment in debian/copyright and to ask upstream to remove the offending paragraph. Regards, Markus signature.asc Description: OpenPGP digital signature
Bug#740543: RFS: eggdrop/1.6.21-1 [ITA #698272]
On Sat, Apr 12, 2014 at 2:33 AM, Markus Koschany a...@gambaru.de wrote: Hi Vincent, On 12.04.2014 11:10, Vincent Cheng wrote: [...] debian/copyright is missing a few copyright holders + license statements, e.g. LGPL-2+ for src/compat/gnu_strftime.c and (partially) 4-clause BSD for src/compat/inet_aton.c (actually, the latter is problematic because most of the upstream source is GPL-2+ licensed, which is incompatible with 4-clause BSD [1]). That's actually another RC bug right there... the 4-clause BSD license should not be problematic in this case since the copyright holder is the University of California. They granted all licensees the right to delete the paragraph about advertising materials thus making the license compatible with the GPL. ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change I think it is sufficient to document this fact with a comment in debian/copyright and to ask upstream to remove the offending paragraph. Ah, in that case, never mind. Thanks! Not documenting this in d/copyright is still a blocker for this package to be uploaded, of course. Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#740543: RFS: eggdrop/1.6.21-1 [ITA #698272]
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package eggdrop * Package name: eggdrop Version : 1.6.21-1 Upstream Author : EggHeads Development Team egghe...@eggheads.org * URL : http://www.eggheads.org/ * License : GPL-2+ Section : net It builds those binary packages: eggdrop- Advanced IRC Robot eggdrop-data - Architecture independent files for eggdrop To access further information about this package, please visit the following URL: http://mentors.debian.net/package/eggdrop Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-1.dsc Changes since the last upload: * New upstream release: - debian/patches/00conf_paths.patch: updated - debian/patches/gcc-format-string-warnings: updated - debian/patches/01tcl8.5.10.patch: fixed upstream - debian/eggdrop.install: don't use hardcoded version anymore - Closes: #650718 * debian/compat: update to level 9 * debian/control: - set maintainer to Cédric Barboiron - use latest Standards-Version - add debhelper9 and autotools-dev dependencies - remove cdbs dependency * debian/rules: - switch to debhelper 9 format - Closes: #724986 as a side effect * debian/copyright: use copyright-format 1.0 * debian/watch: version 3, plus check pgp signature * debian/patches/01use_ldflags.patch: propagate LDFLAGS for eggdrop and modules (Closes: #668091) * debian/patches/02language_dir.patch: set default language directory (Closes: #661572) Regards, -- Cédric Barboiron -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
