Bug#741648: RFS: cbootimage/1.2-2
2014-09-04 18:15 GMT-03:00 Marc Dietrich marvi...@gmx.de: Hi Eriberto, Hi Marc, 3. d/control: you need a VCS to control your packaging. I think that already told you about it. Ask me if you have doubt. Yes, I original got it wrong thinking it must be the upstream repo. Since I have no repo for the debian stuff (and I really don't like to create one) I just dropped it because it is neither mandatory nor recommended. Not mandatory or recommended by policy. However, a good practice commonly requested by all sponsors to allow the control of the code by you or any external people. You must implement it. 4. d/copyright: you need remake this file. A short example is that you didn't told about build/* directory. Please, read (really) about 'copyright' here[1]. As a tip, if your main upstream is Nvidia, you can use a general reference to it. An example (not real for years range): Ah, I forgot to update it to the new paths. In fact, the files are copyrighted by different people from different companies, so I like to keep the current style of one copyright line per company. The NVIDIA copyright mostly comes from the buildsystem and their own boards. You must review each file. Use 'grep -sriA25 copyright *' to help you. I checked each file and FTP Master will do it too. I found several issues. Some examples: - There are several files copyrighted as 2012-2013, or 2012, or 2013 for CompuLab Ltd. You wrote 2012 only. - I didn't saw copyrights for Toradex in your file. - 2011-2013 for Avionic Design GmbH. You wrote 2013 only. - Other issues. Please, change tegra*/compulab/* for two blocks: tegra20/compulab/* and tegra30/compulab/*: Files: tegra20/compulab/* Copyright: xyz License: abc Files: tegra30/compulab/* Copyright: xyz License: abc Do the same to tegra*/toradex/* and tegra*/avionic-design/*. It will avoid confusion and make easier a future upgrade. The 'Files: tegra*/nvidia/* build/*' must be 'Files: *'. Finally, please, INSPECT all files. It will make my work easier. 5. d/docs: you is installing ALL files as documents. No! There is one document only: README.txt. The other files are your program. These files are not really required for cbootimage to run. They are more like examples on how to write a configuration. They even have their own buildsystem so the user needs to copy them to his own directory to actually use them. As the whole package only contains examples, they can go directly into docs (without docs/example) [2]. The user feeds the path to the generated config file to the cbootimage program. You can see it as a configuration compiler. [2] https://www.debian.org/doc/debian-policy/ch-docs.html#s12.6 Ok. I understood now. But your d/control don't explain about it. So you must adapt the long description. You are putting files as build.sh and Makefile. They aren't examples. So, you must remove these files or put all files in /usr/share/[...] (it is usual in Debian). In this case, you can write an d/README.Debian to explain about the files in /usr/share. Note that the current package is generating this Lintian message: X: cbootimage-configs: duplicate-files usr/share/doc/cbootimage-configs/tegra114/nvidia/dalmore/build.sh usr/share/doc/cbootimage-configs/tegra124/nvidia/jetson-tk1/build.sh usr/share/doc/cbootimage-configs/tegra124/nvidia/venice2/build.sh usr/share/doc/cbootimage-configs/tegra20/avionic-design/medcom-wide/build.sh usr/share/doc/cbootimage-configs/tegra20/avionic-design/plutux/build.sh usr/share/doc/cbootimage-configs/tegra20/avionic-design/tec/build.sh usr/share/doc/cbootimage-configs/tegra20/compulab/trimslice/build.sh usr/share/doc/cbootimage-configs/tegra20/nvidia/harmony/build.sh usr/share/doc/cbootimage-configs/tegra20/nvidia/seaboard/build.sh usr/share/doc/cbootimage-configs/tegra20/nvidia/ventana/build.sh usr/share/doc/cbootimage-configs/tegra20/nvidia/whistler/build.sh usr/share/doc/cbootimage-configs/tegra20/toradex/colibri-t20/build.sh usr/share/doc/cbootimage-configs/tegra30/avionic-design/tec-ng/build.sh usr/share/doc/cbootimage-configs/tegra30/nvidia/beaver/build.sh usr/share/doc/cbootimage-configs/tegra30/nvidia/cardhu/build.sh usr/share/doc/cbootimage-configs/tegra30/toradex/colibri_t30/build.sh If you use the /usr/share/cbootimage-configs, the message will stop. I read quickly the README.txt and I saw that cbootimage will need of extracted files from NVidia hardware, right? If yes, I think that NVidia hardware content isn't free. So, if confirmed, cbootimage must be put in 'contrib'.[1] [1] https://www.debian.org/distrib/packages#note 6. d/rules: your rules has useless comments and is wrong. But your package is building documents only. So, I can't comment about d/rules yet. You need read about the upstream program (where put it). I think that you need all cfg files in /usr/share/cbootimage-configs to make a link from cbootimage. see above. You needn't of the 'export DH_OPTIONS'. Please, reply to all (I and the
Bug#741648: RFS: cbootimage/1.2-2
Hi Marc, On 05-09-14 16:29, Eriberto Mota wrote: Not mandatory or recommended by policy. However, a good practice commonly requested by all sponsors to allow the control of the code by you or any external people. You must implement it. Just to be sure, I read this as You must implement it if you want me [Eriberto Mota] to sponsor this package. Although I agree that it is common practice, I really think the must in general is out of place. You must review each file. Use 'grep -sriA25 copyright *' to help you. Or run licensecheck (check the man page). Paul signature.asc Description: OpenPGP digital signature
Bug#741648: RFS: cbootimage/1.2-2
Hi Paul, 2014-09-05 11:52 GMT-03:00 Paul Gevers elb...@debian.org: Not mandatory or recommended by policy. However, a good practice commonly requested by all sponsors to allow the control of the code by you or any external people. You must implement it. Just to be sure, I read this as You must implement it if you want me [Eriberto Mota] to sponsor this package. Although I agree that it is common practice, I really think the must in general is out of place. Currently, I meant was must. Please, don't understand it as an agressive act. However, I think it (VCS) is important and necessary. You must review each file. Use 'grep -sriA25 copyright *' to help you. Or run licensecheck (check the man page). You are right. But I always indicate grep because I already saw licensecheck hide some information. Maybe I need know as use it better. But grep will show all license text and the aditional names after the license. Paul Thanks Paul! Cheers, Eriberto -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#741648: RFS: cbootimage/1.2-2
Hi Marc, how are you? We need begin anew. So, I will analyse the packages from zero. In a first moment, we will work over cbootimage-configs only. Please: 1. The g GIT commit was on 2014-08-06. So, the version must be 0.0+20140806~git18e531f (I prefer git instead 'g'). 2. d/changelog: you need an ITP number. 3. d/control: you need a VCS to control your packaging. I think that already told you about it. Ask me if you have doubt. 4. d/copyright: you need remake this file. A short example is that you didn't told about build/* directory. Please, read (really) about 'copyright' here[1]. As a tip, if your main upstream is Nvidia, you can use a general reference to it. An example (not real for years range): Files: * Copyright: 2010-2014 NVIDIA CORPORATION i...@nvidia.com License: ZLIB After this, you must create new sections to exceptions only. This work must be precise.I and FTP Master will check each detail. [1] http://dep.debian.net/deps/dep5/#fields 5. d/docs: you is installing ALL files as documents. No! There is one document only: README.txt. The other files are your program. 6. d/rules: your rules has useless comments and is wrong. But your package is building documents only. So, I can't comment about d/rules yet. You need read about the upstream program (where put it). I think that you need all cfg files in /usr/share/cbootimage-configs to make a link from cbootimage. 7. d/watch is ok. Cheers, Eriberto 2014-09-03 8:09 GMT-03:00 Marc Dietrich marvi...@gmx.de: Hi Eriberto, Am Mittwoch 27 August 2014, 15:23:45 schrieb Eriberto: Hi Marc, 2014-08-26 9:32 GMT-03:00 Marc Dietrich marvi...@gmx.de: I think you didn't undertand my words. You must create a VCS to control your packaging (debian directory). Not create a VCS to point to upstream code. The Vcs-Git field must use git:// instead https://. Your mistake was put the Vcs-* in binaries instead in source block (after Homepage field). This and the problems below are a result of how I package the source. Let me explain it at bit more: cbootimage is used to flash the bootloader on tegra devices. To do this, it needs some machine specific config files. These config files are not part of the cbootimage repository, instead they live under their own one. To avoid creating two source packages, I decided to include the config tree in the program tree. This is possible according to https://wiki.debian.org/Projects/DebSrc3.0 (How to use multiple upstream tarball in 3.0 (quilt) format?). So I have two tarballs now: cbootimage_1.4.orig.tar.gz and cbootimage_1.4.orig-configs.tar.gz which create a binary and an platform independend package. So both packages need their own copyright (before cbootimage-1.0 didn't contain the config files). Ok. Thanks for your explanation. It is new for me. I read the texts and I tested all procedures. However, cbootimage-configs-1.4 doesn't exist in GitHub. So, you must use 0.0, the commit date and Git commit as version (or other similar format). An example for your case: 0.0~git20140806.18e531. To see more examples: $ dpkg -l | grep -i git. I don't see a motive to join the upstream codes. IMHO, it is undesirable in this case, because the upstream source codes are being updated in different times. Thus, I think you must package each code separatelly and make cbootimage dependent of the cbootimage-configs. I have similar sittuation in my life. See my packages (phpwebcounter, phpwebcounter-extra) and (album, album-extra). So, I intent to sponsor your work if you use two packages. ok, I splitted the packages in two (cbootimage + cbootimage-configs) and uploaded them again to mentors. ... mmh, I'm about to install a jessie system in a vm to get a current lintian. I guess I can ignore the pedantic warnings for now? No. All Lintian messages must be fixed wherever possible. because cbootimage-configs has no version, I added the watch file with some comment that is makes no sense for this package (no releases) as described in the debian handbook. Hopefully, that's all ... Please take a (-nother) look at it again. Thanks! Marc -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#741648: RFS: cbootimage/1.2-2
Am Montag 25 August 2014, 14:35:40 schrieb Eriberto: Hi Marc, 2014-08-25 10:47 GMT-03:00 Marc Dietrich marvi...@gmx.de: 1. d/control: - Change debhelper from 9.0.0 to 9. You didn't it. ups, I thought you meant the compat file. - Create a VCS to control your /debian versions. You can use github or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to d/control. mmh, dpkg-buildpackage seems not to understand Vcs-* tags (Ubuntu 14.04). I added them anyways. I think you didn't undertand my words. You must create a VCS to control your packaging (debian directory). Not create a VCS to point to upstream code. The Vcs-Git field must use git:// instead https://. Your mistake was put the Vcs-* in binaries instead in source block (after Homepage field). This and the problems below are a result of how I package the source. Let me explain it at bit more: cbootimage is used to flash the bootloader on tegra devices. To do this, it needs some machine specific config files. These config files are not part of the cbootimage repository, instead they live under their own one. To avoid creating two source packages, I decided to include the config tree in the program tree. This is possible according to https://wiki.debian.org/Projects/DebSrc3.0 (How to use multiple upstream tarball in 3.0 (quilt) format?). So I have two tarballs now: cbootimage_1.4.orig.tar.gz and cbootimage_1.4.orig-configs.tar.gz which create a binary and an platform independend package. So both packages need their own copyright (before cbootimage-1.0 didn't contain the config files). I wonder if I should just add a plain copyright file which only contains my stuff under debian/*. Regarding Vcs fields, I haven't found a solution how to add multiple Vcs-* fields (for multiple source tarballs). At least the debian handbook allows it. Github defaults to https btw. 2. d/copyright: update the packaging copyright years from 2013 to 2013-2014 and upstream copyright years to 2012-2013. ok. Your packaging years are wrong. You already have the cbootimage 1.0-1 in Debian and it was uploaded in 2013. You renamed the d/copyright to d/cbootimage.copyright. This procedure is inadequate. 3. Do you saw that already there the 1.4 version? yes, I already created a 1.3 version. Nevertheless, I updated to 1.4 now. Ok. 4. Some lintan messages[2] that you need to fix: cbootimage: description-possibly-contains-homepage http://http.download.nvidia.com/tegra-public-appnotes/bct-overview.html. W: cbootimage: binary-without-manpage usr/bin/bct_dump W: cbootimage: binary-without-manpage usr/bin/cbootimage In v1.3 I added man (self written) pages. I still want to convert them using a more common tool (from xml to man). Maybe later. I also added the config files for cbootimage, which normally live in a seperate repository. I didn't want to create another source package for these, because basicly, they belong together (you cannot use cbootimage without a config, but you can run it). Sorry but not acceptable. You can't 'inject' code in original upstream code. Debian will distribute this source code as original. So, you must keep it original. see above. Feel free to re-check the result. You have several Lintian messages: I: cbootimage source: quilt-patch-missing-description add-man-pages.diff W: cbootimage source: no-debian-copyright P: cbootimage source: debian-watch-may-check-gpg-signature P: cbootimage-configs: no-upstream-changelog E: cbootimage-configs: copyright-should-refer-to-common-license-file-for-gpl I: cbootimage-configs: extended-description-is-probably-too-short W: cbootimage-configs: package-contains-vcs-control-file usr/share/cbootimage/configs/.gitignore W: cbootimage-configs: executable-not-elf-or-script usr/share/cbootimage/configs/tegra124/nvidia/jetson-tk1/PM375_Hynix_2GB_H5TC 4G63AFR_RDA_924MHz.bct.cfg W: cbootimage-configs: executable-not-elf-or-script usr/share/cbootimage/configs/tegra30/toradex/colibri_t30/colibri_t30_12MHz_1 GB_NT5CC256M16CP-DI_400MHz-shmoo.bct.cfg P: cbootimage: no-upstream-changelog mmh, I'm about to install a jessie system in a vm to get a current lintian. I guess I can ignore the pedantic warnings for now? How to fix the wrong permissions? Rest should be fixed now. Your package needs more attention if you really want to upload it to Debian. Please, read the 'Debian New Maintainers Guide'[1] to you understand how a Debian package works. well, I read this. I'm not packaging stuff on a daily basis (maybe only one per year?), and have only limited time. So forgive me if my respond is slow and issues still exist. Marc -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#741648: RFS: cbootimage/1.2-2
Hi Eriberto, Am Dienstag 19 August 2014, 10:20:45 schrieb Eriberto Mota: Hi Marc, Please: 1. d/control: - Consider change the priority to optional. Please, read it[1]. - Change debhelper from 9.0.0 to 9. - Create a VCS to control your /debian versions. You can use github or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to d/control. mmh, dpkg-buildpackage seems not to understand Vcs-* tags (Ubuntu 14.04). I added them anyways. 2. d/copyright: update the packaging copyright years from 2013 to 2013-2014 and upstream copyright years to 2012-2013. ok. 3. Do you saw that already there the 1.4 version? yes, I already created a 1.3 version. Nevertheless, I updated to 1.4 now. 4. Some lintan messages[2] that you need to fix: cbootimage: description-possibly-contains-homepage http://http.download.nvidia.com/tegra-public-appnotes/bct-overview.html. W: cbootimage: binary-without-manpage usr/bin/bct_dump W: cbootimage: binary-without-manpage usr/bin/cbootimage In v1.3 I added man (self written) pages. I still want to convert them using a more common tool (from xml to man). Maybe later. I also added the config files for cbootimage, which normally live in a seperate repository. I didn't want to create another source package for these, because basicly, they belong together (you cannot use cbootimage without a config, but you can run it). Feel free to re-check the result. Marc -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#741648: RFS: cbootimage/1.2-2
tags 741648 - moreinfo thanks Hi Eriberto, Am Dienstag 19 August 2014, 10:20:45 schrieb Eriberto Mota: Hi Marc, Please: 1. d/control: - Consider change the priority to optional. Please, read it[1]. - Change debhelper from 9.0.0 to 9. - Create a VCS to control your /debian versions. You can use github or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to d/control. mmh, dpkg-buildpackage seems not to understand Vcs-* tags (Ubuntu 14.04). I added them anyways. 2. d/copyright: update the packaging copyright years from 2013 to 2013-2014 and upstream copyright years to 2012-2013. ok. 3. Do you saw that already there the 1.4 version? yes, I already created a 1.3 version. Nevertheless, I updated to 1.4 now. 4. Some lintan messages[2] that you need to fix: cbootimage: description-possibly-contains-homepage http://http.download.nvidia.com/tegra-public-appnotes/bct-overview.html. W: cbootimage: binary-without-manpage usr/bin/bct_dump W: cbootimage: binary-without-manpage usr/bin/cbootimage In v1.3 I added man (self written) pages. I still want to convert them using a more common tool (from xml to man). Maybe later. I also added the config files for cbootimage, which normally live in a seperate repository. I didn't want to create another source package for these, because basicly, they belong together (you cannot use cbootimage without a config, but you can run it). Feel free to re-check the result. Marc -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#741648: RFS: cbootimage/1.2-2
Hi Marc, 2014-08-25 10:47 GMT-03:00 Marc Dietrich marvi...@gmx.de: 1. d/control: - Change debhelper from 9.0.0 to 9. You didn't it. - Create a VCS to control your /debian versions. You can use github or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to d/control. mmh, dpkg-buildpackage seems not to understand Vcs-* tags (Ubuntu 14.04). I added them anyways. I think you didn't undertand my words. You must create a VCS to control your packaging (debian directory). Not create a VCS to point to upstream code. The Vcs-Git field must use git:// instead https://. Your mistake was put the Vcs-* in binaries instead in source block (after Homepage field). 2. d/copyright: update the packaging copyright years from 2013 to 2013-2014 and upstream copyright years to 2012-2013. ok. Your packaging years are wrong. You already have the cbootimage 1.0-1 in Debian and it was uploaded in 2013. You renamed the d/copyright to d/cbootimage.copyright. This procedure is inadequate. 3. Do you saw that already there the 1.4 version? yes, I already created a 1.3 version. Nevertheless, I updated to 1.4 now. Ok. 4. Some lintan messages[2] that you need to fix: cbootimage: description-possibly-contains-homepage http://http.download.nvidia.com/tegra-public-appnotes/bct-overview.html. W: cbootimage: binary-without-manpage usr/bin/bct_dump W: cbootimage: binary-without-manpage usr/bin/cbootimage In v1.3 I added man (self written) pages. I still want to convert them using a more common tool (from xml to man). Maybe later. I also added the config files for cbootimage, which normally live in a seperate repository. I didn't want to create another source package for these, because basicly, they belong together (you cannot use cbootimage without a config, but you can run it). Sorry but not acceptable. You can't 'inject' code in original upstream code. Debian will distribute this source code as original. So, you must keep it original. Feel free to re-check the result. You have several Lintian messages: I: cbootimage source: quilt-patch-missing-description add-man-pages.diff W: cbootimage source: no-debian-copyright P: cbootimage source: debian-watch-may-check-gpg-signature P: cbootimage-configs: no-upstream-changelog E: cbootimage-configs: copyright-should-refer-to-common-license-file-for-gpl I: cbootimage-configs: extended-description-is-probably-too-short W: cbootimage-configs: package-contains-vcs-control-file usr/share/cbootimage/configs/.gitignore W: cbootimage-configs: executable-not-elf-or-script usr/share/cbootimage/configs/tegra124/nvidia/jetson-tk1/PM375_Hynix_2GB_H5TC4G63AFR_RDA_924MHz.bct.cfg W: cbootimage-configs: executable-not-elf-or-script usr/share/cbootimage/configs/tegra30/toradex/colibri_t30/colibri_t30_12MHz_1GB_NT5CC256M16CP-DI_400MHz-shmoo.bct.cfg P: cbootimage: no-upstream-changelog Your package needs more attention if you really want to upload it to Debian. Please, read the 'Debian New Maintainers Guide'[1] to you understand how a Debian package works. Regards, Eriberto -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#741648: RFS: cbootimage/1.2-2
tags 741648 moreinfo thanks Hi Marc, Please: 1. d/control: - Consider change the priority to optional. Please, read it[1]. - Change debhelper from 9.0.0 to 9. - Create a VCS to control your /debian versions. You can use github or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to d/control. 2. d/copyright: update the packaging copyright years from 2013 to 2013-2014 and upstream copyright years to 2012-2013. 3. Do you saw that already there the 1.4 version? 4. Some lintan messages[2] that you need to fix: cbootimage: description-possibly-contains-homepage http://http.download.nvidia.com/tegra-public-appnotes/bct-overview.html. W: cbootimage: binary-without-manpage usr/bin/bct_dump W: cbootimage: binary-without-manpage usr/bin/cbootimage If you want offer a homepage to final user, please use the d/README.Debian. Thanks for your work. Cheers, Eriberto [1] https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities [2] http://bit.ly/lintian 2014-03-14 19:22 GMT-03:00 Marc Dietrich marvi...@gmx.de: Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package cbootimage * Package name: cbootimage Version : 1.2-2 Upstream Author : Stephan Warren (swar...@nvidia.com) from NVIDIA * URL : http://github.com/NVIDIA/cbootimage * License : GPL 2+ Section : utils It builds those binary packages: cbootimage - Tools to dump and generate boot config table on Tegra devices To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cbootimage Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cbootimage/cbootimage_1.2-2.dsc More information about hello can be obtained from http://http.download.nvidia.com/tegra-public-appnotes/bct-overview.html. Changes since the last upload: cbootimage (1.2-2) unstable; urgency=low * Use Debian standards version 3.9.5 * Add watch file cbootimage (1.2-1) unstable; urgency=low * New upstream release Regards, Marc Dietrich -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140314232229.884b849b96fbfe440591e...@gmx.de -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#741648: RFS: cbootimage/1.2-2
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package cbootimage * Package name: cbootimage Version : 1.2-2 Upstream Author : Stephan Warren (swar...@nvidia.com) from NVIDIA * URL : http://github.com/NVIDIA/cbootimage * License : GPL 2+ Section : utils It builds those binary packages: cbootimage - Tools to dump and generate boot config table on Tegra devices To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cbootimage Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cbootimage/cbootimage_1.2-2.dsc More information about hello can be obtained from http://http.download.nvidia.com/tegra-public-appnotes/bct-overview.html. Changes since the last upload: cbootimage (1.2-2) unstable; urgency=low * Use Debian standards version 3.9.5 * Add watch file cbootimage (1.2-1) unstable; urgency=low * New upstream release Regards, Marc Dietrich -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org