Bug#742033: Support for extended attributes causes errors on ls
On 03/18/2014 03:10 PM, Goswin von Brederlow wrote:
Package: unionfs-fuse
Version: 0.24-2.1
Severity: normal
Tags: patch upstream
Hi,
I've compiled unionfs-fuse with extended attribute support and now I'm
getting errors on ls:
ls -lh union/
ls: union/stats: No such file or directory
total 4.0K
-rw-rw-r-- 1 brederlo users4 Mar 18 14:43 foo
-r--r--r-- 1 root root 2.0K Jan 1 1970 stats
The reason is that the lgetxattr() callback doesn't handle the stats
file. This is simple to fix with the patch below.
MfG
Goswin
--
Index: unionfs-fuse-0.24/src/unionfs.c
===
--- unionfs-fuse-0.24.orig/src/unionfs.c2014-03-18 15:08:54.526796991
+0100
+++ unionfs-fuse-0.24/src/unionfs.c 2014-03-18 15:09:01.703071796 +0100
@@ -639,6 +639,10 @@
static int unionfs_getxattr(const char *path, const char *name, char *value,
size_t size) {
DBG_IN();
+ if (uopt.stats_enabled strcmp(path, STATS_FILENAME) == 0) {
+ return -ENODATA;
+ }
+
int i = find_rorw_branch(path);
if (i == -1) return -errno;
I think this is fixed upstream already, but upstream and this patch
don't make it the way I want to have it.
I hope I find some time over the weekend to test the ioctl patches I
started to work on some time ago. And with ioctl support and the new
unionfs-fuse-ctl there is no need anymore for the ugly stats hack at all.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#742033: Support for extended attributes causes errors on ls
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
hi goswin!
thank you very much for your patch! unfortunately, at least on my
system, the problem was also in the listxattr. so, i've patched all
*xattr functions to return 'not supported' for the stats file.
please let me know if this does not fix the error for you.
also, i looks like you're using old version of unionfs-fuse. see my hg
repo at http://hg.podgorny.cz/unionfs-fuse for the latest code.
thanks,
R.
On 03/18/2014 03:10 PM, Goswin von Brederlow wrote:
Package: unionfs-fuse Version: 0.24-2.1 Severity: normal Tags:
patch upstream
Hi,
I've compiled unionfs-fuse with extended attribute support and now
I'm getting errors on ls:
ls -lh union/ ls: union/stats: No such file or directory total
4.0K -rw-rw-r-- 1 brederlo users4 Mar 18 14:43 foo -r--r--r-- 1
root root 2.0K Jan 1 1970 stats
The reason is that the lgetxattr() callback doesn't handle the
stats file. This is simple to fix with the patch below.
MfG Goswin
--
Index: unionfs-fuse-0.24/src/unionfs.c
===
- --- unionfs-fuse-0.24.orig/src/unionfs.c 2014-03-18 15:08:54.526796991
+0100
+++ unionfs-fuse-0.24/src/unionfs.c 2014-03-18 15:09:01.703071796
+0100 @@ -639,6 +639,10 @@ static int unionfs_getxattr(const char
*path, const char *name, char *value, size_t size) { DBG_IN();
+ if (uopt.stats_enabled strcmp(path, STATS_FILENAME) == 0) { +
return -ENODATA; +} + int i = find_rorw_branch(path); if (i == -1)
return -errno;
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlMrNa4ACgkQ7mej6pjlbYQ7vgCfT9MYNKVWThhw/VOW3UPPYoCd
qE4An2fMXU0XM6afMaAQkHeMFmexCdlh
=dq6m
-END PGP SIGNATURE-
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#742033: Support for extended attributes causes errors on ls
Package: unionfs-fuse
Version: 0.24-2.1
Severity: normal
Tags: patch upstream
Hi,
I've compiled unionfs-fuse with extended attribute support and now I'm
getting errors on ls:
ls -lh union/
ls: union/stats: No such file or directory
total 4.0K
-rw-rw-r-- 1 brederlo users4 Mar 18 14:43 foo
-r--r--r-- 1 root root 2.0K Jan 1 1970 stats
The reason is that the lgetxattr() callback doesn't handle the stats
file. This is simple to fix with the patch below.
MfG
Goswin
--
Index: unionfs-fuse-0.24/src/unionfs.c
===
--- unionfs-fuse-0.24.orig/src/unionfs.c2014-03-18 15:08:54.526796991
+0100
+++ unionfs-fuse-0.24/src/unionfs.c 2014-03-18 15:09:01.703071796 +0100
@@ -639,6 +639,10 @@
static int unionfs_getxattr(const char *path, const char *name, char *value,
size_t size) {
DBG_IN();
+ if (uopt.stats_enabled strcmp(path, STATS_FILENAME) == 0) {
+ return -ENODATA;
+ }
+
int i = find_rorw_branch(path);
if (i == -1) return -errno;
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
