Bug#742864: Update to jdk8u20-b18

2014-06-21 Thread Thomas Klute
Am 18.06.2014 14:55, schrieb Emmanuel Bourg:
 Even if removing the generated files could avoid mistakes like updating
 the control file but not its template, I lean toward keeping them for
 the convenience. Checking out the package and not seeing debian/control
 could also be confusing.

I disagree. Having a generated file in the source repository is
surprising and thereby confusing. I assumed I had to change the g++
dependency precisely for that reason. Sure, I would have been surprised
if the checkout had not contained a debian/control file, but then I
would have checked what's going on and subsequently understood.

Equally, convenience is actually a point against keeping a generated
control file in the repository: People will need to regenerate the file
for their build systems and then will have local changes that cannot be
merged upstream. This is generally annoying, and especially with Git
operations that require a clean tree.

Of course, the debian/control file would belong in a source package for
a specific version. In my opinion the clean solution is to ignore
generated files for the VCS tree, and if that requires many preparation
steps before build, script them.

Kind regards,
Thomas


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#742864: Update to jdk8u20-b18

2014-06-18 Thread Thomas Klute
Am 17.06.2014 22:08, schrieb Emmanuel Bourg:
 Le 17/06/2014 20:09, Thomas Klute a écrit :
 * g++-4.9 was a hardcoded build dependency, but is not available on
   stable. I could build the package with g++-4.7 from Wheezy, so I've
   changed the dependency to g++ = 4.7.
 
 Actually debian/control is generated from a template
 (debian/templates/control.in) and has to be refreshed for your
 distribution. You do that by touching the template and running
 './debian/rules debian/control'. This is a bit tricky, I'll document it
 in debian/README.source.

OK, I didn't know about that. I that case I suggest removing
debian/control from the repository after that step is documented. I've
rebased my master branch on your repository and added a patch to that
effect, including documentation. [1]

 * I filed bug #751873, which was promptly fixed (many thanks to the QA
   team!), so we can now use
   http://qa.debian.org/cgi-bin/fakeupstream.cgi to get the latest
   upstream sources.
 
 I believe there is a new tag every week or so, I don't think we really
 want to push updates that fast. Currently the package tracks the OpenJDK
 builds used by Oracle to release the official version of Java. This is
 done by parsing the documentation download page [1], I wrote a small PHP
 page [2] that performs this task for Java 7 and 8.

Good point. I'll keep the jdk8u20-b18 branch around and might
occasionally rebase it to keep track of master changes. ;-)

Thomas

[1] https://github.com/airtower-luna/openjdk-8-debpkg.git master


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#742864: Update to jdk8u20-b18

2014-06-18 Thread Emmanuel Bourg
Le 18/06/2014 14:25, Thomas Klute a écrit :

 OK, I didn't know about that. I that case I suggest removing
 debian/control from the repository after that step is documented.

I've added a note about debian/control in README.source.

Even if removing the generated files could avoid mistakes like updating
the control file but not its template, I lean toward keeping them for
the convenience. Checking out the package and not seeing debian/control
could also be confusing.

Emmanuel Bourg


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#742864: Update to jdk8u20-b18

2014-06-17 Thread Thomas Klute
Hi everyone,

I've cloned Emmanuel's repository and worked with it on Wheezy
(amd64). Results so far:

* I've updated the build system to work with the newest upstream
  version (jdk8u29-b18). Refreshing the patches was fairly
  straightforward, but I'd be great if someone with more knowledge of
  OpenJDK internals could review them.

* g++-4.9 was a hardcoded build dependency, but is not available on
  stable. I could build the package with g++-4.7 from Wheezy, so I've
  changed the dependency to g++ = 4.7.

* The package builds successfully if (and only if) nostrip is set in
  DEB_BUILD_OPTIONS. I haven't done extensive tests yet, but the
  result looks good so far. I have not tried building or running
  alternative JVMs.

* I filed bug #751873, which was promptly fixed (many thanks to the QA
  team!), so we can now use
  http://qa.debian.org/cgi-bin/fakeupstream.cgi to get the latest
  upstream sources.

* I've also changed the top directory in the archive created by
  debian/orig-tar.sh to match the package name. That avoids some
  confusion, because for me the sources initially didn't show up where
  they should have.

You can find my patches on GitHub:

Webinterface:
https://github.com/airtower-luna/openjdk-8-debpkg/tree/jdk8u20-b18

Clone/pull URL: https://github.com/airtower-luna/openjdk-8-debpkg.git
Branch: jdk8u20-b18

Kind regards,
Thomas


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#742864: Update to jdk8u20-b18

2014-06-17 Thread Emmanuel Bourg
Hi Thomas,

Thank you very much for your help with OpenJDK 8.

Le 17/06/2014 20:09, Thomas Klute a écrit :

 * g++-4.9 was a hardcoded build dependency, but is not available on
   stable. I could build the package with g++-4.7 from Wheezy, so I've
   changed the dependency to g++ = 4.7.

Actually debian/control is generated from a template
(debian/templates/control.in) and has to be refreshed for your
distribution. You do that by touching the template and running
'./debian/rules debian/control'. This is a bit tricky, I'll document it
in debian/README.source.


 * I filed bug #751873, which was promptly fixed (many thanks to the QA
   team!), so we can now use
   http://qa.debian.org/cgi-bin/fakeupstream.cgi to get the latest
   upstream sources.

I believe there is a new tag every week or so, I don't think we really
want to push updates that fast. Currently the package tracks the OpenJDK
builds used by Oracle to release the official version of Java. This is
done by parsing the documentation download page [1], I wrote a small PHP
page [2] that performs this task for Java 7 and 8.

That said, tracking the Mercurial tags will be useful for OpenJDK 9
until it's officially released.


 You can find my patches on GitHub:
 
 Webinterface:
 https://github.com/airtower-luna/openjdk-8-debpkg/tree/jdk8u20-b18
 
 Clone/pull URL: https://github.com/airtower-luna/openjdk-8-debpkg.git
 Branch: jdk8u20-b18

Excellent, I'll pull the changes I can apply now, but I'll wait for Java
8u20 before updating the patches.

Emmanuel Bourg


[1]
http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html
[2] http://87.98.165.193/checkjdk.php


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org