Bug#742940: since: Does not work on mips (includes test suite failures and FTBFS)
The NMU patch for since_1.1-4.1 is below.
debdiff since_1.1-4.dsc since_1.1-4.1.dsc
diff -Nru since-1.1/debian/changelog since-1.1/debian/changelog
--- since-1.1/debian/changelog 2014-03-29 03:54:11.0 +
+++ since-1.1/debian/changelog 2014-04-08 05:35:59.0 +0100
@@ -1,3 +1,13 @@
+since (1.1-4.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * For mips/mipsel ABIO32, define int d_dev as unsigned long int.
+Add dev_t.patch.
+Patch by Aleksandar Zlicic.
+Closes: #742940
+
+ -- Anibal Monsalve Salazar ani...@debian.org Tue, 08 Apr 2014 05:35:53
+0100
+
since (1.1-4) unstable; urgency=medium
* Switch to a git-buildpackage compatible VCS layout
diff -Nru since-1.1/debian/patches/dev_t.patch
since-1.1/debian/patches/dev_t.patch
--- since-1.1/debian/patches/dev_t.patch1970-01-01 01:00:00.0
+0100
+++ since-1.1/debian/patches/dev_t.patch2014-04-08 05:34:16.0
+0100
@@ -0,0 +1,34 @@
+Date: Mon, 7 Apr 2014 21:00:39 +0200
+From: Aleksandar Zlicic aleksandar.zli...@imgtec.com
+Subject: For mips/mipsel ABIO32, define int d_dev as unsigned long int
+
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=742940
+
+The cause of this problem is that st_dev member of structure stat,
+defined in /usr/include/mipsel-linux-gnu/bits/stat.h,
+is expected to be of type dev_t.
+
+But for mips/mipsel ABIO32 it is defined as 'unsigned long int'.
+And dev_t type is defined as 'unsigned long long int'.
+
+Same behavior is observed on hurd-i386:
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=591386
+
+Attached patch fixes package on mips/mipsel.
+
+Index: since-1.1/since.c
+===
+--- a/since.c 2014-04-08 01:51:28.0 +0100
b/since.c 2014-04-08 01:53:10.615161295 +0100
+@@ -52,7 +52,11 @@ struct fmt_map{
+ struct data_file{
+ int d_fd;
+ char *d_name;
++#if defined (__mips__ ) (_MIPS_SIM == _ABIO32)
++ unsigned long int d_dev;
++#else
+ dev_t d_dev;
++#endif
+ ino_t d_ino;
+ off_t d_had;
+ off_t d_now;
diff -Nru since-1.1/debian/patches/series since-1.1/debian/patches/series
--- since-1.1/debian/patches/series 2014-03-29 01:49:10.0 +
+++ since-1.1/debian/patches/series 2014-04-08 02:15:53.0 +0100
@@ -1,2 +1,3 @@
hurd-path-max.patch
optimize-makefile.patch
+dev_t.patch
signature.asc
Description: Digital signature
Bug#742940: since: Does not work on mips (includes test suite failures and FTBFS)
The cause of problem is that st_dev member of structure stat,
defined in /usr/include/mipsel-linux-gnu/bits/stat.h,
is expected to be of type dev_t.
But for mips/mipsel ABIO32 it is defined as 'unsigned long int'.
dev_t type is defined as 'unsigned long long int'.
Attached patch fixes package on mips/mipsel.
Could you please consider including these changes
in order to build since for mips/mipsel architectures?
Thanks
Aleksandar Zlicic
Index: since-1.1/since.c
===
--- since-1.1.orig/since.c 2014-04-03 14:01:50.0 +
+++ since-1.1/since.c 2014-04-07 15:32:15.0 +
@@ -52,7 +52,11 @@
struct data_file{
int d_fd;
char *d_name;
+#if defined (__mips__ ) (_MIPS_SIM == _ABIO32)
+ unsigned long int d_dev;
+#else
dev_t d_dev;
+#endif
ino_t d_ino;
off_t d_had;
off_t d_now;
Bug#742940: since: Does not work on mips (includes test suite failures and FTBFS)
On Sat, 2014-03-29 07:17:33 +0100, Axel Beckert wrote: Package: since Version: 1.1-4 Severity: serious Tags: upstream Package version 1.1-4 added a build-time test-suite which revealed that since on mips does not work properly: $ echo foo foo $ since foo foo $ since foo since: considering foo to be truncated, displaying from start foo $ Expected behaviour would be: $ echo foo foo $ since foo foo $ since foo $ I'll contact upstream about this and #591386 and if we don't find a proper fix that soonish, I'll probably drop these two architectures from the package. At imgtec.com, we are testing a fix for this bug. A patch will be posted soon. Given the different symptoms, I suspect that this issue and #591386 (does not work on Hurd) are different issues. Regards, Axel -- ,''`. | Axel Beckert a...@debian.org, http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE `-| 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 signature.asc Description: Digital signature
Bug#742940: since: Does not work on mips (includes test suite failures and FTBFS)
Package: since Version: 1.1-4 Severity: serious Tags: upstream Package version 1.1-4 added a build-time test-suite which revealed that since on mips does not work properly: $ echo foo foo $ since foo foo $ since foo since: considering foo to be truncated, displaying from start foo $ Expected behaviour would be: $ echo foo foo $ since foo foo $ since foo $ I'll contact upstream about this and #591386 and if we don't find a proper fix that soonish, I'll probably drop these two architectures from the package. Given the different symptoms, I suspect that this issue and #591386 (does not work on Hurd) are different issues. Regards, Axel -- ,''`. | Axel Beckert a...@debian.org, http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE `-| 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
