Bug#745980: libdbi1: Memory leak in dbi_conn_close
Hi, On Mon, Apr 28, 2014 at 12:56:51PM +0200, Markus Hoenicka wrote: > Am 2014-04-28 09:30, schrieb László Böszörményi: > >On Sun, Apr 27, 2014 at 5:41 PM, Markus Hoenicka > > wrote: > >>>Package: libdbi1 > >>>Version: 0.9.0-2 > >>>Severity: important > >>>Tags: upstream > >>> > >>>That is, the memory behind 'conn' is leaked if the object was not > >>>connected. This happens, for example, if connecting to the DB fails. > >> > >>Thanks for the report and the explanation. Fixed upstream. > > How severe is it? Should I get it to the Debian package or any plan > >for a new release? > > > >Cheers, > >Laszlo/GCS > > Depends on usage. If you use SQLite as a backend, then you'll hardly > ever see failing connection attempts (unless your HD is full, but > then you're in trouble anyway). If you use something like MySQL > running on a remote server with occasional network glitches, lost > memory may pile up. How severe that is depends on how your > application is written. If it is a forking server that dies once it > is done with a connection, it probably won't hurt. If it is a > non-forking program running 24/7, it will matter eventually. It also depends on whether the application reuses the dbi_conn object upon failure and simply tries to reconnect or whether it destroys the existing object and then starts over with dbi_conn_open. Only in the latter case, the memory (~ 100-200 bytes iIrc) will be lost. I think it's fine to wait for a new upstream release. Cheers, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin signature.asc Description: Digital signature
Bug#745980: libdbi1: Memory leak in dbi_conn_close
Am 2014-04-28 09:30, schrieb László Böszörményi: Hi, On Sun, Apr 27, 2014 at 5:41 PM, Markus Hoenicka wrote: Package: libdbi1 Version: 0.9.0-2 Severity: important Tags: upstream That is, the memory behind 'conn' is leaked if the object was not connected. This happens, for example, if connecting to the DB fails. Thanks for the report and the explanation. Fixed upstream. How severe is it? Should I get it to the Debian package or any plan for a new release? Cheers, Laszlo/GCS Depends on usage. If you use SQLite as a backend, then you'll hardly ever see failing connection attempts (unless your HD is full, but then you're in trouble anyway). If you use something like MySQL running on a remote server with occasional network glitches, lost memory may pile up. How severe that is depends on how your application is written. If it is a forking server that dies once it is done with a connection, it probably won't hurt. If it is a non-forking program running 24/7, it will matter eventually. I'm pretty sure I won't be able to do a new release this week. If adding the patch to the package is faster, this is the way to go. regards, Markus -- Markus Hoenicka http://www.mhoenicka.de AQ score 38 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#745980: libdbi1: Memory leak in dbi_conn_close
Hi, On Sun, Apr 27, 2014 at 5:41 PM, Markus Hoenicka wrote: >> Package: libdbi1 >> Version: 0.9.0-2 >> Severity: important >> Tags: upstream >> >> That is, the memory behind 'conn' is leaked if the object was not >> connected. This happens, for example, if connecting to the DB fails. > > Thanks for the report and the explanation. Fixed upstream. How severe is it? Should I get it to the Debian package or any plan for a new release? Cheers, Laszlo/GCS -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#745980: libdbi1: Memory leak in dbi_conn_close
Am 2014-04-26 23:15, schrieb Sebastian Harl: Package: libdbi1 Version: 0.9.0-2 Severity: important Tags: upstream Hi, in dbi_conn_close: if (!conn || !(conn->connection)) return; … free(conn); That is, the memory behind 'conn' is leaked if the object was not connected. This happens, for example, if connecting to the DB fails. Cheers, Sebastian Thanks for the report and the explanation. Fixed upstream. regards, Markus -- Markus Hoenicka http://www.mhoenicka.de AQ score 38 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#745980: libdbi1: Memory leak in dbi_conn_close
Package: libdbi1 Version: 0.9.0-2 Severity: important Tags: upstream Hi, in dbi_conn_close: if (!conn || !(conn->connection)) return; … free(conn); That is, the memory behind 'conn' is leaked if the object was not connected. This happens, for example, if connecting to the DB fails. Cheers, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin signature.asc Description: Digital signature
