Bug#747703: bpo60 vlc should not pull samba4 from bpo too
Am Sonntag, den 11.05.2014, 16:43 +0400 schrieb Michael Tokarev: > 11.05.2014 16:21, Michael Tokarev wrote: > [] > > It looks like just adding > > > > SMBCLIENT_CFLAGS=" " SMBCLIENT_LIBS=-lsmbclient > > > > environment variables to ./configure invocation fixes this issue. > > (SMBCLIENT_CFLAGS should not be empty or else it won't be recognized). > > http://www.corpit.ru/debian/tls/vlc/ , and in particular, > http://www.corpit.ru/debian/tls/vlc/vlc_2.1.2-2~bpo70+3.debdiff > > I can just upload it now. +1 from me for this sane patch. Please go ahead and upload 2.1.4-1~pbo70 +1 with your patch. Do you want to become a co-maintainer of vlc? -- Benjamin Drung Debian & Ubuntu Developer -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#747703: bpo60 vlc should not pull samba4 from bpo too
On Sun, May 11, 2014 at 8:43 AM, Michael Tokarev wrote: > 11.05.2014 16:21, Michael Tokarev wrote: > [] >> It looks like just adding >> >> SMBCLIENT_CFLAGS=" " SMBCLIENT_LIBS=-lsmbclient >> >> environment variables to ./configure invocation fixes this issue. >> (SMBCLIENT_CFLAGS should not be empty or else it won't be recognized). > > http://www.corpit.ru/debian/tls/vlc/ , and in particular, > http://www.corpit.ru/debian/tls/vlc/vlc_2.1.2-2~bpo70+3.debdiff > > I can just upload it now. > > (Tested and it works). The patch makes very much sense to me. Yes, please go ahead and upload. -- regards, Reinhard -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#747703: bpo60 vlc should not pull samba4 from bpo too
11.05.2014 16:21, Michael Tokarev wrote: [] > It looks like just adding > > SMBCLIENT_CFLAGS=" " SMBCLIENT_LIBS=-lsmbclient > > environment variables to ./configure invocation fixes this issue. > (SMBCLIENT_CFLAGS should not be empty or else it won't be recognized). http://www.corpit.ru/debian/tls/vlc/ , and in particular, http://www.corpit.ru/debian/tls/vlc/vlc_2.1.2-2~bpo70+3.debdiff I can just upload it now. (Tested and it works). Thanks, /mjt -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#747703: bpo60 vlc should not pull samba4 from bpo too
11.05.2014 13:04, Michael Tokarev wrote: > Backport of vlc to wheezy uses libsmbclient from samba4, which > means that when installing vlc on a wheezy system, whole samba > suite has to be upgraded too if samba is installed. ... > I see the changelog entry in vlc: > > 2.1.2-2~bpo70+1: > Tighten build dependencies on gettext, libsmbclient (for pkg-config > file) and libav9 It looks like just adding SMBCLIENT_CFLAGS=" " SMBCLIENT_LIBS=-lsmbclient environment variables to ./configure invocation fixes this issue. (SMBCLIENT_CFLAGS should not be empty or else it won't be recognized). Indeed, in wheezy libsmbclient-dev there was no .pc file for pkg-config, and samba4 configure switched to using pkg-config to detect libsmbclient. So there are 2 possible solutions for this issue: 1) add the above hack (which works for both 3 and 4 versions of libsmbclient), and 2) modify configure.ac to include previous test for libsmbclient, as found in vlc-2.0. Note that 2) requires automake-1.4 to be available at build time (which is not in wheezy). Debdiff for case 1 is below. Thanks, /mjt --- +vlc (2.1.2-2~bpo70+3) wheezy-backports; urgency=low + + * lessen versioned build dependency on libsmbclient. + + -- Michael Tokarev Sun, 11 May 2014 16:18:18 +0400 + vlc (2.1.2-2~bpo70+2) wheezy-backports; urgency=low * No change rebuild. diff -Nru vlc-2.1.2/debian/control vlc-2.1.2/debian/control --- vlc-2.1.2/debian/control2014-01-24 05:15:42.0 +0400 +++ vlc-2.1.2/debian/control2014-05-11 16:18:17.0 +0400 @@ -77,7 +77,7 @@ libsdl1.2-dev (>= 1.2.10), libshout3-dev, libsidplay2-dev, - libsmbclient-dev (>= 2:3.6.19), + libsmbclient-dev, libspeex-dev (>= 1.0.5), libspeexdsp-dev (>= 1.0.5), libssh2-1-dev, diff -Nru vlc-2.1.2/debian/rules vlc-2.1.2/debian/rules --- vlc-2.1.2/debian/rules 2014-01-11 18:21:03.0 +0400 +++ vlc-2.1.2/debian/rules 2014-05-11 16:18:09.0 +0400 @@ -240,7 +240,7 @@ dh_auto_clean override_dh_auto_configure: - dh_auto_configure -- $(confflags) + SMBCLIENT_CFLAGS=" " SMBCLIENT_LIBS=-lsmbclient dh_auto_configure -- $(confflags) override_dh_auto_test: ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#747703: bpo60 vlc should not pull samba4 from bpo too
Source: vlc Version: 2.1.2-2~bpo70+2 Severity: serious Backport of vlc to wheezy uses libsmbclient from samba4, which means that when installing vlc on a wheezy system, whole samba suite has to be upgraded too if samba is installed. This is because vlc runtime-depends on libsmbclient >= the one it was built against, but samba, due to its nature, requires exact version of libsmbclient. So, in particular, samba3 requires libsmbclient from samba3. So when installing vlc, it automatically upgrades libsmbclient, which triggers upgrading whole samba. But upgrading samba from version 3 to version 4 is a major step, and should not be pefrormed as a side-step of some unrelated software. It is more: vlc ises jut a "tiny bit" of samba, yet pulls whole new major version of it. I see the changelog entry in vlc: 2.1.2-2~bpo70+1: Tighten build dependencies on gettext, libsmbclient (for pkg-config file) and libav9 I see there's no pkg-config file in version of libsmbclient-dev in wheezy, but since I don't know vlc sources and build process much I don't know how difficult it will be to build vlc with wheezy version of libsmbclient. Please consider doing so and allowing using samba from wheezy together with vlc from bpo. Thanks! /mjt -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
