Bug#750715: ipython: FTBFS against uglify 2.x series - uglifyjs -nc is not a supported option
Hi Julian, please consider to test this patch. Thanks! Index: debian/patches/packaged-js.patch === --- debian/patches/packaged-js.patch(revision 29613) +++ debian/patches/packaged-js.patch(working copy) @@ -6,7 +6,7 @@ mkdir -p bootstrap/js cat js/bootstrap-transition.js js/bootstrap-alert.js js/bootstrap-button.js js/bootstrap-carousel.js js/bootstrap-collapse.js js/bootstrap-dropdown.js js/bootstrap-modal.js js/bootstrap-tooltip.js js/bootstrap-popover.js js/bootstrap-scrollspy.js js/bootstrap-tab.js js/bootstrap-typeahead.js js/bootstrap-affix.js bootstrap/js/bootstrap.js -./node_modules/.bin/uglifyjs -nc bootstrap/js/bootstrap.js bootstrap/js/bootstrap.min.tmp.js -+uglifyjs -nc bootstrap/js/bootstrap.js bootstrap/js/bootstrap.min.tmp.js ++uglifyjs bootstrap/js/bootstrap.js bootstrap/js/bootstrap.min.tmp.js echo /*!\n* Bootstrap.js by @fat @mdo\n* Copyright 2012 Twitter, Inc.\n* http://www.apache.org/licenses/LICENSE-2.0.txt\n*/; bootstrap/js/copyright.js cat bootstrap/js/copyright.js bootstrap/js/bootstrap.min.tmp.js bootstrap/js/bootstrap.min.js rm bootstrap/js/copyright.js bootstrap/js/bootstrap.min.tmp.js
Bug#750715: ipython: FTBFS against uglify 2.x series - uglifyjs -nc is not a supported option
On 9 June 2014 16:29, Julian Taylor jtaylor.deb...@googlemail.com wrote: tags 750715 + help thanks As far as I understand uglify 1 and 2 are two different projects. Why must the version 2 package replace the version 1 pakage? that is not a viable strategy for hard to test javascript code. It seems to me it would be simpler to just have two packages. From the homepage of UglifyJS (https://github.com/mishoo/UglifyJS): I started working on UglifyJS's successor, version 2. It's almost a full rewrite (except for the parser which is heavily modified, everything else starts from scratch). I've detailed my reasons in the README, see the project page. https://github.com/mishoo/UglifyJS2 Version 1 will continue to be maintained for fixing show-stopper bugs, but no new features should be expected. They share the same namespace so installing both at same time would raise a package conflict. In my point of view, and according with manapage, it should be better go head with v2 and have as more as possible packages compatible with this version. As you can see, we have very few packages, at the moment, not compatible with uglifyjs2: https://wiki.debian.org/Javascript/Nodejs/Tasks/UglifyJS2.x Anyhow I don't know much about javascript so I probably need a patch. Really easy, just remove '-nc' option while calling uglifyjs in debian/patches/packaged-js.patch: -+ uglifyjs -nc bootstrap/js/bootstrap.js bootstrap/js/bootstrap.min.tmp.js ++ uglifyjs bootstrap/js/bootstrap.js bootstrap/js/bootstrap.min.tmp.js It is also compatible with uglifyjs v1, so you don't have to wait for uglifyjs2 in unstable to apply this change. That's all. Cheers, Leo. -- Ubuntu Member - http://launchpad.net/~l3on Home Page - http://leoiannacone.com GPG Key Id - 0xD282FC25 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#750715: ipython: FTBFS against uglify 2.x series - uglifyjs -nc is not a supported option
tags 750715 + help thanks As far as I understand uglify 1 and 2 are two different projects. Why must the version 2 package replace the version 1 pakage? that is not a viable strategy for hard to test javascript code. It seems to me it would be simpler to just have two packages. Anyhow I don't know much about javascript so I probably need a patch. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#750715: ipython: FTBFS against uglify 2.x series - uglifyjs -nc is not a supported option
Source: ipython
Severity: important
Dear maintainer,
your package fails to build from source with uglify version 2.4.13-1,
which is now in experimental and will be soon migrated to unstable.
Here a snip of buildlog:
make -C IPython/html/static/components/bootstrap/ bootstrap-js
make[2]: Entering directory
'/tmp/buildd/ipython-2.1.0/IPython/html/static/components/bootstrap'
mkdir -p bootstrap/js
cat js/bootstrap-transition.js js/bootstrap-alert.js js/bootstrap-button.js
js/bootstrap-carousel.js js/bootstrap-collapse.js js/bootstrap-dropdown.js
js/bootstrap-modal.js js/bootstrap-tooltip.js js/bootstrap-popover.js
js/bootstrap-scrollspy.js js/bootstrap-tab.js js/bootstrap-typeahead.js
js/bootstrap-affix.js bootstrap/js/bootstrap.js
uglifyjs -nc bootstrap/js/bootstrap.js bootstrap/js/bootstrap.min.tmp.js
`bootstrap/js/bootstrap.js` is not a supported option
Supported options:
{ sequences: true,
properties: true,
dead_code: true,
drop_debugger: true,
unsafe: false,
unsafe_comps: false,
conditionals: true,
comparisons: true,
evaluate: true,
booleans: true,
loops: true,
unused: true,
hoist_funs: true,
keep_fargs: false,
hoist_vars: false,
if_return: true,
join_vars: true,
cascade: true,
side_effects: true,
pure_getters: false,
pure_funcs: null,
negate_iife: true,
screw_ie8: false,
drop_console: false,
angular: false,
warnings: true,
global_defs: {} }
Makefile:74: recipe for target 'bootstrap/js/*.js' failed
make[2]: *** [bootstrap/js/*.js] Error 1
make[2]: Leaving directory
'/tmp/buildd/ipython-2.1.0/IPython/html/static/components/bootstrap'
debian/rules:67: recipe for target 'override_dh_install' failed
make[1]: *** [override_dh_install] Error 2
make[1]: Leaving directory '/tmp/buildd/ipython-2.1.0'
debian/rules:8: recipe for target 'binary' failed
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2
E: Failed autobuilding of package
I: user script
/srv/debomatic-amd64/experimental/build/cow.29670/tmp/hooks/C00iptables starting
Chain OUTPUT (policy ACCEPT)
target prot opt source destination
I: user script
/srv/debomatic-amd64/experimental/build/cow.29670/tmp/hooks/C00iptables finished
I: unmounting dev/pts filesystem
I: unmounting proc filesystem
The options -nc (no copyright) is no longer supported.
Thanks in advance,
Leo.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
