Bug#753110: RFS: mrrescue/1.02c-1 [ITP]

2014-10-25 Thread Steven Hamilton

Tobias Frost writes:

> Am Samstag, den 25.10.2014, 17:35 +1000 schrieb Steven Hamilton:
>> On Thu, 23 Oct 2014 11:13:44 +0200 Tobias Frost  wrote:
>> > Hi Steven,
>> >
>> > what's the status of mrrescue? Do you have updates?
>> >
>> 
>> Still seeking a sponsor. Package is ready and source uploaded to Games
>> Team git. Keen to get this in before freeze.
>> 
>
> Hi Steve,
>
> no, you've got your sponsor already... 
> (Its the owner of the RFS bug, as recommended in
> http://mentors.debian.net/sponsor/rfs-howto  )
>
> Will take a look now
>
> -- 
> tobi

All items in your last review have been rectified and pushed to git.

-- 
Steven Hamilton
I don't look like two zombies


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#753110: RFS: mrrescue/1.02c-1 [ITP]

2014-10-25 Thread Tobias Frost
Am Samstag, den 25.10.2014, 17:35 +1000 schrieb Steven Hamilton:
> Package is ready and source uploaded to Games

There are no commits since July 27 -- did you push your changes?

--
tobi


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#753110: RFS: mrrescue/1.02c-1 [ITP]

2014-10-25 Thread Tobias Frost
Am Samstag, den 25.10.2014, 17:35 +1000 schrieb Steven Hamilton:
> On Thu, 23 Oct 2014 11:13:44 +0200 Tobias Frost  wrote:
> > Hi Steven,
> >
> > what's the status of mrrescue? Do you have updates?
> >
> 
> Still seeking a sponsor. Package is ready and source uploaded to Games
> Team git. Keen to get this in before freeze.
> 

Hi Steve,

no, you've got your sponsor already... 
(Its the owner of the RFS bug, as recommended in
http://mentors.debian.net/sponsor/rfs-howto  )

Will take a look now

-- 
tobi


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#753110: RFS: mrrescue/1.02c-1 [ITP]

2014-10-25 Thread Steven Hamilton

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On Thu, 23 Oct 2014 11:13:44 +0200 Tobias Frost  wrote:
> Hi Steven,
>
> what's the status of mrrescue? Do you have updates?
>

Still seeking a sponsor. Package is ready and source uploaded to Games
Team git. Keen to get this in before freeze.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iF4EAREIAAYFAlRLUqUACgkQunxZKpjzbPeifQEAgkoQDD27zKC3JNOn0HvkWl9P
dlFrg7NvQ9kmnSdKPboA/A4lzN5j+ZNQRmyQrQYFCkwR84qejoawm1eqpdIvNThf
=10BL
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#753110: RFS: mrrescue/1.02c-1 [ITP]

2014-10-23 Thread Tobias Frost
Hi Steven,

what's the status of mrrescue? Do you have updates?

-- 
Tobi


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#753110: RFS: mrrescue/1.02c-1 ITP

2014-07-17 Thread Jakub Wilk

* Elena ``of Valhalla'' , 2014-07-17, 13:39:

Did you write to the author?

I did. Should I include the email somewhere?


I believe it is better to have this email somewhere public (with 
author's permission).


When something similar happened to me there was a ticket on the 
upstream bugtracker and I posted the clarification email there, so that 
it could be available also to people looking for it outside debian, but 
in this case I guess that unless somebody else has better ideas the 
debian BTS will do.


Apart from BTS, there's a (non-publicly archived) mailing list that can 
be used for this purpose:

https://lists.debian.org/debian-email/

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#753110: RFS: mrrescue/1.02c-1 ITP

2014-07-17 Thread Elena ``of Valhalla''
On 2014-07-17 at 20:28:59 +1000, Steven Hamilton wrote:
> On Thu, 17 Jul 2014 10:03:59 +0200
> Elena ``of Valhalla''  wrote:
> > Did you write to the author?
> I did. Should I include the email somewhere?

I believe it is better to have this email somewhere public (with 
author's permission).

When something similar happened to me there was a ticket on the upstream 
bugtracker and I posted the clarification email there, so that 
it could be available also to people looking for it outside debian, 
but in this case I guess that unless somebody else has better 
ideas the debian BTS will do.

-- 
Elena ``of Valhalla''


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#753110: RFS: mrrescue/1.02c-1 ITP

2014-07-17 Thread Steven Hamilton
On Thu, 17 Jul 2014 10:03:59 +0200
Elena ``of Valhalla''  wrote:

> I can't sponsor either, I'm not even into NM
> 
> I'm wondering about the license of mrrescue/TSerial.lua: in the
> copyright file you claim it is copyright Matthias Richter and 
> under Zlib license, but the file only states that the author 
> is "Taehl (selfmadespi...@gmail.com)".
> 
> With an internet search I've found this source for TSerial 
> https://love2d.org/wiki/Tserial which however isn't any more useful 
> as far as licensing is concerned.
> 
> Did you write to the author?
> 

I did. Should I include the email somewhere?


signature.asc
Description: PGP signature


Bug#753110: RFS: mrrescue/1.02c-1 ITP

2014-07-17 Thread Elena ``of Valhalla''
I can't sponsor either, I'm not even into NM

I'm wondering about the license of mrrescue/TSerial.lua: in the
copyright file you claim it is copyright Matthias Richter and 
under Zlib license, but the file only states that the author 
is "Taehl (selfmadespi...@gmail.com)".

With an internet search I've found this source for TSerial 
https://love2d.org/wiki/Tserial which however isn't any more useful 
as far as licensing is concerned.

Did you write to the author?

-- 
Elena ``of Valhalla''


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#753110: RFS: mrrescue/1.02c-1 ITP

2014-07-07 Thread Steven Hamilton

Tobias Frost writes:

> Hi Steven,
>
> Please note, I can only review, but I cannot sponsor as my NM process is
> not yet finished... 
>
> On Sun, 2014-06-29 at 20:30 +1000, Steven Hamilton wrote:
>> Package: sponsorship-requests
>>   Severity: normal
>> 
>>   Dear mentors,
>> 
>>   I am looking for a sponsor for my package "mrrescue"
>> 
>>  * Package name: mrrescue
>>Version : 1.02c-1
>>Upstream Author : [fill in name and email of upstream]
>>  * URL : http://www.tangramgames.com
>
> It should be http://tangramgames.dk/games/mrrescue/, shouldn't it?
>
Yes, It's correct in the control file

>>  * License : zlib, MIT, BY-SA 3.0
>>Section : games
>> 
>>   It builds those binary packages:
>> 
>> mrrescue   - Mr Rescue is an arcade 2d action game
>> 
>>   To access further information about this package, please visit the 
>> following URL:
>> 
>>   http://mentors.debian.net/package/mrrescue
>> 
>> 
>>   Alternatively, one can download the package with dget using this command:
>> 
>> dget -x 
>> http://mentors.debian.net/debian/pool/main/m/mrrescue/mrrescue_1.02c-1.dsc
>> 
>>   More information about hello can be obtained from http://www.example.com.
>> 
>
> - d/copyright:  
>
> * Please adapt to the machine-readable format; You're already close, but
> at least some headers are missing:
> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
> * License texts are missing
> * Filenames are wrong: There is no mrresuce.love directory
>  in the source.
> * Also, please also use the same spelling for the licenses: ZLIB/zlib
> (Sugessted is to use the abbreviations as in http://spdx.org/licenses/)
> * s/BY-SA 3.0/CC-BY-SA-3.0

All fixed up. A license texts included.

> * d/docs
> README.txt ist not required to be installed, the information within are
> not needed on a Debian system
>
Removed

> * d/mrrescue
> Is there are resson to use /bin/bash as shebang and not use /bin/sh?
> (then you would also need to depend on bash; but its not necessary to
> have bash, right?)
Changed to /bin/sh
>
> * d/mrrsecue.1
> It's great that you provide a manpage. IMHO writing manpages is one of
> the most tedious work to be done during packaging ... You should also
> forward it upstream, (when its ready :)
> However, I think it need a little overhaul. Please read man-pages(7) and
> man(7)
> - Shouldn't it be section 6, games?
> - in the NAME Section, should'nt be MRRESCUE in lowercase?
> - Synopsis should be "mrrescue"
> - Section Desctiption:
> The sentence "This manual coveres ..." is uncessary."
> Maybe the text you use for d/control would be more appropiate for an
> description?
> - mrrescue doesn't take options, right?

All fixed up. Moved to section 6.

>
> * d/rules:  I think you don't need to rm build_dir

I think I do. The build process creates a mrrescue.love file which is
basically a zipped file of all the source (this is how love
works). Without the rm build_dir dh_clean won't clean up properly.

> * there are two pendantic lintian messages. What to do with this
> strongly depends on the sponsor, however I would override it as an sign
> that I've checked them (and maybe nag upstream to add an changelog and
> signature to their tarballs)

Override added for no upstream changelog.

> So I would say the package is "almost ready"... Thanks for your
> contribution :)

And thanks for the review. Updated package it now uploaded to mentors.

-- 
Steven Hamilton
I don't look like two zombies


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#753110: RFS: mrrescue/1.02c-1 ITP

2014-06-29 Thread Tobias Frost
Hi Steven,

Please note, I can only review, but I cannot sponsor as my NM process is
not yet finished... 

On Sun, 2014-06-29 at 20:30 +1000, Steven Hamilton wrote:
> Package: sponsorship-requests
>   Severity: normal
> 
>   Dear mentors,
> 
>   I am looking for a sponsor for my package "mrrescue"
> 
>  * Package name: mrrescue
>Version : 1.02c-1
>Upstream Author : [fill in name and email of upstream]
>  * URL : http://www.tangramgames.com

It should be http://tangramgames.dk/games/mrrescue/, shouldn't it?

>  * License : zlib, MIT, BY-SA 3.0
>Section : games
> 
>   It builds those binary packages:
> 
> mrrescue   - Mr Rescue is an arcade 2d action game
> 
>   To access further information about this package, please visit the 
> following URL:
> 
>   http://mentors.debian.net/package/mrrescue
> 
> 
>   Alternatively, one can download the package with dget using this command:
> 
> dget -x 
> http://mentors.debian.net/debian/pool/main/m/mrrescue/mrrescue_1.02c-1.dsc
> 
>   More information about hello can be obtained from http://www.example.com.
> 

- d/copyright:  

* Please adapt to the machine-readable format; You're already close, but
at least some headers are missing:
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
* License texts are missing
* Filenames are wrong: There is no mrresuce.love directory
 in the source.
* Also, please also use the same spelling for the licenses: ZLIB/zlib
(Sugessted is to use the abbreviations as in http://spdx.org/licenses/)
* s/BY-SA 3.0/CC-BY-SA-3.0

* d/docs
README.txt ist not required to be installed, the information within are
not needed on a Debian system

* d/mrrescue
Is there are resson to use /bin/bash as shebang and not use /bin/sh?
(then you would also need to depend on bash; but its not necessary to
have bash, right?)

* d/mrrsecue.1
It's great that you provide a manpage. IMHO writing manpages is one of
the most tedious work to be done during packaging ... You should also
forward it upstream, (when its ready :)
However, I think it need a little overhaul. Please read man-pages(7) and
man(7)
- Shouldn't it be section 6, games?
- in the NAME Section, should'nt be MRRESCUE in lowercase?
- Synopsis should be "mrrescue"
- Section Desctiption:
The sentence "This manual coveres ..." is uncessary."
Maybe the text you use for d/control would be more appropiate for an
description?
- mrrescue doesn't take options, right?

* d/rules:  I think you don't need to rm build_dir

* there are two pendantic lintian messages. What to do with this
strongly depends on the sponsor, however I would override it as an sign
that I've checked them (and maybe nag upstream to add an changelog and
signature to their tarballs)

So I would say the package is "almost ready"... Thanks for your
contribution :)

-- 
tobi


signature.asc
Description: This is a digitally signed message part


Bug#753110: RFS: mrrescue/1.02c-1 ITP

2014-06-29 Thread Steven Hamilton

Package: sponsorship-requests
  Severity: normal

  Dear mentors,

  I am looking for a sponsor for my package "mrrescue"

 * Package name: mrrescue
   Version : 1.02c-1
   Upstream Author : [fill in name and email of upstream]
 * URL : http://www.tangramgames.com
 * License : zlib, MIT, BY-SA 3.0
   Section : games

  It builds those binary packages:

mrrescue   - Mr Rescue is an arcade 2d action game

  To access further information about this package, please visit the following 
URL:

  http://mentors.debian.net/package/mrrescue


  Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/m/mrrescue/mrrescue_1.02c-1.dsc

  More information about hello can be obtained from http://www.example.com.

  Changes since the last upload:

* Initial release (Closes: #707691)


  Regards,
   Steven Hamilton

-- 
Steven Hamilton
I don't look like two zombies


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org