Bug#753173: wrongly detects language

2015-04-22 Thread Stefano Zacchiroli
On Sun, Jun 29, 2014 at 08:22:55PM +0200, Peter Palfrader wrote:
 torbrowser-launcher pulled down the german language torbrowser, even
 though nothing in those locale settings suggest I want german language
 texts.

Same for me, with the following locale:

  zack@timira:~$ locale
  LANG=it_IT.utf8
  LANGUAGE=
  LC_CTYPE=it_IT.utf8
  LC_NUMERIC=it_IT.utf8
  LC_TIME=it_IT.utf8
  LC_COLLATE=it_IT.utf8
  LC_MONETARY=it_IT.utf8
  LC_MESSAGES=en_US.UTF-8
  LC_PAPER=it_IT.utf8
  LC_NAME=it_IT.utf8
  LC_ADDRESS=it_IT.utf8
  LC_TELEPHONE=it_IT.utf8
  LC_MEASUREMENT=it_IT.utf8
  LC_IDENTIFICATION=it_IT.utf8
  LC_ALL=

I believe that in my case, which is slightly different from weasel's
one, torbrowser-launcher should recognize the LC_MESSAGES override to
LANG.

With many thanks for maintaining torbrowser-launcher in Debian!

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  z...@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader  . . @zack on identi.ca . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#753173: [Pkg-anonymity-tools] Bug#753173: wrongly detects language

2015-04-22 Thread Stefano Zacchiroli
On Wed, Apr 22, 2015 at 03:54:19PM +0200, Holger Levsen wrote:
 On Mittwoch, 22. April 2015, Stefano Zacchiroli wrote:
  Same for me, with the following locale:
zack@timira:~$ locale
LANG=it_IT.utf8
LANGUAGE=
LC_MESSAGES=en_US.UTF-8
 
 so you got torbrowser in which language?

Right, sorry for the terseness.

I get torbrowser in Italian, whereas I want it in English. Running
LANG= torbrowser-launcher get me the English version, but what's
annoying is that if I forget the LANG= override once, it will attempt to
download torbrowser again from scratch (in Italian).

   Holger, assuming this is an upstream bug

It most definitely is. I think this line:

 
http://sources.debian.net/src/torbrowser-launcher/0.1.9-1/torbrowser_launcher/common.py/#L75

which currently reads:

  default_locale = locale.getdefaultlocale()[0]

should instead be:

  default_locale = locale.getlocale(locale.LC_MESSAGES)[0]

but I haven't tested it.

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  z...@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader  . . @zack on identi.ca . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »


signature.asc
Description: Digital signature


Bug#753173: [Pkg-anonymity-tools] Bug#753173: wrongly detects language

2015-04-22 Thread Holger Levsen
Hi zack,

On Mittwoch, 22. April 2015, Stefano Zacchiroli wrote:
 Same for me, with the following locale:
   zack@timira:~$ locale
   LANG=it_IT.utf8
   LANGUAGE=
   LC_MESSAGES=en_US.UTF-8

so you got torbrowser in which language?


cheers,
Holger, assuming this is an upstream bug


signature.asc
Description: This is a digitally signed message part.


Bug#753173: [Pkg-anonymity-tools] Bug#753173: Bug#753173: wrongly detects language

2015-04-22 Thread Holger Levsen
control: tags -1 + upstream
# thanks, zack



signature.asc
Description: This is a digitally signed message part.


Bug#753173: wrongly detects language

2014-06-29 Thread Peter Palfrader
Package: torbrowser-launcher
Version: 0.1.0-1.1
Severity: normal

This is my locale:
 weasel@valiant:~$ locale
 LANG=
 LANGUAGE=
 LC_CTYPE=de_AT.UTF-8
 LC_NUMERIC=POSIX
 LC_TIME=POSIX
 LC_COLLATE=POSIX
 LC_MONETARY=POSIX
 LC_MESSAGES=POSIX
 LC_PAPER=POSIX
 LC_NAME=POSIX
 LC_ADDRESS=POSIX
 LC_TELEPHONE=POSIX
 LC_MEASUREMENT=POSIX
 LC_IDENTIFICATION=POSIX
 LC_ALL=

torbrowser-launcher pulled down the german language torbrowser, even
though nothing in those locale settings suggest I want german language
texts.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org