Bug#753939: Please remove quotacheck and quotaon service files
On Mon, Jul 07, 2014 at 03:00:47AM +0200, Michael Biebl wrote: Wouldn't be a better idea to simply get the additional functionality the Debian quota scripts provide moved into the quotaon and quotacheck binaries upstream? I don't think so, for a couple reasons: - quota functionality should be in the quota package IMO - quota init scripts will be part of the quota package for other init systems, so we would get an awful mix if we'd move this to systemd - some of the additional functionality might not make much sense for a brand new system, not sure if systemd upstream would be interested in that Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#753939: Please remove quotacheck and quotaon service files
Am 07.07.2014 11:20, schrieb Michael Meskes: On Mon, Jul 07, 2014 at 03:00:47AM +0200, Michael Biebl wrote: Wouldn't be a better idea to simply get the additional functionality the Debian quota scripts provide moved into the quotaon and quotacheck binaries upstream? I don't think so, for a couple reasons: - quota functionality should be in the quota package IMO I was talking about the quotaon and quotacheck *binaries*, which are part of the quota package. - quota init scripts will be part of the quota package for other init systems, so we would get an awful mix if we'd move this to systemd moving that functionality out of the init scripts and into the binaries but still keeping the sysv init scripts for non-systemd systems wouldn't create a mess. Actually, it would make the sysv init scripts much simpler - some of the additional functionality might not make much sense for a brand new system, not sure if systemd upstream would be interested in that I didn't mean systemd upstream here, but quota upstream. If it is useful functionality, I would at least try to get it upstream. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#753939: Please remove quotacheck and quotaon service files
On Mon, Jul 07, 2014 at 01:04:49PM +0200, Michael Biebl wrote: - quota functionality should be in the quota package IMO I was talking about the quotaon and quotacheck *binaries*, which are part of the quota package. Ah, I thought you were talking about the two binaries as provided by the systemd package. - some of the additional functionality might not make much sense for a brand new system, not sure if systemd upstream would be interested in that I didn't mean systemd upstream here, but quota upstream. If it is useful functionality, I would at least try to get it upstream. It is, but it simply does not belong into these binaries. For instance out init script checks which FS it should run quotacheck on for a normal check but also for creating quota files. This could be another binary, but certainly does not belong into either one of these binaries. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#753939: Please remove quotacheck and quotaon service files
Am 06.07.2014 15:46, schrieb Michael Meskes: Package: systemd Version: 204-14 Severity: normal TTBOMK the quota package now provides all the logic in these service files and then some, so please remove these from systemd and let quota handle the quota stuff. How does the quota package ensure it is run when an actual device shows up and is mounted? Afaics it is only run once during boot. Also, does quota support the quotacheck.mode=force|... boot option ie. is compatible with quotacheck from systemd? Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#753939: Please remove quotacheck and quotaon service files
How does the quota package ensure it is run when an actual device shows up and is mounted? Afaics it is only run once during boot. Argh, you're right, that it doesn't do. But it should. How does systemd make sure its quotaon service is run in that case? Also, does quota support the quotacheck.mode=force|... boot option ie. Yes, it does. is compatible with quotacheck from systemd? That bit I don't understand, systemd-quotacheck essantially only calls quotacheck fromthe quota package, doesn't it? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#753939: Please remove quotacheck and quotaon service files
Am 06.07.2014 16:39, schrieb Michael Meskes: How does the quota package ensure it is run when an actual device shows up and is mounted? Afaics it is only run once during boot. Argh, you're right, that it doesn't do. But it should. How does systemd make sure its quotaon service is run in that case? Looking at src/core/mount.c, it hooks up the call to quoatecheck.service and quotaon.service up in the individual .mount unit [1]. Michael [1] http://anonscm.debian.org/gitweb/?p=pkg-systemd/systemd.git;a=blob;f=src/core/mount.c;h=10073b50be0b720cca06d9339a13b14b897bd75e;hb=HEAD#l411 -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#753939: Please remove quotacheck and quotaon service files
Am 06.07.2014 15:46, schrieb Michael Meskes: Package: systemd Version: 204-14 Severity: normal TTBOMK the quota package now provides all the logic in these service files and then some, so please remove these from systemd and let quota handle the quota stuff. Wouldn't be a better idea to simply get the additional functionality the Debian quota scripts provide moved into the quotaon and quotacheck binaries upstream? -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
