Bug#754231: volumeicon-alsa: should not hardcode xterm but x-terminal-emulator

[Luca Capello]

tags 754231 + patch
thanks

Hi there!

On Tue, 08 Jul 2014 23:29:55 +0200, Luca Capello wrote:
> I will send a Git patch against the collab-maint repository as soon as
> this bug gets its number ;-)

Attached.

Thx, bye,
Gismo / Luca
From 0a127658a3f2c2c6bb1cf1bdd3635d79bcfc92c7 Mon Sep 17 00:00:00 2001
From: Luca Capello 
Date: Tue, 8 Jul 2014 23:43:41 +0200
Subject: [PATCH] debian/patches/002_replace-hardcoded-xterm.diff: new
 (#754231)

---
 debian/patches/002_replace-hardcoded-xterm.diff | 16 
 debian/patches/series   |  1 +
 2 files changed, 17 insertions(+)
 create mode 100644 debian/patches/002_replace-hardcoded-xterm.diff

diff --git a/debian/patches/002_replace-hardcoded-xterm.diff b/debian/patches/002_replace-hardcoded-xterm.diff
new file mode 100644
index 000..7105c98
--- /dev/null
+++ b/debian/patches/002_replace-hardcoded-xterm.diff
@@ -0,0 +1,16 @@
+Description: Replace hardcoded xterm with x-terminal-emulator
+Bug-Debian: 754231
+Author: Luca Capello 
+Last-Update: 2014-07-08
+
+--- a/src/config.c
 b/src/config.c
+@@ -59,7 +59,7 @@
+ static void config_load_default()
+ {
+ 	if(!m_helper_program)
+-		config_set_helper("xterm -e 'alsamixer'");
++		config_set_helper("x-terminal-emulator -e 'alsamixer'");
+ 	if(!m_channel)
+ 		config_set_channel(NULL);
+ 	if(!m_card)
diff --git a/debian/patches/series b/debian/patches/series
index cc58d98..25164d0 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 001_remove-individual-glib-headers.diff
+002_replace-hardcoded-xterm.diff
-- 
2.0.0



signature.asc
Description: Digital signature

Bug#754231: volumeicon-alsa: should not hardcode xterm but x-terminal-emulator

[Luca Capello]

Package: volumeicon-alsa
Version: 0.4.6-1
Severity: important
User: cont...@itopie.ch
Usertags: itopie.ch-installation
User: i...@codha.ch
Usertags: codha.ch-installation

Hi there,

src/config.c hardocodes xterm without a Depends: on that (which IMHO
would be plain wrong), x-terminal-emulator should be used instead.

I will send a Git patch against the collab-maint repository as soon as
this bug gets its number ;-)

Thx, bye,
Gismo / Luca

-- System Information:
Debian Release: 7.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages volumeicon-alsa depends on:
ii  alsa-base   1.0.25+3~deb7u1
ii  libasound2  1.0.25-4
ii  libc6   2.13-38+deb7u1
ii  libgdk-pixbuf2.0-0  2.26.1-1
ii  libglib2.0-02.33.12+really2.32.4-5
ii  libgtk2.0-0 2.24.10-2
ii  libnotify4  0.7.5-1
ii  libx11-62:1.5.0-1+deb7u1

volumeicon-alsa recommends no packages.

Versions of packages volumeicon-alsa suggests:
pn  alsamixergui | aumix-gtk | kmix | gnome-alsamixer  
pn  notify-osd | xfce4-nofityd | notification-daemon   

-- no debconf information


signature.asc
Description: Digital signature