Bug#757120: #757120: The package doesn't build the debian file
Control: tag -1 - patch Hi Gianfranco, On Wed, Aug 20, 2014 at 1:21 AM, Gianfranco Costamagna wrote: > the problem should be if I understand correctly the code, when "$instdir" > contains some special chars such as "-", in that case the build fails. Ah, you're right, the script doesn't handle that very nicely: $ pwd /tmp/b po*'&\h $ make-googleearth-package Google Earth for GNU/Linux 6.0.3.2197 Supported Google Earth version: 6.0.3.2197 tar: Pattern matching characters used in file names tar: Use --wildcards to enable pattern matching, or --no-wildcards to suppress this warning tar: po*'&\\h/googleearth-tmp: Not found in archive tar: Exiting with failure status due to previous errors tar: /tmp/b po*'&\\h/googleearth-tmp/googleearth-linux-x86.tar: Cannot open: No such file or directory tar: Error is not recoverable: exiting now tar: /tmp/b po*'&\\h/googleearth-tmp/googleearth-data.tar: Cannot open: No such file or directory tar: Error is not recoverable: exiting now cp: cannot stat ‘/tmp/b po*'&\\h/googleearth-tmp/googleearth.xpm’: No such file or directory cp: cannot stat ‘/tmp/b po*'&\\h/googleearth-tmp/README*’: No such file or directory [...] (the resulting .deb package is broken) Your/Ubuntu's proposed patch doesn't fix this, however, so untagging patch from the bug report. > looking at the code instdir starts from the current directory, so maybe it > really depend from where are you calling the make command... > local instdir="`pwd`/googleearth-deb" > local tmpdir="`pwd`/googleearth-tmp" Urgh, that really should be using "mktemp -d" instead of predictable directory names. Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#757120: #757120: The package doesn't build the debian file
Hi Vincent > Il Martedì 19 Agosto 2014 10:20, Vincent Cheng ha scritto: > > On Tue, 5 Aug 2014 14:45:13 +0100 Gianfranco Costamagna > wrote: >> Package: googleearth-package >> Version: 1.1.0 >> Severity: serious >> Justification: makes the program almost useless >> >> tags:patch >> >> >> the fix is fairly trivial, taken from the ubuntu bug report >> https://bugs.launchpad.net/ubuntu/+source/googleearth-package/+bug/1335021 > > Assuming that the problem is not being able to produce a binary > package with make-googleearth-package, I can't reproduce this at all: > > $ make-googleearth-package > --2014-08-19 01:15:09-- > http://dl.google.com/earth/client/current/GoogleEarthLinux.bin > [...] > dpkg-deb: building package `googleearth' in > `./googleearth_6.0.3.2197+1.1.0-1_amd64.deb'. > - > Success! > You can now install the package with e.g: > > sudo dpkg -i googleearth_6.0.3.2197+1.1.0-1_amd64.deb > - > > Should this still be a RC bug? > the problem should be if I understand correctly the code, when "$instdir" contains some special chars such as "-", in that case the build fails. looking at the code instdir starts from the current directory, so maybe it really depend from where are you calling the make command... local instdir="`pwd`/googleearth-deb" local tmpdir="`pwd`/googleearth-tmp" cheers, Gianfranco > Regards, > Vincent > -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#757120: #757120: The package doesn't build the debian file
On Tue, 5 Aug 2014 14:45:13 +0100 Gianfranco Costamagna wrote: > Package: googleearth-package > Version: 1.1.0 > Severity: serious > Justification: makes the program almost useless > > tags:patch > > > the fix is fairly trivial, taken from the ubuntu bug report > https://bugs.launchpad.net/ubuntu/+source/googleearth-package/+bug/1335021 Assuming that the problem is not being able to produce a binary package with make-googleearth-package, I can't reproduce this at all: $ make-googleearth-package --2014-08-19 01:15:09-- http://dl.google.com/earth/client/current/GoogleEarthLinux.bin [...] dpkg-deb: building package `googleearth' in `./googleearth_6.0.3.2197+1.1.0-1_amd64.deb'. - Success! You can now install the package with e.g: sudo dpkg -i googleearth_6.0.3.2197+1.1.0-1_amd64.deb - Should this still be a RC bug? Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
