Bug#757400: eggdrop: FTBFS with clang instead of gcc

[Cédric Barboiron]

tag -1 + pending
stop

Hello Arthur,

Thanks for the bug report and your proposed patch.

It builds ok here with both gcc and clang. I'll fix the open_listen
header (src/proto.h) as well and check all inline functions before
updating the package to ensure this bug is properly fixed. Should be
done this week.

Regards


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#757400: eggdrop: FTBFS with clang instead of gcc

[Arthur Marble]

Package: eggdrop
Severity: minor
Tags: patch
User: pkg-llvm-t...@lists.alioth.debian.org
Usertags: clang-ftbfs

Hello,

Using the rebuild infrastructure, your package fails to build with clang
(instead of gcc).

Detected this kind of error:
http://clang.debian.net/status.php?version=3.5.0rc1key=UNDEF_REF

Full build log is available here:
http://clang.debian.net/logs/2014-08-05/eggdrop_1.6.21-3_unstable_clang.log

Thanks,
Arthur

-- System Information:
Debian Release: jessie/sid (unstable)
Architecture: amd64 (x86_64)
Kernel: Linux 3.14-2-amd64
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8
Shell: /bin/sh linked to /bin/dash
Compiler: Debian clang version 3.5.0-+rc1-2 (tags/RELEASE_35/rc1) (based on 
LLVM 3.5.0)
diff -Naur eggdrop.orig/eggdrop-1.6.21/debian/changelog eggdrop/eggdrop-1.6.21/debian/changelog
--- eggdrop.orig/eggdrop-1.6.21/debian/changelog	2014-08-07 14:09:01.500439546 -0500
+++ eggdrop/eggdrop-1.6.21/debian/changelog	2014-08-07 14:26:28.37245 -0500
@@ -1,3 +1,14 @@
+eggdrop (1.6.21-4) unstable; urgency=low
+
+  * Fix FTBFS with clang
+- Fixed undefined reference in
+  src/match.c
+  src/tclhash.c
+  src/tclhash.h
+  src/net.c
+  
+ -- Arthur Marble art...@info9.net  Thu, 07 Aug 2014 14:26:16 -0500
+
 eggdrop (1.6.21-3) unstable; urgency=low
 
   * debian/rules: fix dh-autoreconf (Closes: #750618)
diff -Naur eggdrop.orig/eggdrop-1.6.21/debian/patches/clang-ftbfs.diff eggdrop/eggdrop-1.6.21/debian/patches/clang-ftbfs.diff 
--- eggdrop.orig/eggdrop-1.6.21/debian/patches/clang-ftbfs.diff	1969-12-31 18:00:00.0 -0600
+++ eggdrop/eggdrop-1.6.21/debian/patches/clang-ftbfs.diff	2014-08-07 14:23:03.920454216 -0500
@@ -0,0 +1,44 @@
+--- a/src/match.c
 b/src/match.c
+@@ -367,7 +367,7 @@ int cidr_match(char *m, char *n, int cou
+ /* Inline for cron_match (obviously).
+  * Matches a single field of a crontab expression.
+  */
+-inline int cron_matchfld(char *mask, int match)
++static inline int cron_matchfld(char *mask, int match)
+ {
+   int skip = 0, f, t;
+   char *p, *q;
+--- a/src/tclhash.c
 b/src/tclhash.c
+@@ -109,7 +109,7 @@ static inline void tcl_bind_list_delete(
+   nfree(tl);
+ }
+ 
+-inline void garbage_collect_tclhash(void)
++void garbage_collect_tclhash(void)
+ {
+   tcl_bind_list_t *tl, *tl_next, *tl_prev;
+   tcl_bind_mask_t *tm, *tm_next, *tm_prev;
+--- a/src/tclhash.h
 b/src/tclhash.h
+@@ -75,7 +75,7 @@ typedef struct tcl_bind_list_b {
+ 
+ #ifndef MAKING_MODS
+ 
+-inline void garbage_collect_tclhash(void);
++void garbage_collect_tclhash(void);
+ 
+ void init_bind(void);
+ void kill_bind(void);
+--- a/src/net.c
 b/src/net.c
+@@ -564,7 +564,7 @@ int open_address_listen(IP addr, int *po
+ /* Returns a socket number for a listening socket that will accept any
+  * connection -- port # is returned in port
+  */
+-inline int open_listen(int *port)
++int open_listen(int *port)
+ {
+   return open_address_listen(myip[0] ? getmyip() : INADDR_ANY, port);
+ }
diff -Naur eggdrop.orig/eggdrop-1.6.21/debian/patches/series eggdrop/eggdrop-1.6.21/debian/patches/series 
--- eggdrop.orig/eggdrop-1.6.21/debian/patches/series	2014-08-07 14:09:01.500439546 -0500
+++ eggdrop/eggdrop-1.6.21/debian/patches/series	2014-08-07 14:09:45.684440316 -0500
@@ -3,3 +3,4 @@
 01use_ldflags.patch
 02language_dir.patch
 fix_kfreebsd_build
+clang-ftbfs.diff