Bug#757832: liblqr: FTBFS with clang instead of gcc

[Bernd Zeimetz]

hi,

> Detected this kind of error:
> http://clang.debian.net/status.php?version=3.5.0rc1&key=UNDEF_REF
> 
> Full build log is available here:
> http://clang.debian.net/logs/2014-06-16/liblqr_0.4.1-2_unstable_clang.log

could you tell me how this error is supposed to be fixed? i had a look at
lqr/lqr_energy.c and lqr/lqr_energy.h and tried to figure out why

lqr_energy.c:(.text+0x2e6): undefined reference to `lqr_pixel_get_norm'

happens.
its only used in lqr/lqr_energy.c, defined in that file and in the according
header file Nothing on the first look that seems to be wrong.
So either I'm blind, or I fail to understand why clang is whining :) Please
enlighten me?

Thanks,

Bernd


-- 
 Bernd ZeimetzDebian GNU/Linux Developer
 http://bzed.dehttp://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485  DD95 EB36 171A 6FF9 435F


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#757832: liblqr: FTBFS with clang instead of gcc

[Arthur Marble]

Package: liblqr
Severity: minor
Tags: patch
User: pkg-llvm-t...@lists.alioth.debian.org
Usertags: clang-ftbfs

Hello,

Using the rebuild infrastructure, your package fails to build with clang
(instead of gcc).

Detected this kind of error:
http://clang.debian.net/status.php?version=3.5.0rc1&key=UNDEF_REF

Full build log is available here:
http://clang.debian.net/logs/2014-06-16/liblqr_0.4.1-2_unstable_clang.log

Thanks,
Arthur

-- System Information:
Debian Release: jessie/sid (unstable)
Architecture: amd64 (x86_64)
Kernel: Linux 3.14-2-amd64
Locale: LANG=en_US.UTF-8, LC_CTYPE="en_US.UTF-8"
Shell: /bin/sh linked to /bin/dash
Compiler: Debian clang version 3.5.0-+rc1-2 (tags/RELEASE_35/rc1) (based on 
LLVM 3.5.0)
diff -Naur liblqr.orig/liblqr-0.4.1/debian/changelog liblqr/liblqr-0.4.1/debian/changelog
--- liblqr.orig/liblqr-0.4.1/debian/changelog	2014-08-11 12:31:47.596179540 -0500
+++ liblqr/liblqr-0.4.1/debian/changelog	2014-08-11 12:42:15.612190476 -0500
@@ -1,3 +1,10 @@
+liblqr (0.4.1-3) unstable; urgency=low
+
+  * Fix FTBFS with clang
+- Fixed undefined error
+
+ -- Arthur Marble   Mon, 11 Aug 2014 12:42:15 -0500
+
 liblqr (0.4.1-2) unstable; urgency=low
 
   * [72c1e4e5] Ack NMU.
diff -Naur liblqr.orig/liblqr-0.4.1/patches/clang-ftbfs.diff liblqr/liblqr-0.4.1/patches/clang-ftbfs.diff 
--- liblqr.orig/liblqr-0.4.1/patches/clang-ftbfs.diff	1969-12-31 18:00:00.0 -0600
+++ liblqr/liblqr-0.4.1/patches/clang-ftbfs.diff	2014-08-11 12:40:02.660188161 -0500
@@ -0,0 +1,56 @@
+--- a/lqr/lqr_energy.c
 b/lqr/lqr_energy.c
+@@ -44,7 +44,7 @@
+ 
+ /* read normalised pixel value from
+  * rgb buffer at the given index */
+-inline gdouble
++gdouble
+ lqr_pixel_get_norm(void *rgb, gint rgb_ind, LqrColDepth col_depth)
+ {
+ switch (col_depth) {
+@@ -66,7 +66,7 @@ lqr_pixel_get_norm(void *rgb, gint rgb_i
+ 
+ /* write pixel from normalised value
+  * in rgb buffer at the given index */
+-inline void
++void
+ lqr_pixel_set_norm(gdouble val, void *rgb, gint rgb_ind, LqrColDepth col_depth)
+ {
+ switch (col_depth) {
+@@ -90,7 +90,7 @@ lqr_pixel_set_norm(gdouble val, void *rg
+ }
+ }
+ 
+-inline gdouble
++gdouble
+ lqr_pixel_get_rgbcol(void *rgb, gint rgb_ind, LqrColDepth col_depth, LqrImageType image_type, gint channel)
+ {
+ gdouble black_fact = 0;
+@@ -115,7 +115,7 @@ lqr_pixel_get_rgbcol(void *rgb, gint rgb
+ }
+ }
+ 
+-inline gdouble
++gdouble
+ lqr_carver_read_brightness_grey(LqrCarver *r, gint x, gint y)
+ {
+ gint now = r->raw[y][x];
+@@ -123,7 +123,7 @@ lqr_carver_read_brightness_grey(LqrCarve
+ return lqr_pixel_get_norm(r->rgb, rgb_ind, r->col_depth);
+ }
+ 
+-inline gdouble
++gdouble
+ lqr_carver_read_brightness_std(LqrCarver *r, gint x, gint y)
+ {
+ gdouble red, green, blue;
+@@ -205,7 +205,7 @@ lqr_carver_read_brightness(LqrCarver *r,
+ return bright * alpha_fact;
+ }
+ 
+-inline gdouble
++gdouble
+ lqr_carver_read_luma_std(LqrCarver *r, gint x, gint y)
+ {
+ gdouble red, green, blue;
diff -Naur liblqr.orig/liblqr-0.4.1/patches/series liblqr/liblqr-0.4.1/patches/series
--- liblqr.orig/liblqr-0.4.1/patches/series	1969-12-31 18:00:00.0 -0600
+++ liblqr/liblqr-0.4.1/patches/series	2014-08-11 12:32:16.636180045 -0500
@@ -0,0 +1 @@
+clang-ftbfs.diff