Bug#758056: RFS: binwalk/2.0.1-1
Hi again Andrey,
Il Lunedì 25 Agosto 2014 6:47, Andrey Rahmatullin w...@debian.org ha
scritto:
On Mon, Aug 25, 2014 at 12:26:47AM +0100, Gianfranco Costamagna wrote:
At least some of the d can be made r, such as mtd-utils.
I don't fully agree (I don't honestly know the tradeoff between a
bad user experience and the amount of the packages that one might be forced
to
install), but fine, I changed that
I think the main thing to consider is percentage of users that will need
things that require these packages. Note that Recommends are installed by
default anyway (in the default configuration), and now I think that some
packages are maybe even better moved to Suggests (but I'm not 100% sure).
There is also an interesting practice (cf. devscripts) to document what
optional features require optionadditional recommends/suggests.
There are several issues with the manpage, 3 of them are reported by
lintian and fourth one is the SEE ALSO section which is
not true.
they are created with
help2man binwalk --version-string=v2.0.1 binwalk.1
For omitting info section there is a -N argument. Typos are better
corrected in the source, and manpage-has-useless-whatis-entry suggests
passing -n with a proper whatis text to help2man.
fixed, thanks!
should I file a bug there?
Sorry but I don't feel good in fixing automatically created files... do
you have any advice for this?
@@ -17,7 +17,6 @@ Architecture: any
Depends: ${python:Depends}, ${shlibs:Depends},
${misc:Depends},
python-matplotlib,
python-pyqtgraph,
- mtd-utils,
ncompress,
bzip2,
arj,
At least arj looks optional too, maybe others too.
I moved all the decompression tools to Recommends leaving to Depends only the
programs you really need to have in order to run the program, as Vincent said
tar and gzip are already there, and they should fullfill most of the user cases.
thanks again, looking forward to fix the hardened build and I'll reupload!
cheers,
G.
--
WBR, wRAR
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758056: RFS: binwalk/2.0.1-1
Can you please not use abbreviations such as d/c and std-version in
d/c?
Don't use ${python:Provides}.
At least some of the d can be made r, such as mtd-utils.
Why Priority: extra?
There are several issues with the manpage, 3 of them are reported by
lintian and fourth one is the SEE ALSO section which is not true.
--
WBR, wRAR
signature.asc
Description: Digital signature
Bug#758056: RFS: binwalk/2.0.1-1
Hi Andrey,
thanks for the nice review!
Il Domenica 24 Agosto 2014 20:11, Andrey Rahmatullin w...@debian.org ha
scritto:
Can you please not use abbreviations such as d/c and
std-version in
d/c?
corrected
Don't use ${python:Provides}.
removed.
At least some of the d can be made r, such as mtd-utils.
I don't fully agree (I don't honestly know the tradeoff between a bad user
experience and the amount of the packages that one might be forced to install),
but fine, I changed that
Why Priority: extra?
Changed to optional, it was a leftover from the previous upload, I didn't
change that
There are several issues with the manpage, 3 of them are reported by
lintian and fourth one is the SEE ALSO section which is not true.
they are created with
help2man binwalk --version-string=v2.0.1 binwalk.1
should I file a bug there?
Sorry but I don't feel good in fixing automatically created files... do you
have any advice for this?
Still many thanks for the review, I'm attaching the patch I just added on
mentors for your convenience
From 11ae61f20272b2dd27d4fcf2b04a047243a851a9 Mon Sep 17 00:00:00 2001
From: Gianfranco Costamagna costamagnagianfra...@yahoo.it
Date: Mon, 25 Aug 2014 01:21:39 +0200
Subject: [PATCH] Update, per wRAR feedback
---
debian/changelog | 18 +++---
debian/control | 5 ++---
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index b1ec7b2..9a2ab0a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,14 +2,18 @@ binwalk (2.0.1-1) unstable; urgency=medium
* Imported Upstream version 2.0.1 (Closes: #727553, Closes: #754317)
- Updated docs location
- * d/r: Removing binary files when cleaning
- * d/c: X-Python-Version: = 2.7
- * d/p/destdir.patch: Override install path
- * Add some b-d and d
- * Bump std-version to 3.9.5, no changes required
+ * Tweak rules file to remove binary files when cleaning.
+ * debian/control: add X-Python-Version: = 2.7 and
+ some new dependencies such as python-pyqtgraph.
+ * debian/control: add python-opengl python-qt4 and python-qt4-gl
+ as depdencies, to force the right pyqtgraph render engine.
+ * patch destdir.patch, add DESTDIR to install path.
+ * Add dh-autoreconf as build-dependency, and some missing runtime
dependencies,
+ needed to correctly extract the various kind of supported files.
+ * Bump standard version to 3.9.5, no changes required.
* Add myself to uploaders.
- * d/{control,watch,copyright} New website (Closes: #734708)
- * Canonical VCS urls.
+ * debian/{control,watch,copyright} New website (Closes: #734708)
+ * Update VCS fields to canonical.
* Update man page.
* Update copyright file.
diff --git a/debian/control b/debian/control
index 49d3753..9e17cc9 100644
--- a/debian/control
+++ b/debian/control
@@ -1,6 +1,6 @@
Source: binwalk
Section: devel
-Priority: extra
+Priority: optional
Maintainer: Leo Costela cost...@debian.org
Uploaders: Gianfranco Costamagna costamagnagianfra...@yahoo.it
Build-Depends: debhelper (= 9),
@@ -17,7 +17,6 @@ Architecture: any
Depends: ${python:Depends}, ${shlibs:Depends}, ${misc:Depends},
python-matplotlib,
python-pyqtgraph,
- mtd-utils,
ncompress,
bzip2,
arj,
@@ -29,7 +28,7 @@ Depends: ${python:Depends}, ${shlibs:Depends},
${misc:Depends},
python-opengl,
python-qt4,
python-qt4-gl
-Provides: ${python:Provides}
+Recommends: mtd-utils
Description: tool for searching binary images for embedded files and
executable code
Binwalk is a tool for searching a given binary image for embedded files
and executable code. Specifically, it is designed for identifying files
--
1.9.1
Have many thanks,
Gianfranco
--
WBR, wRAR
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758056: RFS: binwalk/2.0.1-1
On Mon, Aug 25, 2014 at 12:26:47AM +0100, Gianfranco Costamagna wrote:
At least some of the d can be made r, such as mtd-utils.
I don't fully agree (I don't honestly know the tradeoff between a bad user
experience and the amount of the packages that one might be forced to
install), but fine, I changed that
I think the main thing to consider is percentage of users that will need
things that require these packages. Note that Recommends are installed by
default anyway (in the default configuration), and now I think that some
packages are maybe even better moved to Suggests (but I'm not 100% sure).
There is also an interesting practice (cf. devscripts) to document what
optional features require optionadditional recommends/suggests.
There are several issues with the manpage, 3 of them are reported by
lintian and fourth one is the SEE ALSO section which is not true.
they are created with
help2man binwalk --version-string=v2.0.1 binwalk.1
For omitting info section there is a -N argument. Typos are better
corrected in the source, and manpage-has-useless-whatis-entry suggests
passing -n with a proper whatis text to help2man.
should I file a bug there?
Sorry but I don't feel good in fixing automatically created files... do you
have any advice for this?
@@ -17,7 +17,6 @@ Architecture: any
Depends: ${python:Depends}, ${shlibs:Depends}, ${misc:Depends},
python-matplotlib,
python-pyqtgraph,
- mtd-utils,
ncompress,
bzip2,
arj,
At least arj looks optional too, maybe others too.
--
WBR, wRAR
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758056: RFS: binwalk/2.0.1-1
Hi Vincent,
Il Martedì 19 Agosto 2014 11:09, Vincent Cheng vch...@debian.org ha scritto:
Control: tag -1 + moreinfo
On Wed, Aug 13, 2014 at 12:49 PM, Gianfranco Costamagna
costamagnagianfra...@yahoo.it wrote:
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package binwalk
* Package name : binwalk
Version : 2.0.1-1
Upstream Author : Craig Heffner heffne...@gmail.com
* URL : https://github.com/devttys0/binwalk
* License : Expat/Zlib
Section : devel
It builds those binary packages:
binwalk - tool for searching binary images for embedded files and
executables
To access further information about this package, please visit the
following URL:
http://mentors.debian.net/package/binwalk
Alternatively, one can download the package with dget using this command:
dget -x
http://mentors.debian.net/debian/pool/main/b/binwalk/binwalk_2.0.1-1.dsc
Changes since the last upload:
* Imported Upstream version 2.0.1 (Closes: #727553)
- Updated docs location
* d/r: Removing binary files when cleaning
* d/c: X-Python-Version: = 2.7
* d/p/destdir.patch: Override install path
* Add some b-d and d
* Bump std-version to 3.9.5, no changes required
* Add myself to uploaders.
* d/{control,watch,copyright} New website (Closes: #734708)
* Canonical VCS urls.
* Update man page.
This isn't a thorough review, but anyways...
debian/copyright is incomplete, missing:
- copyright/licenses of bundled file, pyqtgraph, ssdeep (tarballs in
src/bundles/)
I actually don't use them, but I added them instead of removing the tarballs,
since one day it might be necessary to use one of them (in case of
incompatibilities between particular library versions), and will be easier to
enable them at runtime.
I usually leave the removal only for non dfsg stuff.
- src/C/compress/compress42.c
- src/C/miniz/tinfl.c
Done
You may want to trim down your newly added dependencies, and add only
the dependencies that you actually need, e.g. tar and gzip are both
Essential: yes,
Removed, wonderful!
and do you really need to depend on a JDK?
grep jar . -R
./src/binwalk/config/extract.conf:^zip archive data:zip:jar xf '%e' # jar does
a better job of unzipping than unzip does...
it seems really needed, this program does a great job in its goal, and jar is
quite essential for doing it :(
I tried to ask upstream about dependencies, I also opened an upstream issue
[1], and seems that (also by looking at the code) they are all needed.
[1] https://github.com/devttys0/binwalk/issues/62
Have many thanks for reviewing it, the new package is uploaded on mentors!
Gianfranco
Regards,
Vincent
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758056: RFS: binwalk/2.0.1-1
Control: tag -1 + moreinfo
On Wed, Aug 13, 2014 at 12:49 PM, Gianfranco Costamagna
costamagnagianfra...@yahoo.it wrote:
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package binwalk
* Package name: binwalk
Version : 2.0.1-1
Upstream Author : Craig Heffner heffne...@gmail.com
* URL : https://github.com/devttys0/binwalk
* License : Expat/Zlib
Section : devel
It builds those binary packages:
binwalk- tool for searching binary images for embedded files and
executables
To access further information about this package, please visit the
following URL:
http://mentors.debian.net/package/binwalk
Alternatively, one can download the package with dget using this command:
dget -x
http://mentors.debian.net/debian/pool/main/b/binwalk/binwalk_2.0.1-1.dsc
Changes since the last upload:
* Imported Upstream version 2.0.1 (Closes: #727553)
- Updated docs location
* d/r: Removing binary files when cleaning
* d/c: X-Python-Version: = 2.7
* d/p/destdir.patch: Override install path
* Add some b-d and d
* Bump std-version to 3.9.5, no changes required
* Add myself to uploaders.
* d/{control,watch,copyright} New website (Closes: #734708)
* Canonical VCS urls.
* Update man page.
This isn't a thorough review, but anyways...
debian/copyright is incomplete, missing:
- copyright/licenses of bundled file, pyqtgraph, ssdeep (tarballs in
src/bundles/)
- src/C/compress/compress42.c
- src/C/miniz/tinfl.c
You may want to trim down your newly added dependencies, and add only
the dependencies that you actually need, e.g. tar and gzip are both
Essential: yes, and do you really need to depend on a JDK?
Regards,
Vincent
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758056: RFS: binwalk/2.0.1-1
Hi Pabs, Il Giovedì 14 Agosto 2014 5:39, Paul Wise p...@debian.org ha scritto: On Thu, Aug 14, 2014 at 3:49 AM, Gianfranco Costamagna wrote: I am looking for a sponsor for my package binwalk binwalk is already in Debian and is maintained by someone else. Please talk to them about getting it uploaded. The maintainer didn't answer for more than one month (cc'd again), however, he publicly stated that he is looking for a comaintainer, saying feel free to take it over https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=727553 that is what I'm doing :) BTW the new upstream release fixes also an important bug (serious in my opinion, because render the package unusable) #754317 Cheers, Gianfranco -- bye, pabs https://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758056: RFS: binwalk/2.0.1-1
On Thu, 2014-08-14 at 08:08 +0100, Gianfranco Costamagna wrote: The maintainer didn't answer for more than one month (cc'd again), however, he publicly stated that he is looking for a comaintainer, saying feel free to take it over https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=727553 I see, the situation wasn't clear from the RFS bug, please keep that in mind for future upload requests. BTW the new upstream release fixes also an important bug (serious in my opinion, because render the package unusable) #754317 The severity should probably be increased? -- bye, pabs http://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#758056: RFS: binwalk/2.0.1-1
Il Giovedì 14 Agosto 2014 9:20, Paul Wise p...@debian.org ha scritto: On Thu, 2014-08-14 at 08:08 +0100, Gianfranco Costamagna wrote: The maintainer didn't answer for more than one month (cc'd again), however, he publicly stated that he is looking for a comaintainer, saying feel free to take it over https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=727553 I see, the situation wasn't clear from the RFS bug, please keep that in mind for future upload requests. Yes, sorry for that BTW the new upstream release fixes also an important bug (serious in my opinion, because render the package unusable) #754317 The severity should probably be increased? yes, I'm doing it right now (sorry but I think this is the only maintainer prerogative, this is why I'm reluctant) cheers, Gianfranco -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758056: RFS: binwalk/2.0.1-1
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package binwalk
* Package name : binwalk
Version : 2.0.1-1
Upstream Author : Craig Heffner heffne...@gmail.com
* URL : https://github.com/devttys0/binwalk
* License : Expat/Zlib
Section : devel
It builds those binary packages:
binwalk - tool for searching binary images for embedded files and
executables
To access further information about this package, please visit the following
URL:
http://mentors.debian.net/package/binwalk
Alternatively, one can download the package with dget using this command:
dget -x
http://mentors.debian.net/debian/pool/main/b/binwalk/binwalk_2.0.1-1.dsc
Changes since the last upload:
* Imported Upstream version 2.0.1 (Closes: #727553)
- Updated docs location
* d/r: Removing binary files when cleaning
* d/c: X-Python-Version: = 2.7
* d/p/destdir.patch: Override install path
* Add some b-d and d
* Bump std-version to 3.9.5, no changes required
* Add myself to uploaders.
* d/{control,watch,copyright} New website (Closes: #734708)
* Canonical VCS urls.
* Update man page.
Regards,
LocutusOfBorg
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758056: RFS: binwalk/2.0.1-1
On Thu, Aug 14, 2014 at 3:49 AM, Gianfranco Costamagna wrote: I am looking for a sponsor for my package binwalk binwalk is already in Debian and is maintained by someone else. Please talk to them about getting it uploaded. -- bye, pabs https://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
