Bug#758711: debian-goodies: checkrestart reports services which have open files with name including deleted as to be restarted

[Javier Fernández-Sanguino Peña]

tag  758711 pending
thanks

On Wed, Aug 20, 2014 at 02:42:44PM +0200, Roman Pertl wrote:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1
 
 Package: debian-goodies
 Version: 0.61
 Severity: normal
 
 On our mysql server we have a table called upload_tmp_deleted which
 let checkrestart think that mysql should be restarted, probably
 because checkrestart does not check the string deleted in lsof output
 strictly enough.

This false positive in checkrestart has been recently fixed in the GIT
repository. A fix will be uploaded shortly.

Best regards

Javier


signature.asc
Description: Digital signature

Bug#758711: debian-goodies: checkrestart reports services which have open files with name including deleted as to be restarted

[Simon Ruderich]

tags 568359 patch
tags 758711 patch
thanks

Hello,

The attached patch fixes this issue by checking for (deleted)
instead of just deleted. Still not perfect, but should handle
most cases.

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
diff -Nru debian-goodies-0.63/checkrestart debian-goodies-0.63simon1/checkrestart
--- debian-goodies-0.63/checkrestart	2013-07-05 14:37:50.0 +0200
+++ debian-goodies-0.63simon1/checkrestart	2014-08-31 23:29:57.0 +0200
@@ -293,7 +293,7 @@
 last = process.descriptors.pop()
 # Add it to the list of deleted files if the previous descriptor
 # was DEL or lsof marks it as deleted
-if re.compile(DEL).search(last) or re.compile(deleted).search(data) or re.compile(\(path inode=[0-9]+\)$).search(data):
+if re.compile(DEL).search(last) or re.compile(\(deleted\)).search(data) or re.compile(\(path inode=[0-9]+\)$).search(data):
 process.files.append(data)
 else:
 # We discard the previous descriptors and drop it


signature.asc
Description: Digital signature

Bug#758711: debian-goodies: checkrestart reports services which have open files with name including deleted as to be restarted

[Roman Pertl]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Package: debian-goodies
Version: 0.61
Severity: normal

On our mysql server we have a table called upload_tmp_deleted which
let checkrestart think that mysql should be restarted, probably
because checkrestart does not check the string deleted in lsof output
strictly enough.

output of checkrestart
$ checkrestart -pva
Found 1 processes using old versions of upgraded files
(1 distinct program)
Process /usr/sbin/mysqld (PID: 2775)
List of deleted files in use:
/var/lib/mysql/database/upload_tmp_deleted.ibd
/var/lib/mysql/database/upload_tmp_deleted.ibd
/var/lib/mysql/database/upload_tmp_deleted.ibd
/var/lib/mysql/database/upload_tmp_deleted.ibd
/var/lib/mysql/database/upload_tmp_deleted.ibd
/var/lib/mysql/database/upload_tmp_deleted.ibd
/var/lib/mysql/database/upload_tmp_deleted.ibd
/var/lib/mysql/database/upload_tmp_deleted.ibd
/var/lib/mysql/database/upload_tmp_deleted.ibd
/var/lib/mysql/database/upload_tmp_deleted.ibd
Running:['dpkg-query', '--search', '/usr/sbin/mysqld']
Reading line: percona-server-server-5.6: /usr/sbin/mysqld

(1 distinct packages)

Of these, 1 seem to contain init scripts which can be used to restart
them:
The following packages seem to have init scripts that could be used
to restart them:
percona-server-server-5.6:
2775/usr/sbin/mysqld

These are the init scripts:
service mysql restart


- -- System Information:
Debian Release: 7.6
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-openvz-042stab093.4-amd64 (SMP w/32 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages debian-goodies depends on:
ii  curl  7.26.0-1+wheezy9
ii  dctrl-tools [grep-dctrl]  2.22.2
ii  perl  5.14.2-21+deb7u1
ii  python2.7.3-4+deb7u1
ii  whiptail  0.52.14-11.1

Versions of packages debian-goodies recommends:
ii  lsof  4.86+dfsg-1

Versions of packages debian-goodies suggests:
pn  popularity-contest  none
pn  xdg-utils   none
pn  zenity  none

- -- no debconf information

-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQEcBAEBAgAGBQJT9JfEAAoJEK8Ii7qe/iAw50cH/R0nlQwqyBK2hw2I/UXZJMnD
SH5MV1ENalbrwqQHzEBcm9ShXMBh1DSHCkPcmRTh2KcQ55PjF/UARb/adEp8txoM
Qz/gXuL4Y/qudWHVNR4CD+oVLl3mOsZKVjNBCegYmlYdRK2N4yN+tOkHC5EHa4lh
f2//NYDyRGTD03T1+gsjanW60LZW6oZxdmIll66hLu4uaqZIf6g5N4N1IyrQ3Acc
2BaoJLMPII2RihoTkQUEGf87nxdB0GCcjDVeOBOjM3XImhRkMAb4tfjyzFlH3kw8
pJgoEnQeuYMYl/efeRFhMDw0xLeGaatRFNHmKNi69JgJCd4sz7FgDfZhf63GJN4=
=8qQj
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org