Bug#759311: RFS: node-base64-url/1.0.0-1 [ITP]
Hi Joseph, Thanks for making the package for Debian! I'm not a DD, so I can't sponsor your package, but here's my review: d/control: -Don't put each dependency on a different line. -In your description, you don't need to include a description of what node.js is, rather, you can mention that your package makes use of node.js d/copyright: -Use the author's full name (Joaquim José F. Serafim) instead of their Github username. d/rules: -Remove the commented lines; only keep what is necessary. d/watch: -Why have you used fakeupstream? Can it actually detect new upstream versions, and if so, how? If not, then you should just make a watch file with some comments explaining that upstream doesn't provide a uscan-compatible method of getting releases. README.md: This is really upstream's problem, but the sample usage of base64url.escape needs to have quotes around the input to run correctly; furthermore all outputs should have quotes around them as well. Perhaps you could patch this and then send the fix upstream? Once you have done this, you may wish to contact the Debian JavaScript Maintainers[1] to see if you can get one of them to sponsor your package. Good luck in getting your package into Debian! Riley Baird -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#759311: RFS: node-base64-url/1.0.0-1 [ITP]
On 26 August 2014 08:46:27 BST, Riley Baird bm-2cvqnduybau5do2dfjtrn7zbaj246s4...@bitmessage.ch wrote: Hi Joseph, Thanks for making the package for Debian! I'm not a DD, so I can't sponsor your package, but here's my review: d/control: -Don't put each dependency on a different line. This is actually common practice as having them on separate lines makes it easier to review a diff for future versions. --- Regards Daniel Lintott Sent from my Android device with K-9 Mail. Please excuse my brevity. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#759311: RFS: node-base64-url/1.0.0-1 [ITP]
This package is questionnable because it contains too little code... https://github.com/joaquimserafim/base64-url/blob/master/index.js There is an ongoing discussion on pkg-javascript ML about bundling packages: http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/2014-August/008488.html Jérémy. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#759311: RFS: node-base64-url/1.0.0-1 [ITP]
d/control: -Don't put each dependency on a different line. This is actually common practice as having them on separate lines makes it easier to review a diff for future versions. Okay, thanks, I didn't know that. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#759311: RFS: node-base64-url/1.0.0-1 [ITP]
On Jérémy Lal kapo...@melix.org wrote: This package is questionnable because it contains too little code... https://github.com/joaquimserafim/base64-url/blob/master/index.js There is an ongoing discussion on pkg-javascript ML about bundling packages: http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/2014-August/008488.html Jérémy. Then I'll wait for the discussion to play out and see what I do then. Thanks, Joseph -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#759311: RFS: node-base64-url/1.0.0-1 [ITP]
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package node-base64-url * Package name: node-base64-url Version : 1.0.0-1 Upstream Author : Joaquim Serafim * URL : https://github.com/joaquimserafim/base64-url * License : ISC Section : web It builds those binary packages: node-base64-url - Base64 encode, decode, escape and unescape for URL applications To access further information about this package, please visit the following URL: http://mentors.debian.net/package/node-base64-url Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/n/node-base64-url/node-base64-url_1.0.0-1.dsc Regards, Joseph Bisch -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
