Bug#760241: RFS: winetricks/0.0+20140818+svn1202-1 (ITA)

2014-09-02 Thread Eriberto Mota
Hi Joseph.

Please:

1. d/changelog:
- Change from 'Add Joseph Bisch as maintainer (Closes: #735288)'
to 'New maintainer (Closes: #735288)'.

2. Remove all garbage: d/changelog.{BACKUP.21866, BASE.21866,
LOCAL.21866, REMOTE.21866}. These files are trash or references to
Ubuntu d/changelog.

3. d/control:
- Why the package recommends zenity | kdebase-bin? I am afraid
because kdebase-bin is a monster (a detail: I use KDE). I need you
invetigate this dependency.
- Do you have access to collab-maint? If not, you must create an
external VCS and import all data.
- The long description appears a mix between long description and
README. Please, move this content to README.Debian (you can create a
new section below the Jari Aalto and put a footer with your name):

 About pckages in Recommends header: to use GUI progress bar, install
 package zenity. To read manuals, install package xdg-utils. If
 you need to cache any *.iso files with the -k option, install package
 sudo or sudo GUI gksu.
 .
 NOTE: This package suggests installing package libwine. Some, but not
 all package downloads depend on restarting the wineserver which is
 included in libwine.
 .
 NOTE: In case you have compiled wine from sources and installed it
 out of dpkg(1)'s control, winetricks' depends wouldn't know about it. In
 that case create a dummy wine package to satisfy depends by using
 tools in equivs package before installing winetricks. An example:
 .
   git clone g...@github.com:jaalto/project--debian-wine-dummy.git
   cd project--debian-wine-dummy
   make
   dpkg -i wine*.deb
   apt-get install winetricks


I suggest review and rewrite the original text.


d/copyright: you need update the upstream name list and years in
'Files: *'. you can use 'grep -sri copyright * | grep -v debian'.

d/rules: I suggest move the winetricks.svg install to d/install. it
will avoid two points of installation.

d/watch: doesn't show the last version.

d/clean: currently, this file hasn't a function.

Thanks for your work.

Cheers,

Eriberto


2014-09-01 21:40 GMT-03:00 Joseph Bisch joseph.bi...@gmail.com:
 Package: sponsorship-requests
 Severity: normal [important for RC bugs, wishlist for new packages]

 Dear mentors,

 I am looking for a sponsor for my package winetricks

 Winetricks was orphaned, and I am adopting it.

 * Package name: winetricks
   Version : 0.0+20140818+svn1202-1
   Upstream Author : Dan Kegel d...@kegel.com
 * URL : https://code.google.com/p/winetricks/
 * License : LGPL-2.1
   Section : otherosfs

 It builds those binary packages:

   winetricks - package manager for WINE to install software easily

 To access further information about this package, please visit the following 
 URL:

 http://mentors.debian.net/package/winetricks


 Alternatively, one can download the package with dget using this command:

   dget -x 
 http://mentors.debian.net/debian/pool/contrib/w/winetricks/winetricks_0.0+20140818+svn1202-1.dsc


 Regards,
   Joseph Bisch


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#760241: RFS: winetricks/0.0+20140818+svn1202-1 (ITA)

2014-09-02 Thread Joseph Bisch
Hi Eriberto,

Thanks for reviewing my package. I reuploaded it to mentors.d.n. I
also uploaded to a private git repository, because I don't have
access to collab-maint. See my notes below on your points.

On Tue, Sep 02, 2014 at 10:25:06AM -0300, Eriberto Mota wrote:
 Hi Joseph.
 
 Please:
 
 1. d/changelog:
 - Change from 'Add Joseph Bisch as maintainer (Closes: #735288)'
 to 'New maintainer (Closes: #735288)'.

Done
 
 2. Remove all garbage: d/changelog.{BACKUP.21866, BASE.21866,
 LOCAL.21866, REMOTE.21866}. These files are trash or references to
 Ubuntu d/changelog.

Done
 
 3. d/control:
 - Why the package recommends zenity | kdebase-bin? I am afraid
 because kdebase-bin is a monster (a detail: I use KDE). I need you
 invetigate this dependency.
 - Do you have access to collab-maint? If not, you must create an
 external VCS and import all data.
 - The long description appears a mix between long description and
 README. Please, move this content to README.Debian (you can create a
 new section below the Jari Aalto and put a footer with your name):
 
  About pckages in Recommends header: to use GUI progress bar, install
  package zenity. To read manuals, install package xdg-utils. If
  you need to cache any *.iso files with the -k option, install package
  sudo or sudo GUI gksu.
  .
  NOTE: This package suggests installing package libwine. Some, but not
  all package downloads depend on restarting the wineserver which is
  included in libwine.
  .
  NOTE: In case you have compiled wine from sources and installed it
  out of dpkg(1)'s control, winetricks' depends wouldn't know about it. In
  that case create a dummy wine package to satisfy depends by using
  tools in equivs package before installing winetricks. An example:
  .
git clone g...@github.com:jaalto/project--debian-wine-dummy.git
cd project--debian-wine-dummy
make
dpkg -i wine*.deb
apt-get install winetricks
 
 

I moved all the stuff to README.Debian. I don't have access to collab-maint,
so I changed the Vcs fields to a private repo. I think the package
recommends zenity | kdebase-bin because of Kdialog which can be used as an
alternative to zenity. What do you think I should do about it?

 
 d/copyright: you need update the upstream name list and years in
 'Files: *'. you can use 'grep -sri copyright * | grep -v debian'.

Done

 d/rules: I suggest move the winetricks.svg install to d/install. it
 will avoid two points of installation.

Done

 d/watch: doesn't show the last version.

What do you suggest I do? The watch file is setup for the actual releases,
but the previous maintainer has been packaging the version directly from
svn. I guess I can figure out a way to get the watch file working with
Google Code source browser.
 
 d/clean: currently, this file hasn't a function.

Removed.

Thanks,
Joseph


signature.asc
Description: Digital signature


Bug#760241: RFS: winetricks/0.0+20140818+svn1202-1 (ITA)

2014-09-02 Thread Eriberto Mota
2014-09-02 16:45 GMT-03:00 Joseph Bisch joseph.bi...@gmail.com:
 Hi Eriberto,

 Thanks for reviewing my package. I reuploaded it to mentors.d.n. I
 also uploaded to a private git repository, because I don't have
 access to collab-maint. See my notes below on your points.


You're welcome.


 On Tue, Sep 02, 2014 at 10:25:06AM -0300, Eriberto Mota wrote:

 3. d/control:
 - Why the package recommends zenity | kdebase-bin? I am afraid
 because kdebase-bin is a monster (a detail: I use KDE). I need you
 invetigate this dependency.
 - Do you have access to collab-maint? If not, you must create an
 external VCS and import all data.
 - The long description appears a mix between long description and
 README. Please, move this content to README.Debian (you can create a
 new section below the Jari Aalto and put a footer with your name):




 I moved all the stuff to README.Debian.


Please, remove: 'From d/control:'.


 I don't have access to collab-maint,
 so I changed the Vcs fields to a private repo.


Ok.


 I think the package
 recommends zenity | kdebase-bin because of Kdialog which can be used as an
 alternative to zenity. What do you think I should do about it?


I agree.




 d/copyright: you need update the upstream name list and years in
 'Files: *'. you can use 'grep -sri copyright * | grep -v debian'.

 Done



A Lintian message:

W: winetricks source: missing-license-paragraph-in-dep5-copyright lgpl-2.1



 d/watch: doesn't show the last version.

 What do you suggest I do? The watch file is setup for the actual releases,
 but the previous maintainer has been packaging the version directly from
 svn. I guess I can figure out a way to get the watch file working with
 Google Code source browser.


My suggestion. It won't allow downloads but you will know if have a
new version (commit):

version=3
opts=dversionmangle=s/.*svn// \
http://code.google.com/p/winetricks/source/list detail\?r=(\d+)

Another option is package the version available at
http://winetricks.org/download/releases/.

Cheers,

Eriberto


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#760241: RFS: winetricks/0.0+20140818+svn1202-1 (ITA)

2014-09-02 Thread Joseph Bisch
Hi Eriberto,

I made your changes. Is there anything else I should do?

Thanks,
Joseph


signature.asc
Description: Digital signature


Bug#760241: RFS: winetricks/0.0+20140818+svn1202-1 (ITA)

2014-09-02 Thread Eriberto Mota
Hi! I uploaded to Debian now.

Thanks a lot for your work.

Cheers,

Eriberto


2014-09-02 18:46 GMT-03:00 Joseph Bisch joseph.bi...@gmail.com:
 Hi Eriberto,

 I made your changes. Is there anything else I should do?

 Thanks,
 Joseph


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#760241: RFS: winetricks/0.0+20140818+svn1202-1 (ITA)

2014-09-01 Thread Joseph Bisch
Package: sponsorship-requests
Severity: normal [important for RC bugs, wishlist for new packages]

Dear mentors,

I am looking for a sponsor for my package winetricks

Winetricks was orphaned, and I am adopting it.

* Package name: winetricks
  Version : 0.0+20140818+svn1202-1
  Upstream Author : Dan Kegel d...@kegel.com
* URL : https://code.google.com/p/winetricks/
* License : LGPL-2.1
  Section : otherosfs

It builds those binary packages:

  winetricks - package manager for WINE to install software easily

To access further information about this package, please visit the following 
URL:

http://mentors.debian.net/package/winetricks


Alternatively, one can download the package with dget using this command:

  dget -x 
http://mentors.debian.net/debian/pool/contrib/w/winetricks/winetricks_0.0+20140818+svn1202-1.dsc


Regards,
  Joseph Bisch


signature.asc
Description: Digital signature