Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-14 Thread whey bags
Ok, I uploaded a fnew version that fixes all he lintian errors,
except, W: librocket: package-name-doesnt-match-sonames
libRocketControls1 libRocketCore1 libRocketDebugger1, because I don't
think that one can be fixed.
On a side note, I had to delete and reupload the package to get it to
update in the webui, and now
http://mentors.debian.net/package/librocket says this bug doesn't
belong to that package.

On Mon, Oct 13, 2014 at 9:27 PM, whey bags wheyb...@wheybags.com wrote:
 wait, nvm , think I read it wrong

 On Mon, Oct 13, 2014 at 9:23 PM, whey bags wheyb...@wheybags.com wrote:
 The .so symlink should be installed in the -dev package.

 From reading 
 https://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-runtime
 , it seems like it should be in the runtime package, as I have it?

 On Tue, Oct 7, 2014 at 11:13 AM, Paul Wise p...@debian.org wrote:
 On Mon, 2014-10-06 at 22:13 -0400, Harlan Lieberman-Berg wrote:

 Thanks for packaging librocket for Debian.  I've got a couple things for
 you to fix as the next steps.

 Good review Harlan, you missed some important things though, see below.

 2. Your changelog should close an ITP bug - in your case, #764252.

 You can do that by adding this in your changelog:

 (Closes: #764252)

 5. Your standards version isn't the latest version - you should update
 it to 3.9.6.

 Here is the list of changes since the last version:

 https://www.debian.org/doc/debian-policy/upgrading-checklist

 6. Your packages should have a short description and a longer
 description that should be enough information for a user to decide
 whether they want to install the package.  Check out Debian Policy 3.4
 for more details there.

 https://www.debian.org/doc/debian-policy/ch-binary.html#s-descriptions

 These issues block the upload of this package:

 The package fails to build for me:

  debian/rules build
 dh build --buildsystem=cmake --sourcedirectory=Build
dh_testdir -O--buildsystem=cmake -O--sourcedirectory=Build
debian/rules override_dh_auto_configure
 make[1]: Entering directory '/tmp/buildd/librocket-1.3'
 dh_auto_configure -- -DBUILD_PYTHON_BINDINGS=On
 -DCMAKE_INSTALL_LIBDIR=/usr/lib
 dh_auto_configure: cmake ../Build -DCMAKE_INSTALL_PREFIX=/usr
 -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None
 -DBUILD_PYTHON_BINDINGS=On -DCMAKE_INSTALL_LIBDIR=/usr/lib failed to to
 execute: No such file or directory
 debian/rules:11: recipe for target 'override_dh_auto_configure' failed
 make[1]: *** [override_dh_auto_configure] Error 2
 make[1]: Leaving directory '/tmp/buildd/librocket-1.3'
 debian/rules:8: recipe for target 'build' failed
 make: *** [build] Error 2

 The python package should be named python-rocket:

 https://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html#s-package_names

 The .so symlink should be installed in the -dev package.

 The library package should be named librocketN

 Please read the Debian policy sections on libraries:

 https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

 Some parts (in Samples/tutorial) of the upstream tarball do not have a
 clear license. The copyright holder is also different to the rest of the
 package. Some other parts (Samples/) have a DFSG-free license but a
 different copyright holder. The status should be clarified upstream, a
 DFSG-free license applied and the results documented in
 debian/copyright.

 The fonts in Samples/assets are under a non-free license and cannot be
 distributed in Debian main. Please ask upstream to remove them from the
 tarball and from their version control system. They can simply use
 font-family: sans-serif in invader.rcss instead.

 http://www.exljbris.com/delicious.html
 http://www.exljbris.com/eula.html

 Some other issues that you might want to correct:

 librocket.pc has an incorrect Version and Description.

 Please forward the patches upstream if appropriate.

 Please add a debian/watch file based on the example and the docs:

 https://wiki.debian.org/debian/watch

 debian/README.source is a copy of part of the upstream readme.md and is
 not needed.

 The static library normally isn't needed, please remove it unless
 someone files a bug report asking for it to be added.

 The pkg-config file doesn't appear to be installed in the package.
 https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
 how_to_build_for_mingw.txt is not relevant to Debian users, please drop
 it from debian/docs.

 changelog.txt should be installed with dh_installchangelogs rather than
 dh_installdocs.

 debian/copyright doesn't look like it conforms to the format. In
 particular the licenses are missing dots on the blank lines. In
 addition, you can avoid having two copies of the license by having one
 license section separated from the files sections and have those files
 sections refer to the files sections. The long lines of the license text
 should also be wrapped.

 http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-14 Thread Daniel Lintott
Hi,

On 14/10/14 17:51, whey bags wrote:
 On a side note, I had to delete and reupload the package to get it to
 update in the webui, and now
 http://mentors.debian.net/package/librocket says this bug doesn't
 belong to that package.

For your fist point... you should be able to just upload the package
without deleting the old one. The newest package will appear at the top
of the page, with your earlier packages below it.

This is because your package on mentors closes the wrong bug.

In you packages changelog you should close bug #764252 (the ITP bug).

Bug #764261 is your request for sponsorship, your sponsor will handle
closing that when they upload your package.

Regards

Daniel Lintott



signature.asc
Description: OpenPGP digital signature


Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-14 Thread whey bags
I tried and it showed as having uploaded in the cli, but when I went
on the webpage it was the old one.

On Tue, Oct 14, 2014 at 6:02 PM, Daniel Lintott dan...@serverb.co.uk wrote:
 Hi,

 On 14/10/14 17:51, whey bags wrote:
 On a side note, I had to delete and reupload the package to get it to
 update in the webui, and now
 http://mentors.debian.net/package/librocket says this bug doesn't
 belong to that package.

 For your fist point... you should be able to just upload the package
 without deleting the old one. The newest package will appear at the top
 of the page, with your earlier packages below it.

 This is because your package on mentors closes the wrong bug.

 In you packages changelog you should close bug #764252 (the ITP bug).

 Bug #764261 is your request for sponsorship, your sponsor will handle
 closing that when they upload your package.

 Regards

 Daniel Lintott



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-14 Thread Daniel Lintott
Hi,

On 14/10/14 18:14, whey bags wrote:
 I tried and it showed as having uploaded in the cli, but when I went
 on the webpage it was the old one.
 

It does sometimes take a while for the upload to be processed and it
appear on the webpage (it won't appear until you've received the email
confirmation).

The packages at [1][2], will give you an indication of how it will show
up when you upload new versions.

Regards

Daniel

[1] http://mentors.debian.net/package/yubikey-neo-manager
[2] http://mentors.debian.net/package/openbox



signature.asc
Description: OpenPGP digital signature


Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-13 Thread whey bags
How do I get access to the collab maint project?

On Tue, Oct 7, 2014 at 3:13 AM, Harlan Lieberman-Berg
h.liebermanb...@gmail.com wrote:
 Hi Tom!

 Thanks for packaging librocket for Debian.  I've got a couple things for
 you to fix as the next steps.

 1. You should delete all of those .ex files in the debian directory.
 Those are just examples of things that you might need to do.

 2. Your changelog should close an ITP bug - in your case, #764252.

 3. If you are using compat = 9 (which you should!), you need to depend
 on debhelper = 9.

 4. Your VCS fields contain a repository which doesn't exist.  You should
 setup the collab-maint repository and push the packaging's git
 repository there.

 5. Your standards version isn't the latest version - you should update
 it to 3.9.6.

 6. Your packages should have a short description and a longer
 description that should be enough information for a user to decide
 whether they want to install the package.  Check out Debian Policy 3.4
 for more details there.

 7. Your patches are missing DEP-3 headers; check out the patch tagging
 guidelines at http://dep.debian.net/deps/dep3/.

 Lintian is a very helpful tool for finding some of these problems, and
 has more than I detailed above, as well as some general warnings that
 might point to bigger problems.  I recommend it highly; it's saved my
 butt on many an occasion!

 Thanks again for your help packaging librocket for Debian; when you've
 got another upload that fixes the problems, send the bug a mail and
 someone will swing by and take another look.

 Sincerely,

 --
 Harlan Lieberman-Berg
 ~hlieberman



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-13 Thread Harlan Lieberman-Berg
You will need to sign up for access to alioth and then request a Debian
Developer sponsor your access.  Check out
https://wiki.debian.org/Alioth/PackagingProject for more information.

On Mon, Oct 13, 2014 at 2:59 PM, whey bags wheyb...@wheybags.com wrote:

 How do I get access to the collab maint project?

 On Tue, Oct 7, 2014 at 3:13 AM, Harlan Lieberman-Berg
 h.liebermanb...@gmail.com wrote:
  Hi Tom!
 
  Thanks for packaging librocket for Debian.  I've got a couple things for
  you to fix as the next steps.
 
  1. You should delete all of those .ex files in the debian directory.
  Those are just examples of things that you might need to do.
 
  2. Your changelog should close an ITP bug - in your case, #764252.
 
  3. If you are using compat = 9 (which you should!), you need to depend
  on debhelper = 9.
 
  4. Your VCS fields contain a repository which doesn't exist.  You should
  setup the collab-maint repository and push the packaging's git
  repository there.
 
  5. Your standards version isn't the latest version - you should update
  it to 3.9.6.
 
  6. Your packages should have a short description and a longer
  description that should be enough information for a user to decide
  whether they want to install the package.  Check out Debian Policy 3.4
  for more details there.
 
  7. Your patches are missing DEP-3 headers; check out the patch tagging
  guidelines at http://dep.debian.net/deps/dep3/.
 
  Lintian is a very helpful tool for finding some of these problems, and
  has more than I detailed above, as well as some general warnings that
  might point to bigger problems.  I recommend it highly; it's saved my
  butt on many an occasion!
 
  Thanks again for your help packaging librocket for Debian; when you've
  got another upload that fixes the problems, send the bug a mail and
  someone will swing by and take another look.
 
  Sincerely,
 
  --
  Harlan Lieberman-Berg
  ~hlieberman
 



Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-13 Thread whey bags
 The .so symlink should be installed in the -dev package.

From reading 
https://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-runtime
, it seems like it should be in the runtime package, as I have it?

On Tue, Oct 7, 2014 at 11:13 AM, Paul Wise p...@debian.org wrote:
 On Mon, 2014-10-06 at 22:13 -0400, Harlan Lieberman-Berg wrote:

 Thanks for packaging librocket for Debian.  I've got a couple things for
 you to fix as the next steps.

 Good review Harlan, you missed some important things though, see below.

 2. Your changelog should close an ITP bug - in your case, #764252.

 You can do that by adding this in your changelog:

 (Closes: #764252)

 5. Your standards version isn't the latest version - you should update
 it to 3.9.6.

 Here is the list of changes since the last version:

 https://www.debian.org/doc/debian-policy/upgrading-checklist

 6. Your packages should have a short description and a longer
 description that should be enough information for a user to decide
 whether they want to install the package.  Check out Debian Policy 3.4
 for more details there.

 https://www.debian.org/doc/debian-policy/ch-binary.html#s-descriptions

 These issues block the upload of this package:

 The package fails to build for me:

  debian/rules build
 dh build --buildsystem=cmake --sourcedirectory=Build
dh_testdir -O--buildsystem=cmake -O--sourcedirectory=Build
debian/rules override_dh_auto_configure
 make[1]: Entering directory '/tmp/buildd/librocket-1.3'
 dh_auto_configure -- -DBUILD_PYTHON_BINDINGS=On
 -DCMAKE_INSTALL_LIBDIR=/usr/lib
 dh_auto_configure: cmake ../Build -DCMAKE_INSTALL_PREFIX=/usr
 -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None
 -DBUILD_PYTHON_BINDINGS=On -DCMAKE_INSTALL_LIBDIR=/usr/lib failed to to
 execute: No such file or directory
 debian/rules:11: recipe for target 'override_dh_auto_configure' failed
 make[1]: *** [override_dh_auto_configure] Error 2
 make[1]: Leaving directory '/tmp/buildd/librocket-1.3'
 debian/rules:8: recipe for target 'build' failed
 make: *** [build] Error 2

 The python package should be named python-rocket:

 https://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html#s-package_names

 The .so symlink should be installed in the -dev package.

 The library package should be named librocketN

 Please read the Debian policy sections on libraries:

 https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

 Some parts (in Samples/tutorial) of the upstream tarball do not have a
 clear license. The copyright holder is also different to the rest of the
 package. Some other parts (Samples/) have a DFSG-free license but a
 different copyright holder. The status should be clarified upstream, a
 DFSG-free license applied and the results documented in
 debian/copyright.

 The fonts in Samples/assets are under a non-free license and cannot be
 distributed in Debian main. Please ask upstream to remove them from the
 tarball and from their version control system. They can simply use
 font-family: sans-serif in invader.rcss instead.

 http://www.exljbris.com/delicious.html
 http://www.exljbris.com/eula.html

 Some other issues that you might want to correct:

 librocket.pc has an incorrect Version and Description.

 Please forward the patches upstream if appropriate.

 Please add a debian/watch file based on the example and the docs:

 https://wiki.debian.org/debian/watch

 debian/README.source is a copy of part of the upstream readme.md and is
 not needed.

 The static library normally isn't needed, please remove it unless
 someone files a bug report asking for it to be added.

 The pkg-config file doesn't appear to be installed in the package.
 https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
 how_to_build_for_mingw.txt is not relevant to Debian users, please drop
 it from debian/docs.

 changelog.txt should be installed with dh_installchangelogs rather than
 dh_installdocs.

 debian/copyright doesn't look like it conforms to the format. In
 particular the licenses are missing dots on the blank lines. In
 addition, you can avoid having two copies of the license by having one
 license section separated from the files sections and have those files
 sections refer to the files sections. The long lines of the license text
 should also be wrapped.

 http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

 I wonder about the *.tga files in Samples/*invaders/data and
 Samples/assets, some of them look like they might have other files (SVG
 or similar) as their source. Please ask upstream to include the SVG or
 other source in the tarball and have the build system create the *.tga
 files at build time.

 If the sample games are fun it might be interesting to make packages for
 them. If not, their source could be included in an examples package.

 Automatic checks:

 https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
 

Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-13 Thread whey bags
wait, nvm , think I read it wrong

On Mon, Oct 13, 2014 at 9:23 PM, whey bags wheyb...@wheybags.com wrote:
 The .so symlink should be installed in the -dev package.

 From reading 
 https://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-runtime
 , it seems like it should be in the runtime package, as I have it?

 On Tue, Oct 7, 2014 at 11:13 AM, Paul Wise p...@debian.org wrote:
 On Mon, 2014-10-06 at 22:13 -0400, Harlan Lieberman-Berg wrote:

 Thanks for packaging librocket for Debian.  I've got a couple things for
 you to fix as the next steps.

 Good review Harlan, you missed some important things though, see below.

 2. Your changelog should close an ITP bug - in your case, #764252.

 You can do that by adding this in your changelog:

 (Closes: #764252)

 5. Your standards version isn't the latest version - you should update
 it to 3.9.6.

 Here is the list of changes since the last version:

 https://www.debian.org/doc/debian-policy/upgrading-checklist

 6. Your packages should have a short description and a longer
 description that should be enough information for a user to decide
 whether they want to install the package.  Check out Debian Policy 3.4
 for more details there.

 https://www.debian.org/doc/debian-policy/ch-binary.html#s-descriptions

 These issues block the upload of this package:

 The package fails to build for me:

  debian/rules build
 dh build --buildsystem=cmake --sourcedirectory=Build
dh_testdir -O--buildsystem=cmake -O--sourcedirectory=Build
debian/rules override_dh_auto_configure
 make[1]: Entering directory '/tmp/buildd/librocket-1.3'
 dh_auto_configure -- -DBUILD_PYTHON_BINDINGS=On
 -DCMAKE_INSTALL_LIBDIR=/usr/lib
 dh_auto_configure: cmake ../Build -DCMAKE_INSTALL_PREFIX=/usr
 -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None
 -DBUILD_PYTHON_BINDINGS=On -DCMAKE_INSTALL_LIBDIR=/usr/lib failed to to
 execute: No such file or directory
 debian/rules:11: recipe for target 'override_dh_auto_configure' failed
 make[1]: *** [override_dh_auto_configure] Error 2
 make[1]: Leaving directory '/tmp/buildd/librocket-1.3'
 debian/rules:8: recipe for target 'build' failed
 make: *** [build] Error 2

 The python package should be named python-rocket:

 https://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html#s-package_names

 The .so symlink should be installed in the -dev package.

 The library package should be named librocketN

 Please read the Debian policy sections on libraries:

 https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

 Some parts (in Samples/tutorial) of the upstream tarball do not have a
 clear license. The copyright holder is also different to the rest of the
 package. Some other parts (Samples/) have a DFSG-free license but a
 different copyright holder. The status should be clarified upstream, a
 DFSG-free license applied and the results documented in
 debian/copyright.

 The fonts in Samples/assets are under a non-free license and cannot be
 distributed in Debian main. Please ask upstream to remove them from the
 tarball and from their version control system. They can simply use
 font-family: sans-serif in invader.rcss instead.

 http://www.exljbris.com/delicious.html
 http://www.exljbris.com/eula.html

 Some other issues that you might want to correct:

 librocket.pc has an incorrect Version and Description.

 Please forward the patches upstream if appropriate.

 Please add a debian/watch file based on the example and the docs:

 https://wiki.debian.org/debian/watch

 debian/README.source is a copy of part of the upstream readme.md and is
 not needed.

 The static library normally isn't needed, please remove it unless
 someone files a bug report asking for it to be added.

 The pkg-config file doesn't appear to be installed in the package.
 https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
 how_to_build_for_mingw.txt is not relevant to Debian users, please drop
 it from debian/docs.

 changelog.txt should be installed with dh_installchangelogs rather than
 dh_installdocs.

 debian/copyright doesn't look like it conforms to the format. In
 particular the licenses are missing dots on the blank lines. In
 addition, you can avoid having two copies of the license by having one
 license section separated from the files sections and have those files
 sections refer to the files sections. The long lines of the license text
 should also be wrapped.

 http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

 I wonder about the *.tga files in Samples/*invaders/data and
 Samples/assets, some of them look like they might have other files (SVG
 or similar) as their source. Please ask upstream to include the SVG or
 other source in the tarball and have the build system create the *.tga
 files at build time.

 If the sample games are fun it might be interesting to make packages for
 them. If not, their source could be included in an examples package.

 Automatic checks:

 

Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-07 Thread Paul Wise
On Mon, 2014-10-06 at 22:13 -0400, Harlan Lieberman-Berg wrote:

 Thanks for packaging librocket for Debian.  I've got a couple things for
 you to fix as the next steps.

Good review Harlan, you missed some important things though, see below.

 2. Your changelog should close an ITP bug - in your case, #764252.

You can do that by adding this in your changelog:

(Closes: #764252)

 5. Your standards version isn't the latest version - you should update
 it to 3.9.6.

Here is the list of changes since the last version:

https://www.debian.org/doc/debian-policy/upgrading-checklist

 6. Your packages should have a short description and a longer
 description that should be enough information for a user to decide
 whether they want to install the package.  Check out Debian Policy 3.4
 for more details there.

https://www.debian.org/doc/debian-policy/ch-binary.html#s-descriptions

These issues block the upload of this package:

The package fails to build for me:

 debian/rules build
dh build --buildsystem=cmake --sourcedirectory=Build 
   dh_testdir -O--buildsystem=cmake -O--sourcedirectory=Build
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/tmp/buildd/librocket-1.3'
dh_auto_configure -- -DBUILD_PYTHON_BINDINGS=On
-DCMAKE_INSTALL_LIBDIR=/usr/lib
dh_auto_configure: cmake ../Build -DCMAKE_INSTALL_PREFIX=/usr
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None
-DBUILD_PYTHON_BINDINGS=On -DCMAKE_INSTALL_LIBDIR=/usr/lib failed to to
execute: No such file or directory
debian/rules:11: recipe for target 'override_dh_auto_configure' failed
make[1]: *** [override_dh_auto_configure] Error 2
make[1]: Leaving directory '/tmp/buildd/librocket-1.3'
debian/rules:8: recipe for target 'build' failed
make: *** [build] Error 2

The python package should be named python-rocket:

https://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html#s-package_names

The .so symlink should be installed in the -dev package.

The library package should be named librocketN

Please read the Debian policy sections on libraries:

https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

Some parts (in Samples/tutorial) of the upstream tarball do not have a
clear license. The copyright holder is also different to the rest of the
package. Some other parts (Samples/) have a DFSG-free license but a
different copyright holder. The status should be clarified upstream, a
DFSG-free license applied and the results documented in
debian/copyright.

The fonts in Samples/assets are under a non-free license and cannot be
distributed in Debian main. Please ask upstream to remove them from the
tarball and from their version control system. They can simply use
font-family: sans-serif in invader.rcss instead.

http://www.exljbris.com/delicious.html
http://www.exljbris.com/eula.html

Some other issues that you might want to correct:

librocket.pc has an incorrect Version and Description.

Please forward the patches upstream if appropriate.

Please add a debian/watch file based on the example and the docs:

https://wiki.debian.org/debian/watch

debian/README.source is a copy of part of the upstream readme.md and is
not needed.

The static library normally isn't needed, please remove it unless
someone files a bug report asking for it to be added.

The pkg-config file doesn't appear to be installed in the package.
https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
how_to_build_for_mingw.txt is not relevant to Debian users, please drop
it from debian/docs.

changelog.txt should be installed with dh_installchangelogs rather than
dh_installdocs.

debian/copyright doesn't look like it conforms to the format. In
particular the licenses are missing dots on the blank lines. In
addition, you can avoid having two copies of the license by having one
license section separated from the files sections and have those files
sections refer to the files sections. The long lines of the license text
should also be wrapped.

http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

I wonder about the *.tga files in Samples/*invaders/data and
Samples/assets, some of them look like they might have other files (SVG
or similar) as their source. Please ask upstream to include the SVG or
other source in the tarball and have the build system create the *.tga
files at build time.

If the sample games are fun it might be interesting to make packages for
them. If not, their source could be included in an examples package.

Automatic checks:

https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
https://anonscm.debian.org/cgit/collab-maint/check-all-the-things.git

$ cme check dpkg
Warning in 'control source Build-Depends:0' value 'debhelper (= 8.0.0)': 
should be (= 9) not (= 8.0.0) because compat is 9
Warning in 'control source Standards-Version' value '3.9.4': Current standards 
version is 3.9.6
Warning in 'control binary:librocket-dev Depends:0' value 'librocket (= 
${binary:Version})': package 

Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-07 Thread whey bags
Thanks very much, I'll have a look at those issues soon. Re: pushing
upstream, I am an upstream maintainer, so it should be relatively painless.
On 7 Oct 2014 11:13, Paul Wise p...@debian.org wrote:

 On Mon, 2014-10-06 at 22:13 -0400, Harlan Lieberman-Berg wrote:

  Thanks for packaging librocket for Debian.  I've got a couple things for
  you to fix as the next steps.

 Good review Harlan, you missed some important things though, see below.

  2. Your changelog should close an ITP bug - in your case, #764252.

 You can do that by adding this in your changelog:

 (Closes: #764252)

  5. Your standards version isn't the latest version - you should update
  it to 3.9.6.

 Here is the list of changes since the last version:

 https://www.debian.org/doc/debian-policy/upgrading-checklist

  6. Your packages should have a short description and a longer
  description that should be enough information for a user to decide
  whether they want to install the package.  Check out Debian Policy 3.4
  for more details there.

 https://www.debian.org/doc/debian-policy/ch-binary.html#s-descriptions

 These issues block the upload of this package:

 The package fails to build for me:

  debian/rules build
 dh build --buildsystem=cmake --sourcedirectory=Build
dh_testdir -O--buildsystem=cmake -O--sourcedirectory=Build
debian/rules override_dh_auto_configure
 make[1]: Entering directory '/tmp/buildd/librocket-1.3'
 dh_auto_configure -- -DBUILD_PYTHON_BINDINGS=On
 -DCMAKE_INSTALL_LIBDIR=/usr/lib
 dh_auto_configure: cmake ../Build -DCMAKE_INSTALL_PREFIX=/usr
 -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None
 -DBUILD_PYTHON_BINDINGS=On -DCMAKE_INSTALL_LIBDIR=/usr/lib failed to to
 execute: No such file or directory
 debian/rules:11: recipe for target 'override_dh_auto_configure' failed
 make[1]: *** [override_dh_auto_configure] Error 2
 make[1]: Leaving directory '/tmp/buildd/librocket-1.3'
 debian/rules:8: recipe for target 'build' failed
 make: *** [build] Error 2

 The python package should be named python-rocket:


 https://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html#s-package_names

 The .so symlink should be installed in the -dev package.

 The library package should be named librocketN

 Please read the Debian policy sections on libraries:

 https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

 Some parts (in Samples/tutorial) of the upstream tarball do not have a
 clear license. The copyright holder is also different to the rest of the
 package. Some other parts (Samples/) have a DFSG-free license but a
 different copyright holder. The status should be clarified upstream, a
 DFSG-free license applied and the results documented in
 debian/copyright.

 The fonts in Samples/assets are under a non-free license and cannot be
 distributed in Debian main. Please ask upstream to remove them from the
 tarball and from their version control system. They can simply use
 font-family: sans-serif in invader.rcss instead.

 http://www.exljbris.com/delicious.html
 http://www.exljbris.com/eula.html

 Some other issues that you might want to correct:

 librocket.pc has an incorrect Version and Description.

 Please forward the patches upstream if appropriate.

 Please add a debian/watch file based on the example and the docs:

 https://wiki.debian.org/debian/watch

 debian/README.source is a copy of part of the upstream readme.md and is
 not needed.

 The static library normally isn't needed, please remove it unless
 someone files a bug report asking for it to be added.

 The pkg-config file doesn't appear to be installed in the package.
 https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
 how_to_build_for_mingw.txt is not relevant to Debian users, please drop
 it from debian/docs.

 changelog.txt should be installed with dh_installchangelogs rather than
 dh_installdocs.

 debian/copyright doesn't look like it conforms to the format. In
 particular the licenses are missing dots on the blank lines. In
 addition, you can avoid having two copies of the license by having one
 license section separated from the files sections and have those files
 sections refer to the files sections. The long lines of the license text
 should also be wrapped.

 http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

 I wonder about the *.tga files in Samples/*invaders/data and
 Samples/assets, some of them look like they might have other files (SVG
 or similar) as their source. Please ask upstream to include the SVG or
 other source in the tarball and have the build system create the *.tga
 files at build time.

 If the sample games are fun it might be interesting to make packages for
 them. If not, their source could be included in an examples package.

 Automatic checks:

 https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
 https://anonscm.debian.org/cgit/collab-maint/check-all-the-things.git

 $ cme check dpkg
 Warning in 'control source 

Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-06 Thread whey bags
Package: sponsorship-requests
  Severity: wishlist
  Dear mentors,

  I am looking for a sponsor for my package librocket

 * Package name: librocket
   Version : 1.3-1
   Upstream Author : CodePoint Ltd, Shift Technology Ltd, and contributors
 * URL : http://librocket.com
 * License : MIT
   Section : libdevel

  It builds those binary packages:

librocket  - User interface middleware package based HTML and CSS
 librocket-dev - librocket devel package
 librocket-python - librocket python support package

  To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/librocket


  Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/libr/librocket/librocket_1.3-1.dsc

  More information about hello can be obtained from http://www.example.com.

  Changes since the last upload:

Initial release


  Regards,
   Tom Mason


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#764261: RFS: librocket/1.3-1 [ITP]

2014-10-06 Thread Harlan Lieberman-Berg
Hi Tom!

Thanks for packaging librocket for Debian.  I've got a couple things for
you to fix as the next steps.

1. You should delete all of those .ex files in the debian directory.
Those are just examples of things that you might need to do.

2. Your changelog should close an ITP bug - in your case, #764252.

3. If you are using compat = 9 (which you should!), you need to depend
on debhelper = 9.

4. Your VCS fields contain a repository which doesn't exist.  You should
setup the collab-maint repository and push the packaging's git
repository there.

5. Your standards version isn't the latest version - you should update
it to 3.9.6.

6. Your packages should have a short description and a longer
description that should be enough information for a user to decide
whether they want to install the package.  Check out Debian Policy 3.4
for more details there.

7. Your patches are missing DEP-3 headers; check out the patch tagging
guidelines at http://dep.debian.net/deps/dep3/.

Lintian is a very helpful tool for finding some of these problems, and
has more than I detailed above, as well as some general warnings that
might point to bigger problems.  I recommend it highly; it's saved my
butt on many an occasion!

Thanks again for your help packaging librocket for Debian; when you've
got another upload that fixes the problems, send the bug a mail and
someone will swing by and take another look.

Sincerely,

-- 
Harlan Lieberman-Berg
~hlieberman


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org