Bug#765375: portmidi: diff for NMU version 1:184-2.2
tags 765375 + pending thanks Dear maintainer, I've prepared an NMU for portmidi (versioned as 1:184-2.2) and uploaded it to DELAYED/10. Please feel free to tell me if I should delay it longer. Regards. diff -u portmidi-184/debian/changelog portmidi-184/debian/changelog --- portmidi-184/debian/changelog +++ portmidi-184/debian/changelog @@ -1,3 +1,13 @@ +portmidi (1:184-2.2) unstable; urgency=medium + + * Non-maintainer upload. + * Disable PM_CHECK_ERRORS PortMidi as it is a debugging option which +unconditionally calls exit(-1) on any error. It should rather delegate +the responsibility of error handling to the client application. +Thanks to RJ Ryan for pointing this out. (Closes: #765375) + + -- Alessio Treglia ales...@debian.org Tue, 14 Oct 2014 16:12:56 +0100 + portmidi (1:184-2.1) unstable; urgency=low * Non-maintainer upload. diff -u portmidi-184/debian/patches/series portmidi-184/debian/patches/series --- portmidi-184/debian/patches/series +++ portmidi-184/debian/patches/series @@ -9,0 +10 @@ +12-disable_pmcheckerrors.patch only in patch2: unchanged: --- portmidi-184.orig/debian/patches/12-disable_pmcheckerrors.patch +++ portmidi-184/debian/patches/12-disable_pmcheckerrors.patch @@ -0,0 +1,22 @@ +Subject: Disable PM_CHECK_ERRORS +From: https://bugs.launchpad.net/debian/+source/portmidi/+bug/1097286 +Ubuntu-Bug: https://bugs.launchpad.net/debian/+source/portmidi/+bug/1097286 +Debian-Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=765375 +--- + pm_linux/Makefile |4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +--- portmidi-184.orig/pm_linux/Makefile portmidi-184/pm_linux/Makefile +@@ -16,9 +16,9 @@ + # simple to create.) + + # For debugging, define PM_CHECK_ERRORS +-PMFLAGS = -DPM_CHECK_ERRORS ++# PMFLAGS = -DPM_CHECK_ERRORS + # Otherwise do not define PM_CHECK_ERRORS +-# PMFLAGS = ++PMFLAGS = + + # Use this for linux alsa (0.9x) version + versions = pm_linux/pmlinuxalsa.o -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#765375: portmidi: diff for NMU version 1:184-2.2
gracias! :-) On 14/10/2014 17:23, Alessio Treglia wrote: tags 765375 + pending thanks Dear maintainer, I've prepared an NMU for portmidi (versioned as 1:184-2.2) and uploaded it to DELAYED/10. Please feel free to tell me if I should delay it longer. Regards. diff -u portmidi-184/debian/changelog portmidi-184/debian/changelog --- portmidi-184/debian/changelog +++ portmidi-184/debian/changelog @@ -1,3 +1,13 @@ +portmidi (1:184-2.2) unstable; urgency=medium + + * Non-maintainer upload. + * Disable PM_CHECK_ERRORS PortMidi as it is a debugging option which +unconditionally calls exit(-1) on any error. It should rather delegate +the responsibility of error handling to the client application. +Thanks to RJ Ryan for pointing this out. (Closes: #765375) + + -- Alessio Treglia ales...@debian.org Tue, 14 Oct 2014 16:12:56 +0100 + portmidi (1:184-2.1) unstable; urgency=low * Non-maintainer upload. diff -u portmidi-184/debian/patches/series portmidi-184/debian/patches/series --- portmidi-184/debian/patches/series +++ portmidi-184/debian/patches/series @@ -9,0 +10 @@ +12-disable_pmcheckerrors.patch only in patch2: unchanged: --- portmidi-184.orig/debian/patches/12-disable_pmcheckerrors.patch +++ portmidi-184/debian/patches/12-disable_pmcheckerrors.patch @@ -0,0 +1,22 @@ +Subject: Disable PM_CHECK_ERRORS +From: https://bugs.launchpad.net/debian/+source/portmidi/+bug/1097286 +Ubuntu-Bug: https://bugs.launchpad.net/debian/+source/portmidi/+bug/1097286 +Debian-Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=765375 +--- + pm_linux/Makefile |4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +--- portmidi-184.orig/pm_linux/Makefile portmidi-184/pm_linux/Makefile +@@ -16,9 +16,9 @@ + # simple to create.) + + # For debugging, define PM_CHECK_ERRORS +-PMFLAGS = -DPM_CHECK_ERRORS ++# PMFLAGS = -DPM_CHECK_ERRORS + # Otherwise do not define PM_CHECK_ERRORS +-# PMFLAGS = ++PMFLAGS = + + # Use this for linux alsa (0.9x) version + versions = pm_linux/pmlinuxalsa.o -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
