Bug#766000: RFS: id3lib3.8.3/3.8.3-16

2014-10-26 Thread Tobias Frost
(I do not intend to sponsor this package)

Stefan, 
your package does contain lintian warnings. Many sponsor will not even
look at your package with warnings present, so I advise you to fix them.

Thanks

--
tobi


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#766000: RFS: id3lib3.8.3/3.8.3-16

2014-10-26 Thread Stefan Ott
On 10/26/2014 01:43 PM, Tobias Frost wrote:
 (I do not intend to sponsor this package)
 
 Stefan, 
 your package does contain lintian warnings. Many sponsor will not even
 look at your package with warnings present, so I advise you to fix them.

Hi Tobias

Thanks for the advice. Most of the current lintian warnings are
pedantic or wishlist and some of them directly affect the build
process. Since this upload adds multi-arch support to the package I
didn't want to mess too much with other aspects of building the package
- I'd rather have just one major building-related change per package
revision, makes it a bit easier to find bugs.

Also, the warning about dev-pkg-without-shlib-symlink (which is the only
real complaint from lintian that I see) is IMHO not entirely correct.
lintian seems to expect a symlink called libid3-3.8.so while the
policy manual says The development package should contain a symlink for
the associated shared library without a version number. I'm assuming
that this is because the id3lib package has not seen an upstream release
in over a decade and we are carrying lots of packing-related information
in our version strings these days (such as the c2a from the C++ ABI
change in 2005). I could of course just add a lintian override and be
done with it but I figured it would be better to keep this warning
around as a reminder for me to look into the issue.

Anyway, I *did* upload a new version which fixes a small issue with the
previous upload and I'm looking forward to additional comments. If
anyone feels the urge to upload it that would be appreciated.

cheers
-- 
Stefan Ott
http://www.ott.net/



signature.asc
Description: OpenPGP digital signature


Bug#766000: RFS: id3lib3.8.3/3.8.3-16

2014-10-26 Thread Tobias Frost
Am Sonntag, den 26.10.2014, 15:34 +0100 schrieb Stefan Ott:
 On 10/26/2014 01:43 PM, Tobias Frost wrote:
  (I do not intend to sponsor this package)
  
  Stefan, 
  your package does contain lintian warnings. Many sponsor will not even
  look at your package with warnings present, so I advise you to fix them.
 
 Hi Tobias
 
 Thanks for the advice. Most of the current lintian warnings are
 pedantic or wishlist and some of them directly affect the build
 process. Since this upload adds multi-arch support to the package I
 didn't want to mess too much with other aspects of building the package
 - I'd rather have just one major building-related change per package
 revision, makes it a bit easier to find bugs.

pedantic There are no wishlist lintian messages /pedantic

 Also, the warning about dev-pkg-without-shlib-symlink (which is the only
 real complaint from lintian that I see) is IMHO not entirely correct.
 lintian seems to expect a symlink called libid3-3.8.so while the
 policy manual says The development package should contain a symlink for
 the associated shared library without a version number. I'm assuming
 that this is because the id3lib package has not seen an upstream release
 in over a decade and we are carrying lots of packing-related information
 in our version strings these days (such as the c2a from the C++ ABI
 change in 2005). I could of course just add a lintian override and be
 done with it but I figured it would be better to keep this warning
 around as a reminder for me to look into the issue.

I'm have doubts. I think lintian is right. You know what's your library
name and you know the version part? I'm not an library guru, but I think
the library name is libid3-3.8 and the version is 3.0.0, so lintian
expectd a symling from  usr/lib/x86_64-linux-gnu/libid3-3.8.so to
usr/lib/x86_64-linux-gnu/libid3-3.8.so.3.0.0 

For the other messages, at least P no-dep5-copyright are easily fixable
and dep5 is IMHO now considered as best-practice.

just my 2 cents.

 Anyway, I *did* upload a new version which fixes a small issue with the
 previous upload and I'm looking forward to additional comments. If
 anyone feels the urge to upload it that would be appreciated.
 
 cheers

--
tobi


signature.asc
Description: This is a digitally signed message part


Bug#766000: RFS: id3lib3.8.3/3.8.3-16

2014-10-26 Thread Stefan Ott
On 10/26/2014 06:13 PM, Tobias Frost wrote:
 
 pedantic There are no wishlist lintian messages /pedantic

Hmm, it says Severity: wishlist, Certainty: certain :)

Anyway

 I'm have doubts. I think lintian is right. You know what's your library
 name and you know the version part? I'm not an library guru, but I think
 the library name is libid3-3.8 and the version is 3.0.0, so lintian
 expectd a symling from  usr/lib/x86_64-linux-gnu/libid3-3.8.so to
 usr/lib/x86_64-linux-gnu/libid3-3.8.so.3.0.0 

You certainly have a point there, the file names are indeed a good
indicator. Yet libid3.so is the file name that upstream builds. If I
were to change it, would that not potentially lead to all kinds of
issues with other software that compiles against libid3?

 For the other messages, at least P no-dep5-copyright are easily fixable
 and dep5 is IMHO now considered as best-practice.

That is true, a new version with a dep5 copyright file has been uploaded.

cheers
-- 
Stefan Ott
http://www.ott.net/



signature.asc
Description: OpenPGP digital signature


Bug#766000: RFS: id3lib3.8.3/3.8.3-16

2014-10-20 Thread Stefan Ott
Package: sponsorship-requests
Severity: normal [important for RC bugs, wishlist for new packages]

Dear mentors,

I am looking for a sponsor for my package id3lib3.8.3

 * Package name: id3lib3.8.3
   Version : 3.8.3-16
   Upstream Author : Dirk Mahoney, Scott Thomas Haug
 * URL : http://id3lib.sourceforge.net/
 * License : LGPL-2
   Section : libs

It builds those binary packages:

* libid3-3.8.3-dev - ID3 Tag Library: Development Libraries and Header Files
* libid3-3.8.3c2a - library for manipulating ID3v1 and ID3v2 tags
* libid3-doc - ID3 Tag Library: Documentation
* libid3-tools - ID3 Tag Library: Utilities

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/id3lib3.8.3


Alternatively, one can download the package with dget using this command:

  dget -x
http://mentors.debian.net/debian/pool/main/i/id3lib3.8.3/id3lib3.8.3_3.8.3-16.dsc

Changes since the last upload:

* debian/patches:
  - Added 31-fix-utf16-stringlists.patch (closes: #680915)
  - Fixed typos in 20-create-manpages.patch (closes: #669875)
* Added multiarch support (closes: #723185)
* debian/control:
  - Removed DM-Upload-Allowed field
  - Updated Standards-Version to 3.9.6
  - Updated Vcs- fields to use canonical URIs
* Removed reference to remote icons from the HTML documentation
* Added lintian override for a false-positive spelling error
* Moved libid3.so symlink from the -dev package to the library package

Regards
-- 
Stefan Ott
http://www.ott.net/



signature.asc
Description: OpenPGP digital signature