Bug#767588: RFS: 2048/1.0-3 [ITP] Simple number game for the text console
* Gabriel Pérez-Cerezo gabr...@gpcf.eu, 2014-11-02, 21:46: I have uploaded a new version of the package that should fix the problems described in a previous email. You can see the new package's page at http://mentors.debian.net/package/2048. Direct link to dsc: https://mentors.debian.net/debian/pool/main/2/2048/2048_1.0-4.dsc Unfortunately, the package cannot be unpacked: $ dpkg-source -x 2048_1.0-4.dsc gpgv: Signature made 2014-11-02T20:27:14 CET using RSA key ID 84DDC536 gpgv: Can't check signature: public key not found dpkg-source: warning: failed to verify signature on ./2048_1.0-4.dsc dpkg-source: error: file ./2048_1.0.orig.tar.gz has size 5431 instead of expected 5581 My guess is that your *.changes files didn't include the .orig.tar (see the -si and -sa options for dpkg-genchanges), so mentors.d.n still has the old one. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#767588: RFS: 2048/1.0-3 [ITP] Simple number game for the text console
Hello Jakub, Thank you for looking at my code! I'm now trying to fix the errors. I will try to have it finished by tomorrow. Speaking of source, how was the .orig.tar generated? I don't see any tarballs on the upstream homepage. The tarball was generated with `make dist` on the source in the git repository. snprintf(color,length,\033[38;5;%d;48;5;%dm,*foreground,*background); This seems to work on all X terminal emulators that I have tried, maybe because they support 256 colors, but it doesn't work on the framebuffer. I will try to fix this. -- Gabriel Pérez-Cerezo Flohr .-- GPG Key: BB09BA34D353EC69 / Email is like a postcard, anyone can read Website: http://gpcf.eu / it. Please use the GPG Key to encrypt your Email: gabr...@gpcf.eu / emails (tutorial: emailselfdefense.fsf.org). -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#767588: RFS: 2048/1.0-3 [ITP] Simple number game for the text console
I have uploaded a new version of the package that should fix the problems described in a previous email. You can see the new package's page at http://mentors.debian.net/package/2048. -- Gabriel Pérez-Cerezo Flohr .-- GPG Key: BB09BA34D353EC69 / Email is like a postcard, anyone can read Website: http://gpcf.eu / it. Please use the GPG Key to encrypt your Email: gabr...@gpcf.eu / emails (tutorial: emailselfdefense.fsf.org). -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#767588: RFS: 2048/1.0-3 [ITP] Simple number game for the text console
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package 2048 * Package name: 2048 Version : 1.0-3 Upstream Author : Gabriel Pérez-Cerezo gabr...@gpcf.eu * URL : http://en.gpcf.eu/2048 * License : MIT Section : games It builds those binary packages: 2048 - Simple number game for the text console To access further information about this package, please visit the following URL: http://mentors.debian.net/package/2048 Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/2/2048/2048_1.0-3.dsc Changes since the last upload: none, this is my first upload. Regards, Gabriel Pérez-Cerezo -- Gabriel Pérez-Cerezo Flohr .-- GPG Key: BB09BA34D353EC69 / Email is like a postcard, anyone can read Website: http://gpcf.eu / it. Please use the GPG Key to encrypt your Email: gabr...@gpcf.eu / emails (tutorial: emailselfdefense.fsf.org). -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#767588: RFS: 2048/1.0-3 [ITP] Simple number game for the text console
Control: tags -1 + moreinfo [I don't intend to sponsor this package. Sorry!] * Gabriel Pérez-Cerezo gabr...@gpcf.eu, 2014-11-01, 11:32: http://mentors.debian.net/debian/pool/main/2/2048/2048_1.0-3.dsc Fun fact: we've had only one source package with a digit-only name so far: https://packages.qa.debian.org/3/3270.html The copyright file doesn't say where the source was downloaded from. This is serious violation of Policy §12.5. [The package should not be uploaded until this bug is fixed, so I'm tagging the bug +moreinfo.] Speaking of source, how was the .orig.tar generated? I don't see any tarballs on the upstream homepage. The License field in machine-readable copyright files use the same rules as the long description in a package's Description field in control files (see Policy §5.6.13). So the License texts should be indented by a single space, not two. The short licence name should be Expat, not MIT. The order of Files paragraphs in debian/copyright matters, and it's wrong in your file. More general paragraphs should be given first, followed by more specific overrides. It's better to put the license text into a stand-alone license paragraph than to include it twice. The extended package description is probably too short. if this is the initial release, why is the package revision 3? sid as distribution name in the changelog is fine, although it's customary to use unstable instead. blhc(1) says: CFLAGS missing (-g -O2 -fstack-protector-strong -Wformat -Werror=format-security): gcc 2048.c -o 2048 CPPFLAGS missing (-D_FORTIFY_SOURCE=2): gcc 2048.c -o 2048 LDFLAGS missing (-Wl,-z,relro): gcc 2048.c -o 2048 CFLAGS missing (-g -O2 -fstack-protector-strong -Wformat -Werror=format-security): gcc 2048.c -o 2048 CPPFLAGS missing (-D_FORTIFY_SOURCE=2): gcc 2048.c -o 2048 LDFLAGS missing (-Wl,-z,relro): gcc 2048.c -o 2048 I'm not sure how is this supposed to work: snprintf(color,length,\033[38;5;%d;48;5;%dm,*foreground,*background); console_codes(4) says that 38 is set underscore on, set default foreground color, 5 is set blink, and 48 is not documented. In any case, the result it quite horrible here (wheezy kernel, fbcon, 512 character font; see the attachment). There's a buffer overflow for very long HOME: $ HOME=/$(perl -E'say xx4242') 2048 Segmentation fault NB, some of the problems above are detected by Lintian: I: 2048 source: unused-file-paragraph-in-dep5-copyright paragraph at line 4 W: 2048: hardening-no-relro usr/games/2048 I: 2048: hardening-no-fortify-functions usr/games/2048 I: 2048: extended-description-is-probably-too-short -- Jakub Wilk
