Bug#767819: bareos-*: modifies conffiles (policy 10.7.3): /etc/bareos/bareos-*.conf

2014-11-04 Thread Joerg Steffens
 I would upload in my lunch-break if you do not object ;)

Certainly. Please go ahead.

regards,
Jörg


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#767819: bareos-*: modifies conffiles (policy 10.7.3): /etc/bareos/bareos-*.conf

2014-11-03 Thread Jörg Steffens



thank you for this detailed information.
Bareos only substitutes template variables on initial installation (or
the database backend if somebody reconfigures dbconfig-common).

I'll change the behavior, so that the template configuration files get
installed to /usr/share/bareos... and copied to /etc/bareos/ during
postinst, if the config file do not already exist.

This will take a while, because the current behavior must continue to
work for other plattforms (eg. RPM based).

Jörg


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#767819: [Pkg-bareos-devel] Bug#767819: bareos-*: modifies conffiles (policy 10.7.3): /etc/bareos/bareos-*.conf

2014-11-03 Thread Evgeni Golov
Hi Joerg,

On 11/03/2014 11:33 AM, Jörg Steffens wrote:

 thank you for this detailed information.
 Bareos only substitutes template variables on initial installation (or
 the database backend if somebody reconfigures dbconfig-common).
 
 I'll change the behavior, so that the template configuration files get
 installed to /usr/share/bareos... and copied to /etc/bareos/ during
 postinst, if the config file do not already exist.
 
 This will take a while, because the current behavior must continue to
 work for other plattforms (eg. RPM based).

I have a half-working patch on my disk for that. You might want to try
that as a base, I'll push it to git soon and let you know.

Greets
Evgeni


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#767819: [Pkg-bareos-devel] Bug#767819: Bug#767819: bareos-*: modifies conffiles (policy 10.7.3): /etc/bareos/bareos-*.conf

2014-11-03 Thread Evgeni Golov
Hi,

On Mon, Nov 03, 2014 at 12:16:24PM +0100, Evgeni Golov wrote:

 I have a half-working patch on my disk for that. You might want to try
 that as a base, I'll push it to git soon and let you know.

How about that?
https://github.com/credativ/bareos/commit/a3817bfc181cbe9352e2b9c7f52e125f598bcbae

Greets
Evgeni

-- 
Bruce Schneier can read and understand Perl programs.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#767819: [Pkg-bareos-devel] Bug#767819: Bug#767819: bareos-*: modifies conffiles (policy 10.7.3): /etc/bareos/bareos-*.conf

2014-11-03 Thread Jörg Steffens
Am 03.11.2014 18:29, schrieb Evgeni Golov:
 Hi,
 
 On Mon, Nov 03, 2014 at 12:16:24PM +0100, Evgeni Golov wrote:
 
 I have a half-working patch on my disk for that. You might want to try
 that as a base, I'll push it to git soon and let you know.
 
 How about that?
 https://github.com/credativ/bareos/commit/a3817bfc181cbe9352e2b9c7f52e125f598bcbae

looks very good.
From my point of view, this fixes the problem.

Jörg


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#767819: bareos-*: modifies conffiles (policy 10.7.3): /etc/bareos/bareos-*.conf

2014-11-03 Thread Evgeni Golov
On 11/04/2014 12:43 AM, Jörg Steffens wrote:

 How about that?
 https://github.com/credativ/bareos/commit/a3817bfc181cbe9352e2b9c7f52e125f598bcbae
 
 looks very good.
 From my point of view, this fixes the problem.

Thanks for the review!

I have added a few postrm scripts to remove the configs when the package
is purged:
https://github.com/credativ/bareos/commit/2a76988eced8a56972801787f3dd77ee6410c7b2

I would upload in my lunch-break if you do not object ;)

Greets
Evgeni


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#767819: bareos-*: modifies conffiles (policy 10.7.3): /etc/bareos/bareos-*.conf

2014-11-02 Thread Andreas Beckmann
Package: bareos
Version: 14.2.1+20141017gitc6c5b56-2
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package modifies conffiles.
This is forbidden by the policy, see
http://www.debian.org/doc/debian-policy/ch-files.html#s-config-files

10.7.3: [...] The easy way to achieve this behavior is to make the
configuration file a conffile. [...] This implies that the default
version will be part of the package distribution, and must not be
modified by the maintainer scripts during installation (or at any
other time).

Note that once a package ships a modified version of that conffile,
dpkg will prompt the user for an action how to handle the upgrade of
this modified conffile (that was not modified by the user).

Further in 10.7.3: [...] must not ask unnecessary questions
(particularly during upgrades) [...]

If a configuration file is customized by a maintainer script after
having asked some debconf questions, it may not be marked as a
conffile. Instead a template could be installed in /usr/share and used
by the postinst script to fill in the custom values and create (or
update) the configuration file (preserving any user modifications!).
This file must be removed during postrm purge.
ucf(1) may help with these tasks.
See also http://wiki.debian.org/DpkgConffileHandling

In https://lists.debian.org/debian-devel/2012/09/msg00412.html and
followups it has been agreed that these bugs are to be filed with
severity serious.

debsums reports modification of the following files,
from the attached log (scroll to the bottom...):

  /etc/bareos/bareos-dir.conf

and from other tests

  /etc/bareos/bareos-sd.conf
  /etc/bareos/bconsole.conf
  /etc/bareos/bareos-fd.conf
  /etc/bareos/bat.conf
  /etc/bareos/tray-monitor.conf


cheers,

Andreas


bareos-director_14.2.1+20141017gitc6c5b56-2.log.gz
Description: application/gzip