Bug#768275: python-whoosh-doc: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE
On Sun, Nov 16, 2014 at 02:53:30AM +, Jean-Michel Nirgal Vourgère wrote: I've prepared a patch for that RC bug. As part of a BSP in Paris, I may get an delayed NMU sponsored tomorrow. Please fell free to tell me if you'd like to handle the matter yourself. ---end quoted text--- Thanks a lot for your patch. I've uploaded it right now. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7 signature.asc Description: Digital signature
Bug#768275: python-whoosh-doc: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE
Control: tags -1 patch
Dear maintainer,
I've prepared a patch for that RC bug. As part of a BSP in Paris, I may
get an delayed NMU sponsored tomorrow. Please fell free to tell me if
you'd like to handle the matter yourself.
Note that version in maintscript need to be changed in that case.
Regards.
--
Nirgal
diff -Nru python-whoosh-2.5.7/debian/changelog python-whoosh-2.5.7/debian/changelog
--- python-whoosh-2.5.7/debian/changelog 2014-08-26 17:25:14.0 +
+++ python-whoosh-2.5.7/debian/changelog 2014-11-15 22:09:29.0 +
@@ -1,3 +1,16 @@
+python-whoosh (2.5.7-2.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Change python-whoosh.maintscript into python-whoosh-doc.maintscript:
+/usr/share/doc/python-whoosh-doc was a link to python-whoosh. Fixed
+'prior-version' as the current one, see dpkg-maintscript-helper(1). Drop
+optional 'package' since where are not using maintscript but
+python-whoosh-doc.maintscript. Drop unused Pre-Depends on dpkg with support
+of symlink_to_dir, added missing Pre-Depends on misc:Pre-Depends in
+python-whoosh-doc (Closes: #768275).
+
+ -- Jean-Michel Nirgal Vourgère jmv_...@nirgal.com Sat, 15 Nov 2014 22:09:21 +
+
python-whoosh (2.5.7-2) unstable; urgency=medium
[ Zygmunt Krynicki ]
diff -Nru python-whoosh-2.5.7/debian/control python-whoosh-2.5.7/debian/control
--- python-whoosh-2.5.7/debian/control 2014-08-26 17:25:14.0 +
+++ python-whoosh-2.5.7/debian/control 2014-11-15 22:05:28.0 +
@@ -13,7 +13,6 @@
Package: python-whoosh
Architecture: all
-Pre-Depends: dpkg (= 1.17.5)
Depends: ${python:Depends}, ${misc:Depends}
Suggests: python-whoosh-doc
Description: pure-Python full-text indexing, search, and spell checking library (Python 2)
@@ -29,7 +28,6 @@
Package: python3-whoosh
Architecture: all
-Pre-Depends: dpkg (= 1.17.5)
Depends: ${python3:Depends}, ${misc:Depends}
Suggests: python-whoosh-doc
Description: pure-Python full-text indexing, search, and spell checking library (Python 3)
@@ -47,6 +45,7 @@
Architecture: all
Section: doc
Priority: extra
+Pre-Depends: ${misc:Pre-Depends}
Depends: ${misc:Depends}, ${sphinxdoc:Depends}
Replaces: python-whoosh ( 2.1.0)
Description: full-text indexing, search, and spell checking library (doc)
diff -Nru python-whoosh-2.5.7/debian/python-whoosh-doc.maintscript python-whoosh-2.5.7/debian/python-whoosh-doc.maintscript
--- python-whoosh-2.5.7/debian/python-whoosh-doc.maintscript 1970-01-01 00:00:00.0 +
+++ python-whoosh-2.5.7/debian/python-whoosh-doc.maintscript 2014-11-15 21:57:10.0 +
@@ -0,0 +1 @@
+symlink_to_dir /usr/share/doc/python-whoosh-doc python-whoosh 2.5.7-2.1~
diff -Nru python-whoosh-2.5.7/debian/python-whoosh.maintscript python-whoosh-2.5.7/debian/python-whoosh.maintscript
--- python-whoosh-2.5.7/debian/python-whoosh.maintscript 2014-08-26 17:25:14.0 +
+++ python-whoosh-2.5.7/debian/python-whoosh.maintscript 1970-01-01 00:00:00.0 +
@@ -1 +0,0 @@
-symlink_to_dir /usr/share/doc/python-whoosh /usr/share/doc/python-whoosh-doc 2.4.1-1~ python-whoosh
signature.asc
Description: OpenPGP digital signature
Bug#768275: python-whoosh-doc: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE
Package: python-whoosh-doc Version: 2.5.7-2 Severity: serious User: debian...@lists.debian.org Usertags: piuparts Hi, an upgrade test with piuparts revealed that your package installs files over existing symlinks and possibly overwrites files owned by other packages. This usually means an old version of the package shipped a symlink but that was later replaced by a real (and non-empty) directory. This kind of overwriting another package's files cannot be detected by dpkg. This was observed on the following upgrade paths: wheezy - jessie For /usr/share/doc/PACKAGE this may not be problematic as long as both packages are installed, ship byte-for-byte identical files and are upgraded in lockstep. But once one of the involved packages gets removed, the other one will lose its documentation files, too, including the copyright file, which is a violation of Policy 12.5: http://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile For other overwritten locations anything interesting may happen. Note that dpkg intentionally does not replace directories with symlinks and vice versa, you need the maintainer scripts to do this. See in particular the end of point 4 in http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase It is recommended to use the dpkg-maintscript-helper commands 'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.2) to perform the conversion, ideally using d/$PACKAGE.mainstscript. See dpkg-maintscript-helper(1) and dh_installdeb(1) for details. From the attached log (usually somewhere in the middle...): 1m0.9s ERROR: FAIL: silently overwrites files via directory symlinks: /usr/share/doc/python-whoosh-doc/NEWS.Debian.gz (python-whoosh-doc) != /usr/share/doc/python-whoosh/NEWS.Debian.gz (python-whoosh) /usr/share/doc/python-whoosh-doc/changelog.Debian.gz (python-whoosh-doc) != /usr/share/doc/python-whoosh/changelog.Debian.gz (python-whoosh) /usr/share/doc/python-whoosh-doc/copyright (python-whoosh-doc) != /usr/share/doc/python-whoosh/copyright (python-whoosh) /usr/share/doc/python-whoosh-doc/html (python-whoosh-doc) != /usr/share/doc/python-whoosh/html (?) /usr/share/doc/python-whoosh-doc/html/_sources (python-whoosh-doc) != /usr/share/doc/python-whoosh/html/_sources (?) /usr/share/doc/python-whoosh-doc/html/_sources/analysis.txt (python-whoosh-doc) != /usr/share/doc/python-whoosh/html/_sources/analysis.txt (?) /usr/share/doc/python-whoosh-doc/html/_sources/api (python-whoosh-doc) != /usr/share/doc/python-whoosh/html/_sources/api (?) /usr/share/doc/python-whoosh-doc/html/_sources/api/analysis.txt (python-whoosh-doc) != /usr/share/doc/python-whoosh/html/_sources/api/analysis.txt (?) /usr/share/doc/python-whoosh-doc/html/tech (python-whoosh-doc) != /usr/share/doc/python-whoosh/html/tech (?) /usr/share/doc/python-whoosh-doc/html/tech/backend.html (python-whoosh-doc) != /usr/share/doc/python-whoosh/html/tech/backend.html (?) /usr/share/doc/python-whoosh-doc/html/tech/filedb.html (python-whoosh-doc) != /usr/share/doc/python-whoosh/html/tech/filedb.html (?) /usr/share/doc/python-whoosh-doc/html/tech/index.html (python-whoosh-doc) != /usr/share/doc/python-whoosh/html/tech/index.html (?) /usr/share/doc/python-whoosh-doc/html/threads.html (python-whoosh-doc) != /usr/share/doc/python-whoosh/html/threads.html (?) cheers, Andreas python-whoosh-doc_2.5.7-2.log.gz Description: application/gzip
Bug#768275: python-whoosh-doc: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE
On Thu, Nov 06, 2014 at 09:32:21AM +0100, Andreas Beckmann wrote: It is recommended to use the dpkg-maintscript-helper commands 'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.2) to perform the conversion, ideally using d/$PACKAGE.mainstscript. See dpkg-maintscript-helper(1) and dh_installdeb(1) for details. ---end quoted text--- I thought that I have fixed this already by adding: debian/python-whoosh.maintscript with the following line: symlink_to_dir /usr/share/doc/python-whoosh /usr/share/doc/python-whoosh-doc 2.4.1-1~ python-whoosh So why isn't that working ? -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7 signature.asc Description: Digital signature
Bug#768275: python-whoosh-doc: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE
On 2014-11-06 10:11, أحمد المحمودي wrote: I thought that I have fixed this already by adding: debian/python-whoosh.maintscript with the following line: symlink_to_dir /usr/share/doc/python-whoosh /usr/share/doc/python-whoosh-doc 2.4.1-1~ python-whoosh So why isn't that working ? Please follow the discussion at https://bugs.debian.org/768245, seems to be the same problem there. In the worst case there are quite a few packages implementing this in the wrong way: https://piuparts.debian.org/wheezy2jessie/installs_over_symlink_issue.html Andreas -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
