Bug#768285: python-pyvorbis-dbg: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE
Hello, Please check your override_dh_installdocs target in debian/rules. May be removing the duplicates would be enough? yes, that's the right fix; uploading it in a few minutes. Regards, -- Sandro Tosi (aka morph, morpheus, matrixhasu) My website: http://matrixhasu.altervista.org/ Me at Debian: http://wiki.debian.org/SandroTosi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#768285: python-pyvorbis-dbg: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE
Hello, thanks for the patch, but... On Sun, Nov 16, 2014 at 3:50 AM, Jean-Michel Nirgal Vourgère jmv_...@nirgal.com wrote: I've prepared a patch for that RC bug. As part of a BSP in Paris, I may get an delayed NMU sponsored tomorrow. Please fell free to tell me if you'd like to handle the matter yourself. Note that version in maintscript need to be changed in that case. ...this patch basically replace the symlink with a directory (as you can verify installing the package in a system where no pyvorbis package was present) which is against what I wanted to achieve, so have the -dbg package have a doc dir symlinked to python-pyvorbis doc dir. if you want to NMU then I guess you want to address the problem above. Regards, -- Sandro Tosi (aka morph, morpheus, matrixhasu) My website: http://matrixhasu.altervista.org/ Me at Debian: http://wiki.debian.org/SandroTosi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#768285: python-pyvorbis-dbg: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE
Sandro Tosi: Hello, thanks for the patch, but... On Sun, Nov 16, 2014 at 3:50 AM, Jean-Michel Nirgal Vourgère I've prepared a patch for that RC bug. As part of a BSP in Paris, I may get an delayed NMU sponsored tomorrow. Please fell free to tell me if you'd like to handle the matter yourself. Note that version in maintscript need to be changed in that case. ...this patch basically replace the symlink with a directory (as you can verify installing the package in a system where no pyvorbis package was present) which is against what I wanted to achieve, so have the -dbg package have a doc dir symlinked to python-pyvorbis doc dir. if you want to NMU then I guess you want to address the problem above. Regards, Hello The patch does *not* replace the link by a directory. Wheezy version of python-pyvorbis-dbg was having a link: /usr/share/doc/python-pyvorbis-dbg - python-pyvorbis Version actually in jessie is having a full copy, the upgrade script does not remove the link. This results in python-pyvorbis-dbg overwriting (duplicate) files in python-pyvorbis, hence the release critical severity. That patch is only addressing that issue. Try to install a fresh version of your package on testing, you'll see :) Please check your override_dh_installdocs target in debian/rules. May be removing the duplicates would be enough? The NMU is delayed and will automatically be uploaded in unstable in 5 days. If you fell you need more time to resolve that bug in the way you want, please send an email to Frederic Peters cc'ed of that email. Jessie will not be reached after 5? more days (priority medium) + an unblock bug filled against release.debian.org. Still, it's messy to move links around, and it might be better if it never reach unstable, if you to put the link back. Regards. -- Nirgal signature.asc Description: OpenPGP digital signature
Bug#768285: python-pyvorbis-dbg: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE
Control: tags -1 patch
Dear maintainer,
I've prepared a patch for that RC bug. As part of a BSP in Paris, I may
get an delayed NMU sponsored tomorrow. Please fell free to tell me if
you'd like to handle the matter yourself.
Note that version in maintscript need to be changed in that case.
Regards.
--
Nirgal
diff -Nru pyvorbis-1.5/debian/changelog pyvorbis-1.5/debian/changelog
--- pyvorbis-1.5/debian/changelog 2014-02-22 17:57:23.0 +
+++ pyvorbis-1.5/debian/changelog 2014-11-16 03:32:24.0 +
@@ -1,3 +1,12 @@
+pyvorbis (1.5-3.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix python-pyvorbis-dbg symlink to dir (Closes: #768285)
+- New python-pyvorbis-dbg.maintscript
+- control: python-pyvorbis-dbg: Added ${misc:Pre-Depends}.
+
+ -- Jean-Michel Nirgal Vourgère jmv_...@nirgal.com Sun, 16 Nov 2014 03:32:13 +
+
pyvorbis (1.5-3) unstable; urgency=low
[ Jakub Wilk ]
diff -Nru pyvorbis-1.5/debian/control pyvorbis-1.5/debian/control
--- pyvorbis-1.5/debian/control 2014-02-22 17:48:48.0 +
+++ pyvorbis-1.5/debian/control 2014-11-16 03:30:34.0 +
@@ -25,6 +25,7 @@
Priority: extra
Section: debug
Architecture: any
+Pre-Depends: ${misc:Pre-Depends}
Depends: ${misc:Depends}, python-pyvorbis (= ${binary:Version}), python-dbg, python-ogg-dbg, ${shlibs:Depends}
Description: Python interface to the Ogg Vorbis library (debug extension)
This module makes the libvorbis (Ogg Vorbis) functions available
diff -Nru pyvorbis-1.5/debian/python-pyvorbis-dbg.maintscript pyvorbis-1.5/debian/python-pyvorbis-dbg.maintscript
--- pyvorbis-1.5/debian/python-pyvorbis-dbg.maintscript 1970-01-01 00:00:00.0 +
+++ pyvorbis-1.5/debian/python-pyvorbis-dbg.maintscript 2014-11-16 03:32:10.0 +
@@ -0,0 +1 @@
+symlink_to_dir /usr/share/doc/python-pyvorbis-dbg python-pyvorbis 1.5-3.1~
signature.asc
Description: OpenPGP digital signature
Bug#768285: python-pyvorbis-dbg: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE
Package: python-pyvorbis-dbg Version: 1.5-3 Severity: serious User: debian...@lists.debian.org Usertags: piuparts Hi, an upgrade test with piuparts revealed that your package installs files over existing symlinks and possibly overwrites files owned by other packages. This usually means an old version of the package shipped a symlink but that was later replaced by a real (and non-empty) directory. This kind of overwriting another package's files cannot be detected by dpkg. This was observed on the following upgrade paths: wheezy - jessie For /usr/share/doc/PACKAGE this may not be problematic as long as both packages are installed, ship byte-for-byte identical files and are upgraded in lockstep. But once one of the involved packages gets removed, the other one will lose its documentation files, too, including the copyright file, which is a violation of Policy 12.5: http://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile For other overwritten locations anything interesting may happen. Note that dpkg intentionally does not replace directories with symlinks and vice versa, you need the maintainer scripts to do this. See in particular the end of point 4 in http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase It is recommended to use the dpkg-maintscript-helper commands 'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.2) to perform the conversion, ideally using d/$PACKAGE.mainstscript. See dpkg-maintscript-helper(1) and dh_installdeb(1) for details. From the attached log (usually somewhere in the middle...): 1m14.2s ERROR: FAIL: silently overwrites files via directory symlinks: /usr/share/doc/python-ogg-dbg/changelog.Debian.gz (python-ogg-dbg) != /usr/share/doc/python-ogg/changelog.Debian.gz (python-ogg) /usr/share/doc/python-ogg-dbg/changelog.gz (python-ogg-dbg) != /usr/share/doc/python-ogg/changelog.gz (python-ogg) /usr/share/doc/python-ogg-dbg/copyright (python-ogg-dbg) != /usr/share/doc/python-ogg/copyright (python-ogg) /usr/share/doc/python-pyvorbis-dbg/changelog.Debian.gz (python-pyvorbis-dbg) != /usr/share/doc/python-pyvorbis/changelog.Debian.gz (python-pyvorbis) /usr/share/doc/python-pyvorbis-dbg/changelog.gz (python-pyvorbis-dbg) != /usr/share/doc/python-pyvorbis/changelog.gz (python-pyvorbis) /usr/share/doc/python-pyvorbis-dbg/copyright (python-pyvorbis-dbg) != /usr/share/doc/python-pyvorbis/copyright (python-pyvorbis) cheers, Andreas python-pyvorbis-dbg_1.5-3.log.gz Description: application/gzip
