Bug#769327: jansson doc needlessly Depends on libjs-backbone

[Alessandro Ghedini]

Control: tags -1 pending

On mer, nov 12, 2014 at 03:59:49 -0500, Mathieu Trudel-Lapierre wrote:
> Package: jansson
> Version: 2.7-1
> Severity: minor
> Tags: patch
> User: ubuntu-de...@lists.ubuntu.com
> Usertags: origin-ubuntu vivid ubuntu-patch
> 
> Dear Maintainer,
> 
> When looking at the Depends for each of the binary packages shipped by the
> jansson source, I noticed libjs-backbone. This package sticked out in Ubuntu
> because it's the only package that wasn't in the "main" component.
> 
> I dug in a bit more, and while trying to see if libjs-backbone was really
> required I noticed it's not used anywhere by the documentation itself; unlike
> other depends (jquery, etc.), it's not sourced by the html at all; a quick
> grep for "backbone" in /usr/share/doc/libjansson-doc/ proves this.
> 
> This made me conclude that while libjs-backbone may have been required before,
> it is no longer a requirement in version 2.7, and may thus be removed so as
> not to install additional packages for no reason.

Right, I just pushed a fix to git. Basically I enabled the dh_sphinxdoc helper
script, which automatically creates the symlinks and generates the necessay
dependencies so that we don't have to do it manually.

Cheers


signature.asc
Description: Digital signature

Bug#769327: jansson doc needlessly Depends on libjs-backbone

[Mathieu Trudel-Lapierre]

Package: jansson
Version: 2.7-1
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu vivid ubuntu-patch

Dear Maintainer,

When looking at the Depends for each of the binary packages shipped by the
jansson source, I noticed libjs-backbone. This package sticked out in Ubuntu
because it's the only package that wasn't in the "main" component.

I dug in a bit more, and while trying to see if libjs-backbone was really
required I noticed it's not used anywhere by the documentation itself; unlike
other depends (jquery, etc.), it's not sourced by the html at all; a quick
grep for "backbone" in /usr/share/doc/libjansson-doc/ proves this.

This made me conclude that while libjs-backbone may have been required before,
it is no longer a requirement in version 2.7, and may thus be removed so as
not to install additional packages for no reason.

Thanks!

*** /tmp/tmpfvbS6m/bug_body

In Ubuntu, the attached patch was applied to achieve the following:

  * Don't pull in libjs-backbone (LP: #1392025)
- debian/control: don't have libjansson-doc Depends on libjs-backbone.
- debian/libjansson-doc.links: don't add links to backbone.js.


Thanks for considering the patch.


-- System Information:
Debian Release: jessie/sid
  APT prefers vivid-updates
  APT policy: (500, 'vivid-updates'), (500, 'vivid-security'), (500, 'vivid'), 
(100, 'vivid-proposed'), (100, 'vivid-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-24-generic (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
=== modified file 'debian/changelog'

=== modified file 'debian/control'
--- a/debian/control	2013-12-22 15:31:36 +
+++ b/debian/control	2014-11-12 20:41:56 +
@@ -45,7 +46,6 @@ Package: libjansson-doc
 Section: doc
 Architecture: all
 Depends: ${misc:Depends},
- libjs-backbone,
  libjs-jquery,
  libjs-underscore,
  libjs-sphinxdoc (>= 1.0)

=== modified file 'debian/libjansson-doc.links'
--- a/debian/libjansson-doc.links	2012-01-27 21:54:54 +
+++ b/debian/libjansson-doc.links	2014-11-12 19:26:32 +
@@ -1,3 +1,2 @@
 /usr/share/javascript/jquery/jquery.js /usr/share/doc/libjansson-doc/html/_static/jquery.js
 /usr/share/javascript/underscore/underscore.js /usr/share/doc/libjansson-doc/html/_static/underscore.js
-/usr/share/javascript/backbone/backbone.js /usr/share/doc/libjansson-doc/html/_static/backbone.js