Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-29 Thread Niels Thykier 
reopen 770414
tags 770414 = moreinfo
thanks

On 2014-11-23 17:57, Cyril Brulebois wrote:
 Niels Thykier ni...@thykier.net (2014-11-21):
 [...]
 
 You might have noticed that already, but anyway: gtk+3.0 is waiting on
 glib2.0, which was lacking a build on ppc64el. A give back later, it
 finally built there, but you'll still need to review/unblock it.
 
 Mraw,
 KiBi.
 

Thanks for spotting that.

GTK cannot migrate without glib2.0 as well.  I have reviewed the diff
and is mostly ready to accept it /provided/ that someone can clarify the
following:


 diff -Nru glib2.0-2.42.0/gio/gdbus-2.0/codegen/config.py 
 glib2.0-2.42.1/gio/gdbus-2.0/codegen/config.py
 --- glib2.0-2.42.0/gio/gdbus-2.0/codegen/config.py  2014-09-22 
 17:18:16.0 +
 +++ glib2.0-2.42.1/gio/gdbus-2.0/codegen/config.py  2014-11-09 
 23:20:38.0 +
 @@ -21,5 +21,5 @@
  
  DATADIR = ${prefix}/share
  DATADIR = DATADIR.replace(
 -${prefix}, /usr/local)
 -VERSION = 2.42.0
 +${prefix}, /home/mclasen/gnome)
 +VERSION = 2.42.1

Is the above going to be an issue/break stuff?

 diff -Nru glib2.0-2.42.0/gio/gioenums.h glib2.0-2.42.1/gio/gioenums.h
 --- glib2.0-2.42.0/gio/gioenums.h   2014-09-22 13:42:12.0 +
 +++ glib2.0-2.42.1/gio/gioenums.h   2014-10-02 18:02:20.0 +
 [...]
 @@ -1377,9 +1377,9 @@
G_CREDENTIALS_TYPE_INVALID,
G_CREDENTIALS_TYPE_LINUX_UCRED,
G_CREDENTIALS_TYPE_FREEBSD_CMSGCRED,
 -  G_CREDENTIALS_TYPE_NETBSD_UNPCBID,
G_CREDENTIALS_TYPE_OPENBSD_SOCKPEERCRED,
 -  G_CREDENTIALS_TYPE_SOLARIS_UCRED
 +  G_CREDENTIALS_TYPE_SOLARIS_UCRED,
 +  G_CREDENTIALS_TYPE_NETBSD_UNPCBID
  } GCredentialsType;
  
  /**

Is this a public enum with values re-ordered for no apparent reason (and
possibly breaking ABI)?

~Niels


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-29 Thread Andreas Henriksson 
Hello Niels!

I'd be more then happy if someone else could answer your questions
but I'll make an attempt at filling in some information here
just in case noone else steps up.

On Sat, Nov 29, 2014 at 10:48:06AM +0100, Niels Thykier wrote:
[...]
  diff -Nru glib2.0-2.42.0/gio/gdbus-2.0/codegen/config.py 
  glib2.0-2.42.1/gio/gdbus-2.0/codegen/config.py
  --- glib2.0-2.42.0/gio/gdbus-2.0/codegen/config.py  2014-09-22 
  17:18:16.0 +
  +++ glib2.0-2.42.1/gio/gdbus-2.0/codegen/config.py  2014-11-09 
  23:20:38.0 +
  @@ -21,5 +21,5 @@
   
   DATADIR = ${prefix}/share
   DATADIR = DATADIR.replace(
  -${prefix}, /usr/local)
  -VERSION = 2.42.0
  +${prefix}, /home/mclasen/gnome)
  +VERSION = 2.42.1
 
 Is the above going to be an issue/break stuff?

The above is a generated file built from config.py.in, so should not be
any issue here.

 
  diff -Nru glib2.0-2.42.0/gio/gioenums.h glib2.0-2.42.1/gio/gioenums.h
  --- glib2.0-2.42.0/gio/gioenums.h   2014-09-22 13:42:12.0 +
  +++ glib2.0-2.42.1/gio/gioenums.h   2014-10-02 18:02:20.0 +
  [...]
  @@ -1377,9 +1377,9 @@
 G_CREDENTIALS_TYPE_INVALID,
 G_CREDENTIALS_TYPE_LINUX_UCRED,
 G_CREDENTIALS_TYPE_FREEBSD_CMSGCRED,
  -  G_CREDENTIALS_TYPE_NETBSD_UNPCBID,
 G_CREDENTIALS_TYPE_OPENBSD_SOCKPEERCRED,
  -  G_CREDENTIALS_TYPE_SOLARIS_UCRED
  +  G_CREDENTIALS_TYPE_SOLARIS_UCRED,
  +  G_CREDENTIALS_TYPE_NETBSD_UNPCBID
   } GCredentialsType;
   
   /**
 
 Is this a public enum with values re-ordered for no apparent reason (and
 possibly breaking ABI)?

Yes, except the for no apparent reason part.

The introduction of NetBSD support caused an ABI breakage, this simply
reverts to the old ABI. This likely does not affect us at all though
(since it involves NetBSD, OpenBSD and Solaris).

Regards,
Andreas Henriksson


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-23 Thread Cyril Brulebois 
Niels Thykier ni...@thykier.net (2014-11-21):
 On 2014-11-21 18:19, Andreas Henriksson wrote:
  Hello again!
  
  Heavily filtered debdiff included 
  
  debdiff *.dsc | filterdiff -x '*/build/win32/*' -x '*/*/*.po' -x 
  '*/gdk/quartz/*' -x '*/docs/*' -x '*/INSTALL' -x '*/README' -x 
  '*/build/*msvc*' -x '*/*win32' -x '*/gdk/win32/rc/gdk.rc' -x '*/configure' 
  -x '*/*/*.pot' -x '*/gdk/broadway/*.h' -x '*/gtk/gtkresources.c' -x 
  '*/gtk/resources/*' -x '*/gtk/gtkversion.h' -x '*/gdk/gdkversionmacros.h' 
  -x '*/debian/control' -x '*/debian/patches/*' -x '*/gtk/gtkmenu.c'
  
  Summary of what was filtered out:
   - ms windows related changes
   - quartz (osx) related changes
   - built/autogenerated noise (eg. version number bump related, etc.)
   - css fixes in default adwaita theme
   - changes for previously shipped debian/patch now merged upstream.
   - translations
  
  [...]
 
 Unblocked, thanks.

You might have noticed that already, but anyway: gtk+3.0 is waiting on
glib2.0, which was lacking a build on ppc64el. A give back later, it
finally built there, but you'll still need to review/unblock it.

Mraw,
KiBi.


signature.asc
Description: Digital signature

Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-21 Thread Andreas Henriksson 
Hello!

On Fri, Nov 21, 2014 at 05:51:36AM +, Adam D. Barratt wrote:
 Control: tags -1 + moreinfo
[...]
 That would need someone to provide the information requested in
 https://release.debian.org/jessie/freeze_policy.html#getting-unblocks

Matt is aware of this information already. Hopefully he'll follow
up with additional information as requested soon.
I'd expect that a filtered diff would be appreciated so the release-team
don't have to look at for example the changes only relevant for Windows
and OS X.

 
 Personally, I'd also like some input from the maintainers, as it's not
 at all clear to me whether they were intending to try and get that
 version in to jessie.

I can't speak for pochus intentions with the upload, but he should be
well aware of our freeze situation which probably meant he intended it
to go into Jessie. I don't see any reason not to include it in Jessie so
ACK from me.

Regards,
Andreas Henriksson


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-21 Thread Adam D. Barratt 

On 2014-11-21 12:08, Andreas Henriksson wrote:

I can't speak for pochus intentions with the upload, but he should be
well aware of our freeze situation


Well indeed. :-)


which probably meant he intended it
to go into Jessie. I don't see any reason not to include it in Jessie 
so

ACK from me.


As you know, the question isn't really why shouldn't it be included, 
more the positive reverse. Anyway, let's see...


Regards,

Adam


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-21 Thread Jonathan Wiltshire 

Control: tag -1 confirmed

On 2014-11-21 04:13, Matt Horan wrote:

The issue was fixed in upstream commit d9a433d [1], which applies
cleanly to the version in testing (3.14.4-2). If a patch would be
preferred over a new version, I can confirm the patch works for me.


Yes, please.

--
Jonathan Wiltshire  j...@debian.org
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

directhex i have six years of solaris sysadmin experience, from
8-10. i am well qualified to say it is made from bonghits
layered on top of bonghits


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-21 Thread Andreas Henriksson 
Hello again!

Heavily filtered debdiff included 

debdiff *.dsc | filterdiff -x '*/build/win32/*' -x '*/*/*.po' -x 
'*/gdk/quartz/*' -x '*/docs/*' -x '*/INSTALL' -x '*/README' -x '*/build/*msvc*' 
-x '*/*win32' -x '*/gdk/win32/rc/gdk.rc' -x '*/configure' -x '*/*/*.pot' -x 
'*/gdk/broadway/*.h' -x '*/gtk/gtkresources.c' -x '*/gtk/resources/*' -x 
'*/gtk/gtkversion.h' -x '*/gdk/gdkversionmacros.h' -x '*/debian/control' -x 
'*/debian/patches/*' -x '*/gtk/gtkmenu.c'

Summary of what was filtered out:
 - ms windows related changes
 - quartz (osx) related changes
 - built/autogenerated noise (eg. version number bump related, etc.)
 - css fixes in default adwaita theme
 - changes for previously shipped debian/patch now merged upstream.
 - translations

Not sure this complies with release-team normal procedures but for a
proper review I'd suggest looking at each commit in the upstream
repository separately together with the explanation in the commit
message and the referenced bug. See 3.14.4 - 3.14.5 at:
https://git.gnome.org/browse/gtk+/log/?h=gtk-3-14

I guess the result is still a bit to big for the release-teams taste,
but when looking at each fix individually I'm can't really spot one that
I'd say we could/should exclude. They're all nice to have and they do
benefit alot of users, while being as small as possible.
If in doubt I'd suggest to leave it in unstable for a week or two more
just to let it get some more testing and chance for people to report
bugs against it if they can find any, then look at it again to see if
it's time to unblock.

If you still disagree, then I think Matt would welcome some hints on how
he can go about getting a targeted fix in for the particular problem he
cares about


diff -Nru gtk+3.0-3.14.4/build/gtk-introspection-msvc.mak 
gtk+3.0-3.14.5/build/gtk-introspection-msvc.mak
diff -Nru gtk+3.0-3.14.4/build/win32/vs10/broadwayd.vcxproj 
gtk+3.0-3.14.5/build/win32/vs10/broadwayd.vcxproj
diff -Nru gtk+3.0-3.14.4/build/win32/vs10/broadwayd.vcxproj.filters 
gtk+3.0-3.14.5/build/win32/vs10/broadwayd.vcxproj.filters
diff -Nru gtk+3.0-3.14.4/build/win32/vs10/gtk-copy-gdk-broadway.props 
gtk+3.0-3.14.5/build/win32/vs10/gtk-copy-gdk-broadway.props
diff -Nru gtk+3.0-3.14.4/build/win32/vs10/gtk-install.props 
gtk+3.0-3.14.5/build/win32/vs10/gtk-install.props
diff -Nru gtk+3.0-3.14.4/build/win32/vs10/gtk-version-paths.props 
gtk+3.0-3.14.5/build/win32/vs10/gtk-version-paths.props
diff -Nru gtk+3.0-3.14.4/build/win32/vs11/broadwayd.vcxproj 
gtk+3.0-3.14.5/build/win32/vs11/broadwayd.vcxproj
diff -Nru gtk+3.0-3.14.4/build/win32/vs11/broadwayd.vcxproj.filters 
gtk+3.0-3.14.5/build/win32/vs11/broadwayd.vcxproj.filters
diff -Nru gtk+3.0-3.14.4/build/win32/vs11/gtk-copy-gdk-broadway.props 
gtk+3.0-3.14.5/build/win32/vs11/gtk-copy-gdk-broadway.props
diff -Nru gtk+3.0-3.14.4/build/win32/vs11/gtk-install.props 
gtk+3.0-3.14.5/build/win32/vs11/gtk-install.props
diff -Nru gtk+3.0-3.14.4/build/win32/vs11/gtk-version-paths.props 
gtk+3.0-3.14.5/build/win32/vs11/gtk-version-paths.props
diff -Nru gtk+3.0-3.14.4/build/win32/vs12/broadwayd.vcxproj 
gtk+3.0-3.14.5/build/win32/vs12/broadwayd.vcxproj
diff -Nru gtk+3.0-3.14.4/build/win32/vs12/broadwayd.vcxproj.filters 
gtk+3.0-3.14.5/build/win32/vs12/broadwayd.vcxproj.filters
diff -Nru gtk+3.0-3.14.4/build/win32/vs12/gtk-copy-gdk-broadway.props 
gtk+3.0-3.14.5/build/win32/vs12/gtk-copy-gdk-broadway.props
diff -Nru gtk+3.0-3.14.4/build/win32/vs12/gtk-install.props 
gtk+3.0-3.14.5/build/win32/vs12/gtk-install.props
diff -Nru gtk+3.0-3.14.4/build/win32/vs12/gtk-version-paths.props 
gtk+3.0-3.14.5/build/win32/vs12/gtk-version-paths.props
diff -Nru gtk+3.0-3.14.4/build/win32/vs9/broadwayd.vcproj 
gtk+3.0-3.14.5/build/win32/vs9/broadwayd.vcproj
diff -Nru gtk+3.0-3.14.4/build/win32/vs9/gtk-install.vsprops 
gtk+3.0-3.14.5/build/win32/vs9/gtk-install.vsprops
diff -Nru gtk+3.0-3.14.4/build/win32/vs9/gtk-version-paths.vsprops 
gtk+3.0-3.14.5/build/win32/vs9/gtk-version-paths.vsprops
diff -Nru gtk+3.0-3.14.4/config.h.win32 gtk+3.0-3.14.5/config.h.win32
diff -Nru gtk+3.0-3.14.4/configure gtk+3.0-3.14.5/configure
diff -Nru gtk+3.0-3.14.4/configure.ac gtk+3.0-3.14.5/configure.ac
--- gtk+3.0-3.14.4/configure.ac 2014-10-21 17:02:10.0 +0200
+++ gtk+3.0-3.14.5/configure.ac 2014-11-09 22:17:45.0 +0100
@@ -10,8 +10,8 @@
 
 m4_define([gtk_major_version], [3])
 m4_define([gtk_minor_version], [14])
-m4_define([gtk_micro_version], [4])
-m4_define([gtk_interface_age], [4])
+m4_define([gtk_micro_version], [5])
+m4_define([gtk_interface_age], [5])
 m4_define([gtk_binary_age],
   [m4_eval(100 * gtk_minor_version + gtk_micro_version)])
 m4_define([gtk_version],
diff -Nru gtk+3.0-3.14.4/debian/changelog gtk+3.0-3.14.5/debian/changelog
--- gtk+3.0-3.14.4/debian/changelog 2014-11-04 15:20:06.0 +0100
+++ gtk+3.0-3.14.5/debian/changelog 2014-11-11 18:55:48.0 +0100
@@ -1,3 +1,11 @@
+gtk+3.0 (3.14.5-1) unstable; urgency=medium
+
+  * New upstream

Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-20 Thread Matthew Horan 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

A gtk+3.0 version recently uploaded to unstable fixes one important bug:

* gtk3.14 systray applets have awkward mouse click behaviour (#767055).

I can confirm that the version in unstable resolves the issue for me.

Thanks in advance.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-20 Thread Dmitry Smirnov 
On Thu, 20 Nov 2014 22:38:23 Matthew Horan wrote:
 A gtk+3.0 version recently uploaded to unstable fixes one important bug:

A new version already? I hope it's not going to break KDE GTK-3 themes as 
almost every new release of gtk+3.0 does... :(

It is particularly challenging to backport an isolated fix for this issue?

-- 
Best wishes,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

All that is necessary for the triumph of evil is that good men do nothing.


signature.asc
Description: This is a digitally signed message part.

Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-20 Thread Matt Horan 
On Fri, Nov 21, 2014 at 03:05:50PM +1100, Dmitry Smirnov wrote:
 On Thu, 20 Nov 2014 22:38:23 Matthew Horan wrote:
  A gtk+3.0 version recently uploaded to unstable fixes one important bug:
 
 A new version already? I hope it's not going to break KDE GTK-3 themes as 
 almost every new release of gtk+3.0 does... :(
 
 It is particularly challenging to backport an isolated fix for this issue?

The issue was fixed in upstream commit d9a433d [1], which applies
cleanly to the version in testing (3.14.4-2). If a patch would be
preferred over a new version, I can confirm the patch works for me.

[1] https://git.gnome.org/browse/gtk+/commit/?id=d9a433d

Thanks,

-- 
Matt Horan m...@matthoran.com http://matthoran.com/


pgpMuKSE27usd.pgp
Description: PGP signature

Bug#770414: unblock: gtk+3.0/3.14.5-1

2014-11-20 Thread Adam D. Barratt 
Control: tags -1 + moreinfo

On Thu, 2014-11-20 at 22:38 -0500, Matthew Horan wrote:
 A gtk+3.0 version recently uploaded to unstable fixes one important bug:
 
 * gtk3.14 systray applets have awkward mouse click behaviour (#767055).
 
 I can confirm that the version in unstable resolves the issue for me.

That would need someone to provide the information requested in
https://release.debian.org/jessie/freeze_policy.html#getting-unblocks

Personally, I'd also like some input from the maintainers, as it's not
at all clear to me whether they were intending to try and get that
version in to jessie.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org