Bug#771374: unblock: macchanger/1.7.0-3.1

2014-11-29 Thread Niels Thykier
Control: tags -1 moreinfo

On 2014-11-28 23:07, Jean-Michel Nirgal Vourgère wrote:
 Package: release.debian.org
 User: release.debian@packages.debian.org
 Usertags: unblock
 Severity: normal
 
 Please unblock package macchanger
 
 When auto running, version in Jessie only changes the vendor-id of the
 mac-address, not the other bytes.
 
 Version 1.7.0-3.1 fixes that (#768325).
 
 See the attached diff file for the one byte change in the code. There is
 a small glitch in the changelog, I hope this is ok from the RT point of
 view.
 
 unblock macchanger/1.7.0-3.1
 
 [...]
 

Hi,

The actual change itself is fine, but why is the Closes from the NMU
undone?

~Niels


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#771374: unblock: macchanger/1.7.0-3.1

2014-11-29 Thread intrigeri
Control: tag -1 - moreinfo

Hi,

Niels Thykier wrote (29 Nov 2014 09:37:55 GMT) :
 The actual change itself is fine, but why is the Closes from the NMU
 undone?

Because I blindly trusted the debian/1.7.0-3 Git tag Hans-Christoph
had signed in Vcs-Git to actually match what he had uploaded into the
archive, and then failed to notice this change when I debdiff'ed it
before uploading :/

I've now fixed it in Vcs-Git. I guess it's not worth re-uploading,
is it?

Cheers,
-- 
intrigeri


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#771374: unblock: macchanger/1.7.0-3.1

2014-11-29 Thread Niels Thykier
On 2014-11-29 11:08, intrigeri wrote:
 Control: tag -1 - moreinfo
 
 Hi,
 
 Niels Thykier wrote (29 Nov 2014 09:37:55 GMT) :
 The actual change itself is fine, but why is the Closes from the NMU
 undone?
 
 Because I blindly trusted the debian/1.7.0-3 Git tag Hans-Christoph
 had signed in Vcs-Git to actually match what he had uploaded into the
 archive, and then failed to notice this change when I debdiff'ed it
 before uploading :/
 

Ok.

 I've now fixed it in Vcs-Git. I guess it's not worth re-uploading,
 is it?
 
 Cheers,
 

I would prefer if it was.  The BTS do look at the changelog history and
do in fact unfix bugs if the next upload omits changelog entries (on
the assumption that the upload omits the changes related to the
changelog entry).
  With a quick glance, it does not seem to happen if you simply remove
the closes (i.e. in this case) - but it still; I prefer no surprises
to suddenly having bugs magically reopen.

~Niels


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#771374: unblock: macchanger/1.7.0-3.1

2014-11-29 Thread intrigeri
Control: retitle -1 unblock: macchanger/1.7.0-3.2
Control: tag -1 + moreinfo

Hi Niels,

Niels Thykier wrote (29 Nov 2014 10:31:54 GMT) :
 On 2014-11-29 11:08, intrigeri wrote:
 I've now fixed it in Vcs-Git. I guess it's not worth re-uploading,
 is it?

 I would prefer if it was. [...]

Fair enough, thanks for the explanation!

Uploaded -3.2, new debdiff attached.

I'll remove the moreinfo tag once the package is accepted in sid and
has been built everywhere.

Cheers,
-- 
intrigeri

diff -Nru macchanger-1.7.0/debian/changelog macchanger-1.7.0/debian/changelog
--- macchanger-1.7.0/debian/changelog	2014-11-07 13:03:50.0 +0100
+++ macchanger-1.7.0/debian/changelog	2014-11-29 13:50:42.0 +0100
@@ -1,3 +1,19 @@
+macchanger (1.7.0-3.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Reintroduce the changelog entry for 1.7.0-3 as it was uploaded:
+the previous NMU replaced it with the one that was tagged in Git.
+
+ -- intrigeri intrig...@debian.org  Sat, 29 Nov 2014 13:49:01 +0100
+
+macchanger (1.7.0-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Change the non-vendor bytes, and only them, on automatic run.
+(Closes: #768325)
+
+ -- Jean-Michel Nirgal Vourgère jmv_...@nirgal.com  Thu, 27 Nov 2014 10:52:16 +0100
+
 macchanger (1.7.0-3) unstable; urgency=low
 
   * update debian/watch to point to new github repository
diff -Nru macchanger-1.7.0/debian/if-pre-up.d/macchanger macchanger-1.7.0/debian/if-pre-up.d/macchanger
--- macchanger-1.7.0/debian/if-pre-up.d/macchanger	2014-10-21 21:38:32.0 +0200
+++ macchanger-1.7.0/debian/if-pre-up.d/macchanger	2014-11-29 13:50:42.0 +0100
@@ -29,4 +29,4 @@
 	exit 0
 fi
 
-/usr/bin/${package} -A $IFACE  $LOGFILE 21
+/usr/bin/${package} -e $IFACE  $LOGFILE 21


Bug#771374: unblock: macchanger/1.7.0-3.1

2014-11-28 Thread Jean-Michel Nirgal Vourgère
Package: release.debian.org
User: release.debian@packages.debian.org
Usertags: unblock
Severity: normal

Please unblock package macchanger

When auto running, version in Jessie only changes the vendor-id of the
mac-address, not the other bytes.

Version 1.7.0-3.1 fixes that (#768325).

See the attached diff file for the one byte change in the code. There is
a small glitch in the changelog, I hope this is ok from the RT point of
view.

unblock macchanger/1.7.0-3.1

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru macchanger-1.7.0/debian/changelog macchanger-1.7.0/debian/changelog
--- macchanger-1.7.0/debian/changelog	2014-11-07 13:03:50.0 +0100
+++ macchanger-1.7.0/debian/changelog	2014-11-28 22:40:43.0 +0100
@@ -1,9 +1,17 @@
+macchanger (1.7.0-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Change the non-vendor bytes, and only them, on automatic run.
+(Closes: #768325)
+
+ -- Jean-Michel Nirgal Vourgère jmv_...@nirgal.com  Thu, 27 Nov 2014 10:52:16 +0100
+
 macchanger (1.7.0-3) unstable; urgency=low
 
   * update debian/watch to point to new github repository
-  * include code from 1.7.0-1.1 NMU (Closes: #738460, #740947)
+  * include code from 1.7.0-1.1 Non-Maintainer Upload
 
- -- Hans-Christoph Steiner h...@eds.org  Fri, 07 Nov 2014 12:56:56 +0100
+ -- Hans-Christoph Steiner h...@eds.org  Wed, 22 Oct 2014 12:32:24 -0400
 
 macchanger (1.7.0-2) unstable; urgency=low
 
diff -Nru macchanger-1.7.0/debian/if-pre-up.d/macchanger macchanger-1.7.0/debian/if-pre-up.d/macchanger
--- macchanger-1.7.0/debian/if-pre-up.d/macchanger	2014-10-21 21:38:32.0 +0200
+++ macchanger-1.7.0/debian/if-pre-up.d/macchanger	2014-11-28 22:40:43.0 +0100
@@ -29,4 +29,4 @@
 	exit 0
 fi
 
-/usr/bin/${package} -A $IFACE  $LOGFILE 21
+/usr/bin/${package} -e $IFACE  $LOGFILE 21


signature.asc
Description: OpenPGP digital signature