Bug#772566: unblock: sqlite3/3.8.7.2-1

2014-12-09 Thread Ivo De Decker
Control: tags -1 moreinfo

Hi,

On Mon, Dec 08, 2014 at 05:53:28PM +0100, Laszlo Boszormenyi (GCS) wrote:
 Please consider unblocking the current Sid version of SQLite3. It's one
 of the rare upstream immediate bugfix release.

What does 'immediate bugfix release' mean?

 There's an RC bug filed against the source package of the Wheezy version.

You didn't mention the bug number, but I guess you're talking about #771341.

 But as the reporter states the version in Jessie is also effected.

Please adjust the found versions, so that the BTS knows this.

 The bug is very hard to reproduce so it's not yet known if this version
 fixes that bug or not.

If you don't have any idea whether this new version fixes the bug or not, we
certainly aren't going to unblock it.

Please read the freeze policy. We are only allowing unblocks for targeted
fixes for certain types of bugs. Random 'fixes' from upstream are not
appropriate at this time.

 There's an other upstream immediate bugfix release, which if allowed I
 would like to upload. Diffs are attached and the upstream bugfix log is:
 1) for 3.8.7.2[2]:


 Enhance the ROLLBACK command so that pending queries are allowed to
 continue as long as the schema is unchanged. Formerly, a ROLLBACK would
 cause all pending queries to fail with an SQLITE_ABORT or
 SQLITE_ABORT_ROLLBACK error. That error is still returned if the
 ROLLBACK modifies the schema.

This doesn't sound like a bug fix. It's a new feature, which even changes the
behaviour.

   * Bug fix: Make sure that NULL results from OP_Column are fully and
 completely NULL and do not have the MEM_Ephem bit set. Ticket
 094d39a4c95ee4.
   * Bug fix: The %c format in sqlite3_mprintf() is able to handle
 precisions greater than 70.
   * Bug fix: Do not automatically remove the DISTINCT keyword from a
 SELECT that forms the right-hand side of an IN operator since it is
 necessary if the SELECT also contains a LIMIT. Ticket db87229497.

If you think any of these changes is appropriate (based on the freeze policy),
please explain why.

 2) for 3.8.7.3[3]:
 Bug fix: Ensure the cached KeyInfo objects (an internal abstraction not
 visible to the application) do not go stale when operating in shared
 cache mode and frequently closing and reopening some database
 connections while leaving other database connections on the same shared
 cache open continuously. Ticket e4a18565a36884b00edf.
   * Bug fix: Recognize that any column in the right-hand table of a LEFT
 JOIN can be NULL even if the column has a NOT NULL constraint. Do
 not apply optimizations that assume the column is never NULL. Ticket
 6fd550f5b0ee7ed.

 As SQLite3 is used by several other packages, it would be good to have
 these safe, immediate upstream fixes for Jessie.

Calling the changes 'safe' or 'immediate' doesn't make more appropriate for an
unblock.

It seems none of these changes complies with the freeze policy, so they are
not appropriate for an unblock.

If you have a targeted fix for #771341, please upload it to unstable
(reverting the other changes) and file an unblock for that.

Cheers,

Ivo


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#772566: unblock: sqlite3/3.8.7.2-1

2014-12-08 Thread Laszlo Boszormenyi (GCS)
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi Release Team,

Please consider unblocking the current Sid version of SQLite3. It's one
of the rare upstream immediate bugfix release. There's an RC bug filed
against the source package of the Wheezy version. But as the reporter
states the version in Jessie is also effected. The bug is very hard to
reproduce so it's not yet known if this version fixes that bug or not.
There's an other upstream immediate bugfix release, which if allowed I
would like to upload. Diffs are attached and the upstream bugfix log is:
1) for 3.8.7.2[2]:
Enhance the ROLLBACK command so that pending queries are allowed to
continue as long as the schema is unchanged. Formerly, a ROLLBACK would
cause all pending queries to fail with an SQLITE_ABORT or
SQLITE_ABORT_ROLLBACK error. That error is still returned if the
ROLLBACK modifies the schema.
  * Bug fix: Make sure that NULL results from OP_Column are fully and
completely NULL and do not have the MEM_Ephem bit set. Ticket
094d39a4c95ee4.
  * Bug fix: The %c format in sqlite3_mprintf() is able to handle
precisions greater than 70.
  * Bug fix: Do not automatically remove the DISTINCT keyword from a
SELECT that forms the right-hand side of an IN operator since it is
necessary if the SELECT also contains a LIMIT. Ticket db87229497.

2) for 3.8.7.3[3]:
Bug fix: Ensure the cached KeyInfo objects (an internal abstraction not
visible to the application) do not go stale when operating in shared
cache mode and frequently closing and reopening some database
connections while leaving other database connections on the same shared
cache open continuously. Ticket e4a18565a36884b00edf.
  * Bug fix: Recognize that any column in the right-hand table of a LEFT
JOIN can be NULL even if the column has a NOT NULL constraint. Do
not apply optimizations that assume the column is never NULL. Ticket
6fd550f5b0ee7ed.

As SQLite3 is used by several other packages, it would be good to have
these safe, immediate upstream fixes for Jessie.

Thanks,
Laszlo/GCS

unblock sqlite3/3.8.7.2-1

[1] https://bugs.debian.org/771341
[2] http://www.sqlite.org/releaselog/3_8_7_2.html
[3] http://www.sqlite.org/releaselog/3_8_7_3.html
diff -Nur sqlite3-3.8.7.1/configure sqlite3-3.8.7.2/configure
--- sqlite3-3.8.7.1/configure	2014-10-29 21:13:32.0 +
+++ sqlite3-3.8.7.2/configure	2014-11-19 14:10:06.0 +
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.62 for sqlite 3.8.7.1.
+# Generated by GNU Autoconf 2.62 for sqlite 3.8.7.2.
 #
 # Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001,
 # 2002, 2003, 2004, 2005, 2006, 2007, 2008 Free Software Foundation, Inc.
@@ -743,8 +743,8 @@
 # Identity of this package.
 PACKAGE_NAME='sqlite'
 PACKAGE_TARNAME='sqlite'
-PACKAGE_VERSION='3.8.7.1'
-PACKAGE_STRING='sqlite 3.8.7.1'
+PACKAGE_VERSION='3.8.7.2'
+PACKAGE_STRING='sqlite 3.8.7.2'
 PACKAGE_BUGREPORT=''
 
 # Factoring default headers for most tests.
@@ -1483,7 +1483,7 @@
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat _ACEOF
-\`configure' configures sqlite 3.8.7.1 to adapt to many kinds of systems.
+\`configure' configures sqlite 3.8.7.2 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1548,7 +1548,7 @@
 
 if test -n $ac_init_help; then
   case $ac_init_help in
- short | recursive ) echo Configuration of sqlite 3.8.7.1:;;
+ short | recursive ) echo Configuration of sqlite 3.8.7.2:;;
esac
   cat \_ACEOF
 
@@ -1664,7 +1664,7 @@
 test -n $ac_init_help  exit $ac_status
 if $ac_init_version; then
   cat \_ACEOF
-sqlite configure 3.8.7.1
+sqlite configure 3.8.7.2
 generated by GNU Autoconf 2.62
 
 Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001,
@@ -1678,7 +1678,7 @@
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by sqlite $as_me 3.8.7.1, which was
+It was created by sqlite $as_me 3.8.7.2, which was
 generated by GNU Autoconf 2.62.  Invocation command line was
 
   $ $0 $@
@@ -14021,7 +14021,7 @@
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log=
-This file was extended by sqlite $as_me 3.8.7.1, which was
+This file was extended by sqlite $as_me 3.8.7.2, which was
 generated by GNU Autoconf 2.62.  Invocation command line was
 
   CONFIG_FILES= $CONFIG_FILES
@@ -14074,7 +14074,7 @@
 _ACEOF
 cat $CONFIG_STATUS _ACEOF || ac_write_fail=1
 ac_cs_version=\\
-sqlite config.status 3.8.7.1
+sqlite config.status 3.8.7.2
 configured by $0, generated by GNU Autoconf 2.62,
   with options \\`$as_echo $ac_configure_args | sed 's/^ //; s/[\\\`\$]//g'`\\
 
diff -Nur