Bug#773029: groonga-server-common: purging deletes conffiles owned by other packages: /etc/groonga/{groonga.conf, synonyms.tsv}

[HAYASHI Kentaro]

Hi,

On Wed, 14 Oct 2015 21:02:13 +1100 =?iso-8859-1?Q?An=EDbal?= Monsalve Salazar 
 wrote:
> 
> Hello HAYASHI Kentaro,
> 
> The URL above returns a 404 error.
> 
> Where can I find groonga_4.0.6.1-3.dsc and groonga_4.0.6.1-3.debian*
> with all the changes above?
> 
> Thank you,
> 
> Aníbal

Oops.
I've uploaded it from archive again.

Regards.

Bug#773029: groonga-server-common: purging deletes conffiles owned by other packages: /etc/groonga/{groonga.conf, synonyms.tsv}

[Aníbal Monsalve Salazar]

On Wed, 2014-12-31 19:54:11 +0900, HAYASHI Kentaro wrote:
> Hi,
>
> Thank you for reporting & pointing out issues,  Andreas!
>
> I've just uploaded fixed version of Groonga.
> (There are some minor problems, so I've also fixed it)
>
> Here is the dsc file.
>  http://mentors.debian.net/debian/pool/main/g/groonga/groonga_4.0.6.1-3.dsc
>
> I'm not a member of DM nor DD, so please upload it to Debian archive.
>
> groonga (4.0.6.1-3) unstable; urgency=low
>
>   * Team upload.
>   * debian/groonga-server-common.postrm
> debian/groonga-server-gqtp.postrm
> debian/groonga-httpd.postrm
> debian/groonga-server-common.dirs
> debian/groonga-server-gqtp.dirs
> debian/groonga-server-http.dirs
> debian/libgroonga0.dirs
> debian/libgroonga0.postrm
> - Fix not to delete conffiles which are owned by other packages
>   (Closes: #773029)
>   * debian/groonga-httpd.init
> - Fix invalid conf path to detect proper default pid file.
> - Ensure to create directory to store pid file.
>   * debian/patches/hardening-vendor-nginx.patch
> - Apply hardening to groonga-httpd.

Hello HAYASHI Kentaro,

The URL above returns a 404 error.

Where can I find groonga_4.0.6.1-3.dsc and groonga_4.0.6.1-3.debian*
with all the changes above?

Thank you,

Aníbal

Bug#773029: groonga-server-common: purging deletes conffiles owned by other packages: /etc/groonga/{groonga.conf, synonyms.tsv}

[HAYASHI Kentaro]

Hi,

I've just uploaded source package again which fix is limited to #773029
only.

Here is the .dsc file:

http://mentors.debian.net/debian/pool/main/g/groonga/groonga_4.0.6.1-3.dsc

On Tue, 20 Jan 2015 18:32:54 +0900 HAYASHI Kentaro ken...@gmail.com wrote:
 On Sat, 17 Jan 2015 12:12:31 + Jonathan Wiltshire j...@debian.org
 wrote:
  Hi,
 
 ...
 
  Unfortunatley this isn't suitable for including in Jessie. Could you
  prepare an upload that only fixes this bug, and not the other changes
like
  hardening for nginx?
 

 Thank you for your advice.
 Ok, I'll upload fix version again.

 Regards,

Bug#773029: groonga-server-common: purging deletes conffiles owned by other packages: /etc/groonga/{groonga.conf, synonyms.tsv}

[HAYASHI Kentaro]

On Sat, 17 Jan 2015 12:12:31 + Jonathan Wiltshire j...@debian.org
wrote:
 Hi,

...

 Unfortunatley this isn't suitable for including in Jessie. Could you
 prepare an upload that only fixes this bug, and not the other changes like
 hardening for nginx?


Thank you for your advice.
Ok, I'll upload fix version again.

Regards,

Bug#773029: groonga-server-common: purging deletes conffiles owned by other packages: /etc/groonga/{groonga.conf, synonyms.tsv}

[Jonathan Wiltshire]

Hi,

On Wed, Dec 31, 2014 at 07:54:11PM +0900, HAYASHI Kentaro wrote:
 I've just uploaded fixed version of Groonga.
 (There are some minor problems, so I've also fixed it)
 
 Here is the dsc file.
  http://mentors.debian.net/debian/pool/main/g/groonga/groonga_4.0.6.1-3.dsc

Unfortunatley this isn't suitable for including in Jessie. Could you
prepare an upload that only fixes this bug, and not the other changes like
hardening for nginx?


-- 
Jonathan Wiltshire  j...@debian.org
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51



signature.asc
Description: Digital signature

Bug#773029: groonga-server-common: purging deletes conffiles owned by other packages: /etc/groonga/{groonga.conf, synonyms.tsv}

[HAYASHI Kentaro]

Hi,

Thank you for reporting  pointing out issues,  Andreas!

I've just uploaded fixed version of Groonga.
(There are some minor problems, so I've also fixed it)

Here is the dsc file.
 http://mentors.debian.net/debian/pool/main/g/groonga/groonga_4.0.6.1-3.dsc

I'm not a member of DM nor DD, so please upload it to Debian archive.

groonga (4.0.6.1-3) unstable; urgency=low

  * Team upload.
  * debian/groonga-server-common.postrm
debian/groonga-server-gqtp.postrm
debian/groonga-httpd.postrm
debian/groonga-server-common.dirs
debian/groonga-server-gqtp.dirs
debian/groonga-server-http.dirs
debian/libgroonga0.dirs
debian/libgroonga0.postrm
- Fix not to delete conffiles which are owned by other packages
  (Closes: #773029)
  * debian/groonga-httpd.init
- Fix invalid conf path to detect proper default pid file.
- Ensure to create directory to store pid file.
  * debian/patches/hardening-vendor-nginx.patch
- Apply hardening to groonga-httpd.


On Fri, 26 Dec 2014 14:04:18 -0800 Vagrant Cascadian vagr...@debian.org wrote:
 On 2014-12-13, Andreas Beckmann wrote:
  during a test with piuparts I noticed your package removes files that
  were installed by another package.
  The removed files were already present before the package was installed,
  they may have been shipped or created by a dependency.
 ...
Removing groonga-server-common (4.0.6.1-2) ...
Purging configuration files for groonga-server-common (4.0.6.1-2) ...
  0m24.4s ERROR: FAIL: debsums reports modifications inside the chroot:
debsums: missing file /etc/groonga/groonga.conf (from groonga-bin package)
debsums: missing file /etc/groonga/synonyms.tsv (from libgroonga0:amd64 
  package)
 
 
  I didn't check, but there is probably a rm -rf /etc/groonga in the postrm.
 
 Yes, this appears to be what's happening...
 
 groonga-server-common.postrm:
 
 for target in /var/run/groonga /var/lib/groonga /var/log/groonga 
 /etc/groonga
 do
   dpkg-statoverride --remove $target
   rm -rf $target
 done
 
 groonga-server-common doesn't appear to ship any files in /etc/groonga,
 or create them in the .postinst. Though dpkg-statoverride appears to be
 used in order to set the group and user permissions:
 
 for target in /var/run/groonga /var/lib/groonga /etc/groonga 
 /var/log/groonga
 do
 dpkg-statoverride --list $target /dev/null || \
 dpkg-statoverride --update --add groonga groonga 0755 $target
 done
 
 
 Similar code is present in groonga-httpd.postrm and
 groonga-httpd.postinst in the same source package, so that may need to
 be fixed in groonga-httpd as well (though I'm unsure if any other
 packages ship files in there currently, it seems like it could have the
 same issue in the future).
 
 
 I'm not familiar with groonga, but it seems unecessary to remove
 /etc/groonga (and /etc/groonga/httpd) manually on purge, as dpkg should
 take care of that when the directories are empty.
 
 
 live well,
   vagrant



-- 
HAYASHI Kentaro haya...@clear-code.com


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#773029: groonga-server-common: purging deletes conffiles owned by other packages: /etc/groonga/{groonga.conf, synonyms.tsv}

[Vagrant Cascadian]

On 2014-12-13, Andreas Beckmann wrote:
 during a test with piuparts I noticed your package removes files that
 were installed by another package.
 The removed files were already present before the package was installed,
 they may have been shipped or created by a dependency.
...
   Removing groonga-server-common (4.0.6.1-2) ...
   Purging configuration files for groonga-server-common (4.0.6.1-2) ...
 0m24.4s ERROR: FAIL: debsums reports modifications inside the chroot:
   debsums: missing file /etc/groonga/groonga.conf (from groonga-bin package)
   debsums: missing file /etc/groonga/synonyms.tsv (from libgroonga0:amd64 
 package)


 I didn't check, but there is probably a rm -rf /etc/groonga in the postrm.

Yes, this appears to be what's happening...

groonga-server-common.postrm:

for target in /var/run/groonga /var/lib/groonga /var/log/groonga 
/etc/groonga
do
dpkg-statoverride --remove $target
rm -rf $target
done

groonga-server-common doesn't appear to ship any files in /etc/groonga,
or create them in the .postinst. Though dpkg-statoverride appears to be
used in order to set the group and user permissions:

for target in /var/run/groonga /var/lib/groonga /etc/groonga 
/var/log/groonga
do
dpkg-statoverride --list $target /dev/null || \
dpkg-statoverride --update --add groonga groonga 0755 $target
done


Similar code is present in groonga-httpd.postrm and
groonga-httpd.postinst in the same source package, so that may need to
be fixed in groonga-httpd as well (though I'm unsure if any other
packages ship files in there currently, it seems like it could have the
same issue in the future).


I'm not familiar with groonga, but it seems unecessary to remove
/etc/groonga (and /etc/groonga/httpd) manually on purge, as dpkg should
take care of that when the directories are empty.


live well,
  vagrant


signature.asc
Description: PGP signature

Bug#773029: groonga-server-common: purging deletes conffiles owned by other packages: /etc/groonga/{groonga.conf, synonyms.tsv}

[Andreas Beckmann]

Package: groonga-server-common
Version: 4.0.6.1-2
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package removes files that
were installed by another package.
The removed files were already present before the package was installed,
they may have been shipped or created by a dependency.

This could be a violation of policy 10.7.4 (Sharing configuration
files), see
https://www.debian.org/doc/debian-policy/ch-files.html#s10.7.4
or policy chapter 6 (Package maintainer scripts...), see
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html
or policy 7.6 (Overwriting files...), see
https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces

If a directory is used by several packages, all should ship it as part
of the package (possibly empty, using $package.dirs to create it), and
no package should mkdir/rmdir it in the maintainer scripts as dpkg will
take care of this.

From the attached log (scroll to the bottom...):

  Removing groonga-server-common (4.0.6.1-2) ...
  Purging configuration files for groonga-server-common (4.0.6.1-2) ...
0m24.4s ERROR: FAIL: debsums reports modifications inside the chroot:
  debsums: missing file /etc/groonga/groonga.conf (from groonga-bin package)
  debsums: missing file /etc/groonga/synonyms.tsv (from libgroonga0:amd64 
package)


I didn't check, but there is probably a rm -rf /etc/groonga in the postrm.


cheers,

Andreas


groonga-server-common_4.0.6.1-2.log.gz
Description: application/gzip