Bug#773032: squid3: prompting due to modified conffiles which were not modified by the user: /etc/squid3/squid.conf

2014-12-15 Thread Luigi Gangitano
Hi Andreas,

 during a test with piuparts I noticed your package failed the piuparts
 upgrade test because dpkg detected a conffile as being modified and then
 prompted the user for an action. As there is no user input, this fails.
 But this is not the real problem, the real problem is that this prompt
 shows up in the first place, as there was nobody modifying this conffile
 at all, the package has just been installed and upgraded…

Can you please provide more information on this process? Which version was the 
original install before the upgrade to 3.8.4-4?

 This is a violation of policy 10.7.3, see
 https://www.debian.org/doc/debian-policy/ch-files.html#s10.7.3,
 which says [These scripts handling conffiles] must not ask unnecessary
 questions (particularly during upgrades), and must otherwise be good
 citizens.”

I suspect that this comes from the fix we applied for #768170 which was a more 
critical bug while upgrading from Wheezy, since a line that was active by 
default in previous configuration now makes squid3 unable to start after 
upgrade.

We choose to comment out that line during upgrade, in a script modifying 
/etc/squid3/squid.conf.

In our tests we did not experience the behavior you reported, so I need more 
information to confirm that this is the case.

Regards,

L

--
Luigi Gangitano -- lu...@debian.org -- gangit...@lugroma3.org
GPG: 1024D/924C0C26: 12F8 9C03 89D3 DB4A 9972  C24A F19B A618 924C 0C26
GPG: 4096R/2BA97CED: 8D48 5A35 FF1E 6EB7 90E5  0F6D 0284 F20C 2BA9 7CED


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#773032: squid3: prompting due to modified conffiles which were not modified by the user: /etc/squid3/squid.conf

2014-12-15 Thread Andreas Beckmann
On 2014-12-15 10:43, Luigi Gangitano wrote:
 Can you please provide more information on this process? Which version was 
 the original install before the upgrade to 3.8.4-4?

The wheezy version.

 I suspect that this comes from the fix we applied for #768170 which was a 
 more critical bug while upgrading from Wheezy, since a line that was active 
 by default in previous configuration now makes squid3 unable to start after 
 upgrade.
 
 We choose to comment out that line during upgrade, in a script modifying 
 /etc/squid3/squid.conf.

That must be done in the postinst, after dpkg has handled the conffiles.
If the configuration was unmodified, dpkg will install the new one and
the offending lines will be gone before the postinst tries to fix them.
Doing this in the preinst will cause dpkg to always see a locally
modified conffile.

 In our tests we did not experience the behavior you reported, so I need more 
 information to confirm that this is the case.

Try a pristine wheezy install with shipped configuration and distupgrade
with DEBIAN_FRONTEND=noninteractive


Andreas


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#773032: squid3: prompting due to modified conffiles which were not modified by the user: /etc/squid3/squid.conf

2014-12-13 Thread Andreas Beckmann
Package: squid3
Version: 3.4.8-4
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package failed the piuparts
upgrade test because dpkg detected a conffile as being modified and then
prompted the user for an action. As there is no user input, this fails.
But this is not the real problem, the real problem is that this prompt
shows up in the first place, as there was nobody modifying this conffile
at all, the package has just been installed and upgraded...

This is a violation of policy 10.7.3, see
https://www.debian.org/doc/debian-policy/ch-files.html#s10.7.3,
which says [These scripts handling conffiles] must not ask unnecessary
questions (particularly during upgrades), and must otherwise be good
citizens.

https://wiki.debian.org/DpkgConffileHandling should help with figuring
out how to do this properly.

In https://lists.debian.org/debian-devel/2009/08/msg00675.html and
followups it has been agreed that these bugs are to be filed with
severity serious.

From the attached log (scroll to the bottom...):

  Setting up squid3-common (3.4.8-4) ...
  Setting up squid3 (3.4.8-4) ...
  Installing new version of config file /etc/init.d/squid3 ...
  Installing new version of config file /etc/logrotate.d/squid3 ...
  Installing new version of config file /etc/resolvconf/update-libc.d/squid3 ...
  
  Configuration file '/etc/squid3/squid.conf'
   == Modified (by you or by a script) since installation.
   == Package distributor has shipped an updated version.
 What would you like to do about it ?  Your options are:
  Y or I  : install the package maintainer's version
  N or O  : keep your currently-installed version
D : show the differences between the versions
Z : start a shell to examine the situation
   The default action is to keep your current version.
  *** squid.conf (Y/I/N/O/D/Z) [default=N] ? dpkg: error processing package 
squid3 (--configure):
   EOF on stdin at conffile prompt
  Processing triggers for libc-bin (2.19-13) ...
  Errors were encountered while processing:
   squid3


cheers,

Andreas


squid3_3.4.8-4.log.gz
Description: application/gzip