Bug#773181: [Rsbackup-maint] Bug#773181: rsbackup: unowned files after purge (policy 6.8, 10.8): /etc/rsbackup/local
(I'm upstream for rsbackup.) Andreas Beckmann wrote: during a test with piuparts I noticed your package left unowned files on the system after purge, which is a violation of policy 6.8 (or 10.8): https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails As far as I can see that reference doesn't explain what purge should actually do, merely when it is run. Is there some better documentation available? I'm rather in the dark about how to respond to this. My current best guess is: https://github.com/ewxrjk/rsbackup/commit/b1283baf ttfn/rjk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#773181: rsbackup: unowned files after purge (policy 6.8, 10.8): /etc/rsbackup/local
On 2014-12-16 22:29, Richard Kettlewell wrote:
(I'm upstream for rsbackup.)
Andreas Beckmann wrote:
during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy 6.8 (or 10.8):
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails
As far as I can see that reference doesn't explain what purge should
actually do, merely when it is run. Is there some better documentation
available? I'm rather in the dark about how to respond to this.
I'm sure there is. I just can't find it right now :-)
purging deletes configuration files and should clean up everything the
package may have left around ... to leave the system like the package
was never installed.
My current best guess is:
https://github.com/ewxrjk/rsbackup/commit/b1283baf
The intention is right, but
rmdir --ignore-fail-on-non-empty /etc/rsbackup
needs to check for directory existence first. That command will fail if
the directory cannot be removed because it is not there.
And OH MY GOD for
cp debian/${PACKAGE}.postrm debian/${PACKAGE}/DEBIAN/postrm
Please consider switching to using dh/debhelper for the packaging - do
not do this by hand. I won't mind reviewing it :-) But: do this only
after jessie was released, now in deep freeze is not the right time for
such invasive changes.
Andreas
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#773181: [Rsbackup-maint] Bug#773181: rsbackup: unowned files after purge (policy 6.8, 10.8): /etc/rsbackup/local
On 16/12/14 21:54, Andreas Beckmann wrote: Please consider switching to using dh/debhelper for the packaging - do not do this by hand. I won't mind reviewing it :-) But: do this only after jessie was released, now in deep freeze is not the right time for such invasive changes. I'm at least vaguely planning to move to dh once jessie is out. But rjk has been producing .debs of rsbackup long before I put it into Debian, so a little cruft is to be expected :) Regards, Matthew -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#773181: rsbackup: unowned files after purge (policy 6.8, 10.8): /etc/rsbackup/local
Package: rsbackup Version: 1.1-2 Severity: important User: debian...@lists.debian.org Usertags: piuparts Hi, during a test with piuparts I noticed your package left unowned files on the system after purge, which is a violation of policy 6.8 (or 10.8): https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails Filing this as important as having a piuparts clean archive is a release goal since lenny. From the attached log (scroll to the bottom...): 0m31.4s ERROR: FAIL: Package purging left files on system: /etc/rsbackup/ owned by: rsbackup /etc/rsbackup/localnot owned cheers, Andreas rsbackup_1.1-2.log.gz Description: application/gzip
