Bug#773713: NMU interdiff
Hi I've now upgraded to broadcom-sta-dkms 6.30.223.248-3.3 and running kernel 4.1.0-rc3 and everything works just fine. Thanks! Br, Anders
Bug#773713: NMU interdiff
Hallo, * Anders Hedlund [Sat, May 02 2015, 08:51:58PM]: Hi, I'm trying out the interdiff by Eduard but get the below error when trying to install the new package. Do you guys know what's wrong? Partially... DKMS make.log for broadcom-sta-6.30.223.248 for kernel 4.1.0-rc1 (x86_64) Sat May 2 20:28:51 CEST 2015 /bin/sh: line 0: [: : integer expression expected /bin/sh: line 0: [: : integer expression expected I cannot reproduce this with 4.1.0-rc2 and dkms. Might be a locale issues. If you still get it with 4.1.0-rc2, consider reporting that as dkms bug, IMHO. Kernel architecture is X86_64 MODPOST 1 modules FATAL: modpost: GPL-incompatible module wl.ko uses GPL-only symbol 'cpu_tss' This one is reproducible. Here is the patch you are looking for: http://marc.info/?l=linux-kernelm=143076342107848 Both IMHO not this module's issues and fixable, not a showstopper. Regards, Eduard. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#773713: NMU interdiff
On Wed, 29 Apr 2015 16:44:14 +0200 Bruno Bierbaumer l...@bierbaumer.net wrote: Hello! I would say it fits in here, because the problem first appears with Linux 3.18 and the bug is about supporting Linux 3.18+. Fixing a bug that we know of as we go also sounds like a good idea. Also just my opinion. Ok, as announced, I added the missing patch. Updated diff file attached, just uploaded to 2-day DELAYED queue. Regards, Eduard. diff -Nurd broadcom-sta_6.30.223.248-3.debian/debian/changelog broadcom-sta_6.30.223.248-3.2.debian/debian/changelog --- broadcom-sta_6.30.223.248-3.debian/debian/changelog 2014-12-07 15:07:56.0 +0100 +++ broadcom-sta_6.30.223.248-3.2.debian/debian/changelog 2015-05-06 21:29:54.0 +0200 @@ -1,3 +1,21 @@ +broadcom-sta (6.30.223.248-3.2) unstable; urgency=low + + * Non-maintainer upload. + * Added broadcom-sta-6.30.223.248-linux-3.18-null-pointer-crash.patch to +prevent potential problems with recent kernels (closes: #773713) + + -- Eduard Bloch bl...@debian.org Wed, 06 May 2015 21:22:40 +0200 + +broadcom-sta (6.30.223.248-3.1) unstable; urgency=low + + * Non-maintainer upload. + * Added Canonical patches to support Linux kernel versions up to 4.0.0 +(closes: #773713) + * Set some variables right for kernel-package/module-assistant usage, +to build correctly against headers without having to boot that kernel + + -- Eduard Bloch bl...@debian.org Wed, 29 Apr 2015 11:50:17 +0200 + broadcom-sta (6.30.223.248-3) unstable; urgency=medium * Synced supported chipsets list with README.txt file (Closes: #762954). diff -Nurd broadcom-sta_6.30.223.248-3.debian/debian/patches/10-0015-add-support-for-Linux-3.18.patch broadcom-sta_6.30.223.248-3.2.debian/debian/patches/10-0015-add-support-for-Linux-3.18.patch --- broadcom-sta_6.30.223.248-3.debian/debian/patches/10-0015-add-support-for-Linux-3.18.patch 1970-01-01 01:00:00.0 +0100 +++ broadcom-sta_6.30.223.248-3.2.debian/debian/patches/10-0015-add-support-for-Linux-3.18.patch 2015-04-29 11:57:53.0 +0200 @@ -0,0 +1,38 @@ +From 8b6f3f87c81fa35eef24831e9a93eff1e6e1444f Mon Sep 17 00:00:00 2001 +From: Alberto Milone alberto.mil...@canonical.com +Date: Mon, 10 Nov 2014 09:22:09 +0100 +Subject: [PATCH 1/1] Update cfg80211_inform_bss() to use + CFG80211_BSS_FTYPE_UNKNOWN + +This is only necessary with Linux = 3.18. +Modified by Eduard Bloch bl...@debian.org to align with Debian package broadcom-sta patches. + +Original author: Krzysztof Kolasa +Original Source: https://raw.githubusercontent.com/kolasa/bcmwl-6.30.223.248/master/patches/0015-CFG80211_BSS_FTYPE_UNKNOWN-linux-3.18.0.patch +--- + src/wl/sys/wl_cfg80211_hybrid.c | 6 ++ + 1 file changed, 6 insertions(+) + +diff --git a/src/wl/sys/wl_cfg80211_hybrid.c b/src/wl/sys/wl_cfg80211_hybrid.c +index ea0726f..ee0d3a0 100644 +--- a/amd64/src/wl/sys/wl_cfg80211_hybrid.c b/amd64/src/wl/sys/wl_cfg80211_hybrid.c +@@ -2010,9 +2010,15 @@ static s32 wl_inform_single_bss(struct wl_cfg80211_priv *wl, struct wl_bss_info + + notify_ie = (u8 *)bi + le16_to_cpu(bi-ie_offset); + notify_ielen = le32_to_cpu(bi-ie_length); ++#if LINUX_VERSION_CODE KERNEL_VERSION(3, 18, 0) + cbss = cfg80211_inform_bss(wiphy, channel, (const u8 *)(bi-BSSID.octet), + 0, beacon_proberesp-capab_info, beacon_proberesp-beacon_int, + (const u8 *)notify_ie, notify_ielen, signal, GFP_KERNEL); ++#else ++ cbss = cfg80211_inform_bss(wiphy, channel, CFG80211_BSS_FTYPE_UNKNOWN, (const u8 *)(bi-BSSID.octet), ++ 0, beacon_proberesp-capab_info, beacon_proberesp-beacon_int, ++ (const u8 *)notify_ie, notify_ielen, signal, GFP_KERNEL); ++#endif + + if (unlikely(!cbss)) + return -ENOMEM; +-- +1.9.1 + diff -Nurd broadcom-sta_6.30.223.248-3.debian/debian/patches/11-0016-repair-make-warnings.patch broadcom-sta_6.30.223.248-3.2.debian/debian/patches/11-0016-repair-make-warnings.patch --- broadcom-sta_6.30.223.248-3.debian/debian/patches/11-0016-repair-make-warnings.patch 1970-01-01 01:00:00.0 +0100 +++ broadcom-sta_6.30.223.248-3.2.debian/debian/patches/11-0016-repair-make-warnings.patch 2015-04-29 11:58:30.0 +0200 @@ -0,0 +1,59 @@ +From 92fc12028553831a87cfa87ffa8d676ab0f60522 Mon Sep 17 00:00:00 2001 +From: Simon Eisenmann si...@longsleep.org +Date: Sat, 14 Mar 2015 15:02:08 +0100 +Subject: [PATCH] Repair make warnings + +Modified by Eduard Bloch bl...@debian.org to align with Debian package broadcom-sta patches. + +Orginal author: Krzysztof Kolasa +Source: https://raw.githubusercontent.com/kolasa/bcmwl-6.30.223.248/9fafc1faa6dc410bf8aba340a7929f404c73d30e/patches/0016-repair-make-warnings.patch +--- + src/wl/sys/wl_cfg80211_hybrid.c | 13 - + 1 file changed, 12 insertions(+), 1 deletion(-) + +diff --git a/src/wl/sys/wl_cfg80211_hybrid.c b/src/wl/sys/wl_cfg80211_hybrid.c +index ea0726f..b265e25 100644 +--- a/amd64/src/wl/sys/wl_cfg80211_hybrid.c b/amd64/src/wl/sys/wl_cfg80211_hybrid.c +@@ -63,8 +63,13 @@ static s32
Bug#773713: NMU interdiff
Hi! Thank you very much for adding this patch! Greetings, Bruno On 2015-05-06 21:38, Eduard Bloch wrote: On Wed, 29 Apr 2015 16:44:14 +0200 Bruno Bierbaumer l...@bierbaumer.net wrote: Hello! I would say it fits in here, because the problem first appears with Linux 3.18 and the bug is about supporting Linux 3.18+. Fixing a bug that we know of as we go also sounds like a good idea. Also just my opinion. Ok, as announced, I added the missing patch. Updated diff file attached, just uploaded to 2-day DELAYED queue. Regards, Eduard. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#773713: NMU interdiff
DKMS make.log for broadcom-sta-6.30.223.248 for kernel 4.1.0-rc1 (x86_64) Sat May 2 20:28:51 CEST 2015 /bin/sh: line 0: [: : integer expression expected /bin/sh: line 0: [: : integer expression expected I cannot reproduce this with 4.1.0-rc2 and dkms. Might be a locale issues. If you still get it with 4.1.0-rc2, consider reporting that as dkms bug, IMHO. I got this same warning against kernel 3.19 so I don't think it is specific to a kernel version. Anyway it did not break my build. Cheers, Jeremy
Bug#773713: NMU interdiff
Hi, I'm trying out the interdiff by Eduard but get the below error when trying to install the new package. Do you guys know what's wrong? DKMS make.log for broadcom-sta-6.30.223.248 for kernel 4.1.0-rc1 (x86_64) Sat May 2 20:28:51 CEST 2015 /bin/sh: line 0: [: : integer expression expected /bin/sh: line 0: [: : integer expression expected Wireless Extension is the only possible API for this kernel version Using Wireless Extension API KBUILD_NOPEDANTIC=1 make -C /lib/modules/4.1.0-rc1/build M=`pwd` make[1]: Entering directory '/home/anders/git/linux' CFG80211 API is prefered for this kernel version Using CFG80211 API Kernel architecture is X86_64 LD /var/lib/dkms/broadcom-sta/6.30.223.248/build/built-in.o CC [M] /var/lib/dkms/broadcom-sta/ 6.30.223.248/build/src/shared/linux_osl.o CC [M] /var/lib/dkms/broadcom-sta/ 6.30.223.248/build/src/wl/sys/wl_linux.o CC [M] /var/lib/dkms/broadcom-sta/6.30.223.248/build/src/wl/sys/wl_iw.o CC [M] /var/lib/dkms/broadcom-sta/ 6.30.223.248/build/src/wl/sys/wl_cfg80211_hybrid.o LD [M] /var/lib/dkms/broadcom-sta/6.30.223.248/build/wl.o Building modules, stage 2. CFG80211 API is prefered for this kernel version Using CFG80211 API Kernel architecture is X86_64 MODPOST 1 modules FATAL: modpost: GPL-incompatible module wl.ko uses GPL-only symbol 'cpu_tss' scripts/Makefile.modpost:90: recipe for target '__modpost' failed make[2]: *** [__modpost] Error 1 Makefile:1386: recipe for target 'modules' failed make[1]: *** [modules] Error 2 make[1]: Leaving directory '/home/anders/git/linux' Makefile:158: recipe for target 'all' failed make: *** [all] Error 2 Br, Anders 2015-04-29 16:44 GMT+02:00 Bruno Bierbaumer l...@bierbaumer.net: Hello! I would say it fits in here, because the problem first appears with Linux 3.18 and the bug is about supporting Linux 3.18+. Fixing a bug that we know of as we go also sounds like a good idea. Also just my opinion. Sounds like a good plan to wait for any reaction by the maintainer. Greetings, Bruno On 2015-04-29 16:36, Eduard Bloch wrote: Hallo, * Bruno Bierbaumer [Wed, Apr 29 2015, 02:49:23PM]: Yes, there are many reports about this lockup. Maybe, but as said, it was not strictly in the scope of this bugreport. It deserves a new bug report with important severity, IMHO. Original one is here: https://bugs.gentoo.org/show_bug.cgi?id=523326#c24 I don't think it 3.18 specific and Gentoo and Arch are definitely also applying the patch to broadcom-sta for all kernel versions. Ok, sounds plausible. I would wait a couple of days, maybe $maintainer will react and do something about it. Please remind me next weekend if nothing happened in the meantime. For me I could always reproduce the lock up by: - Starting a heavy download - Disconnecting the WiFi through NetworkManager or going to suspend Interesting... maybe my laptop is just too slow and this issue is triggered by concurency problems? Anyhow, the report above sounds convincing enough. Regards, Eduard. -- To unsubscribe, send mail to 773713-unsubscr...@bugs.debian.org.
Bug#773713: NMU interdiff
Dear Maintainer, after a long period of inactivity, I decided to NMU this package with the mentioned fixes and also kernel 4.0 support. The NMU is not effective yet, the package is in the 10-day DELAYED queue so you have lots of times to abort this action by uploading an official version. Interdiff is attached. Best Regards, Eduard. diff -Nurd broadcom-sta-6.30.223.248.orig/debian/changelog broadcom-sta-6.30.223.248/debian/changelog --- broadcom-sta-6.30.223.248.orig/debian/changelog 2014-12-07 15:07:56.0 +0100 +++ broadcom-sta-6.30.223.248/debian/changelog 2015-04-29 12:35:54.0 +0200 @@ -1,3 +1,13 @@ +broadcom-sta (6.30.223.248-3.1) unstable; urgency=low + + * Non-maintainer upload. + * Added Canonical patches to support Linux kernel versions up to 4.0.0 +(closes: #773713) + * Set some variables right for kernel-package/module-assistant usage, +to build correctly against headers without having to boot that kernel + + -- Eduard Bloch bl...@debian.org Wed, 29 Apr 2015 11:50:17 +0200 + broadcom-sta (6.30.223.248-3) unstable; urgency=medium * Synced supported chipsets list with README.txt file (Closes: #762954). diff -Nurd broadcom-sta-6.30.223.248.orig/debian/patches/10-0015-add-support-for-Linux-3.18.patch broadcom-sta-6.30.223.248/debian/patches/10-0015-add-support-for-Linux-3.18.patch --- broadcom-sta-6.30.223.248.orig/debian/patches/10-0015-add-support-for-Linux-3.18.patch 1970-01-01 01:00:00.0 +0100 +++ broadcom-sta-6.30.223.248/debian/patches/10-0015-add-support-for-Linux-3.18.patch 2015-04-29 11:57:53.0 +0200 @@ -0,0 +1,38 @@ +From 8b6f3f87c81fa35eef24831e9a93eff1e6e1444f Mon Sep 17 00:00:00 2001 +From: Alberto Milone alberto.mil...@canonical.com +Date: Mon, 10 Nov 2014 09:22:09 +0100 +Subject: [PATCH 1/1] Update cfg80211_inform_bss() to use + CFG80211_BSS_FTYPE_UNKNOWN + +This is only necessary with Linux = 3.18. +Modified by Eduard Bloch bl...@debian.org to align with Debian package broadcom-sta patches. + +Original author: Krzysztof Kolasa +Original Source: https://raw.githubusercontent.com/kolasa/bcmwl-6.30.223.248/master/patches/0015-CFG80211_BSS_FTYPE_UNKNOWN-linux-3.18.0.patch +--- + src/wl/sys/wl_cfg80211_hybrid.c | 6 ++ + 1 file changed, 6 insertions(+) + +diff --git a/src/wl/sys/wl_cfg80211_hybrid.c b/src/wl/sys/wl_cfg80211_hybrid.c +index ea0726f..ee0d3a0 100644 +--- a/amd64/src/wl/sys/wl_cfg80211_hybrid.c b/amd64/src/wl/sys/wl_cfg80211_hybrid.c +@@ -2010,9 +2010,15 @@ static s32 wl_inform_single_bss(struct wl_cfg80211_priv *wl, struct wl_bss_info + + notify_ie = (u8 *)bi + le16_to_cpu(bi-ie_offset); + notify_ielen = le32_to_cpu(bi-ie_length); ++#if LINUX_VERSION_CODE KERNEL_VERSION(3, 18, 0) + cbss = cfg80211_inform_bss(wiphy, channel, (const u8 *)(bi-BSSID.octet), + 0, beacon_proberesp-capab_info, beacon_proberesp-beacon_int, + (const u8 *)notify_ie, notify_ielen, signal, GFP_KERNEL); ++#else ++ cbss = cfg80211_inform_bss(wiphy, channel, CFG80211_BSS_FTYPE_UNKNOWN, (const u8 *)(bi-BSSID.octet), ++ 0, beacon_proberesp-capab_info, beacon_proberesp-beacon_int, ++ (const u8 *)notify_ie, notify_ielen, signal, GFP_KERNEL); ++#endif + + if (unlikely(!cbss)) + return -ENOMEM; +-- +1.9.1 + diff -Nurd broadcom-sta-6.30.223.248.orig/debian/patches/11-0016-repair-make-warnings.patch broadcom-sta-6.30.223.248/debian/patches/11-0016-repair-make-warnings.patch --- broadcom-sta-6.30.223.248.orig/debian/patches/11-0016-repair-make-warnings.patch 1970-01-01 01:00:00.0 +0100 +++ broadcom-sta-6.30.223.248/debian/patches/11-0016-repair-make-warnings.patch 2015-04-29 11:58:30.0 +0200 @@ -0,0 +1,59 @@ +From 92fc12028553831a87cfa87ffa8d676ab0f60522 Mon Sep 17 00:00:00 2001 +From: Simon Eisenmann si...@longsleep.org +Date: Sat, 14 Mar 2015 15:02:08 +0100 +Subject: [PATCH] Repair make warnings + +Modified by Eduard Bloch bl...@debian.org to align with Debian package broadcom-sta patches. + +Orginal author: Krzysztof Kolasa +Source: https://raw.githubusercontent.com/kolasa/bcmwl-6.30.223.248/9fafc1faa6dc410bf8aba340a7929f404c73d30e/patches/0016-repair-make-warnings.patch +--- + src/wl/sys/wl_cfg80211_hybrid.c | 13 - + 1 file changed, 12 insertions(+), 1 deletion(-) + +diff --git a/src/wl/sys/wl_cfg80211_hybrid.c b/src/wl/sys/wl_cfg80211_hybrid.c +index ea0726f..b265e25 100644 +--- a/amd64/src/wl/sys/wl_cfg80211_hybrid.c b/amd64/src/wl/sys/wl_cfg80211_hybrid.c +@@ -63,8 +63,13 @@ static s32 wl_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed); + static s32 wl_cfg80211_join_ibss(struct wiphy *wiphy, struct net_device *dev, +struct cfg80211_ibss_params *params); + static s32 wl_cfg80211_leave_ibss(struct wiphy *wiphy, struct net_device *dev); ++#if LINUX_VERSION_CODE KERNEL_VERSION(3, 16, 0) + static s32 wl_cfg80211_get_station(struct wiphy *wiphy, +
Bug#773713: NMU interdiff
Hallo Eduard, Thank you for working on this bug! Did you forgot this patch: https://gist.github.com/hobarrera/ac0e6225210ac5bb13f6#file-broadcom-sta-6-30-223-248-linux-3-18-null-pointer-crash-patch in the NMU? Greetings, Bruno On 2015-04-29 12:54, Eduard Bloch wrote: Dear Maintainer, after a long period of inactivity, I decided to NMU this package with the mentioned fixes and also kernel 4.0 support. The NMU is not effective yet, the package is in the 10-day DELAYED queue so you have lots of times to abort this action by uploading an official version. Interdiff is attached. Best Regards, Eduard. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#773713: NMU interdiff
Hallo, * Bruno Bierbaumer [Wed, Apr 29 2015, 01:14:36PM]: Hallo Eduard, Thank you for working on this bug! Did you forgot this patch: https://gist.github.com/hobarrera/ac0e6225210ac5bb13f6#file-broadcom-sta-6-30-223-248-linux-3-18-null-pointer-crash-patch in the NMU? Well, kind of. I have put it back in the stack because I wanted to understand what it does, and forgot it then :-). But seriously, do you have an original issue report of any kind? This issue is out of scope for this bug report and I also cannot reproduce any crash with kernel 4.0, and if the patch is kernel 3.18 specific... then, who cares? Regards, Eduard. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#773713: NMU interdiff
Yes, there are many reports about this lockup. Original one is here: https://bugs.gentoo.org/show_bug.cgi?id=523326#c24 I don't think it 3.18 specific and Gentoo and Arch are definitely also applying the patch to broadcom-sta for all kernel versions. See: - https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-wireless/broadcom-sta/files/broadcom-sta-6.30.223.248-r3-linux-3.15-3.18.patch?view=markup - https://aur.archlinux.org/packages/broadcom-wl-dkms/ (in linux-recent.patch) I could reproduce this bug all the time when I didn't had the patch applied. At the moment I am running 3.19 with the patch applied and I don't see any side effects :). For me I could always reproduce the lock up by: - Starting a heavy download - Disconnecting the WiFi through NetworkManager or going to suspend -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#773713: NMU interdiff
Hello! I would say it fits in here, because the problem first appears with Linux 3.18 and the bug is about supporting Linux 3.18+. Fixing a bug that we know of as we go also sounds like a good idea. Also just my opinion. Sounds like a good plan to wait for any reaction by the maintainer. Greetings, Bruno On 2015-04-29 16:36, Eduard Bloch wrote: Hallo, * Bruno Bierbaumer [Wed, Apr 29 2015, 02:49:23PM]: Yes, there are many reports about this lockup. Maybe, but as said, it was not strictly in the scope of this bugreport. It deserves a new bug report with important severity, IMHO. Original one is here: https://bugs.gentoo.org/show_bug.cgi?id=523326#c24 I don't think it 3.18 specific and Gentoo and Arch are definitely also applying the patch to broadcom-sta for all kernel versions. Ok, sounds plausible. I would wait a couple of days, maybe $maintainer will react and do something about it. Please remind me next weekend if nothing happened in the meantime. For me I could always reproduce the lock up by: - Starting a heavy download - Disconnecting the WiFi through NetworkManager or going to suspend Interesting... maybe my laptop is just too slow and this issue is triggered by concurency problems? Anyhow, the report above sounds convincing enough. Regards, Eduard. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#773713: NMU interdiff
Hallo, * Bruno Bierbaumer [Wed, Apr 29 2015, 02:49:23PM]: Yes, there are many reports about this lockup. Maybe, but as said, it was not strictly in the scope of this bugreport. It deserves a new bug report with important severity, IMHO. Original one is here: https://bugs.gentoo.org/show_bug.cgi?id=523326#c24 I don't think it 3.18 specific and Gentoo and Arch are definitely also applying the patch to broadcom-sta for all kernel versions. Ok, sounds plausible. I would wait a couple of days, maybe $maintainer will react and do something about it. Please remind me next weekend if nothing happened in the meantime. For me I could always reproduce the lock up by: - Starting a heavy download - Disconnecting the WiFi through NetworkManager or going to suspend Interesting... maybe my laptop is just too slow and this issue is triggered by concurency problems? Anyhow, the report above sounds convincing enough. Regards, Eduard. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
