Bug#774519: unblock: netscript-2.4/5.4.8
Control: tag -1 moreinfo On Thu, Jan 29, 2015 at 08:27:40PM +1300, Matt Grant wrote: Below is tested by installing ifupdown and then netscript-2.4 repeatedly under systemd, and checked for booting correctly under sysvinit on Debian Sid This is a vast improvement, thanks for persisting with it. One point: your README.Debian still refers to sysvinit support being removed: @@ -35,12 +21,8 @@ CONFIGURATION - -NB: To get this package working, for sysvinit: - -you will HAVE to edit /etc/network/interfaces removing/commenting out all -interfacesi (or declaure as inet/inet6 manual'), and edit -/etc/default/networking by inserting 'exit 0' near the top before the first -commands in the file. +Sysvinit is no longer supported, thanks to ome irresolvable boot order +dependency loops with the ifupdown package. For systemd: Do you want to correct that in another upload or would you rather have this unblocked first? Thanks, -- Jonathan Wiltshire j...@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51 signature.asc Description: Digital signature
Bug#774519: unblock: netscript-2.4/5.4.8
Hi! Could you please unblock netscript-2.4 v 5.4.10 in sid for migration to Jessie/Testing, and cancel autoremoval from Jessie/Testing Below is tested by installing ifupdown and then netscript-2.4 repeatedly under systemd, and checked for booting correctly under sysvinit on Debian Sid Have included /etc/inserv.conf.d/netscript file: # # Low level networking (ethernet card) # $network+netscript which is needed for insserv to work properly with ifupdown removed and removed # Should-Start: ifupdown # X-Start-Before:networking from the INIT INFO at the top of /etc/init.d/netscript: ### BEGIN INIT INFO # Provides: netscript # Required-Start:mountkernfs $local_fs # Required-Stop: $local_fs # Default-Start: S # Default-Stop: 0 6 # Short-Description: Raise network interfaces, and setup iptables. # Description: Raise network interfaces, starting any required networking # daemons like pppd, DHCP client or openvpn, and setup iptables. ### END INIT INFO # Viola! Boot dependency loop gone! Best Regards, Matt Grant On Sun, 2015-01-04 at 00:15 +, Jonathan Wiltshire wrote: Control: tag -1 moreinfo On Sun, Jan 04, 2015 at 10:41:18AM +1300, Matthew Grant wrote: 2 serious bugs have been fixed in 5.4.8: #717871 netscript: fails to install due to insserv rejecting the script header: There is a loop between service networking and netscript if started This is due to the ifupdown providing insserv support for $network, and netscript-2.4 also doing the same. Both packages configure networking. The setting for $network is configured in /etc/insserv/insserv.conf, but there is no way of overriding that, is there? This is fixed by removing init.d support for insserv/sysvinit, and depending on systemd-sysv This is an interesting problem. You already conflict with ifupdown, and I'm not all that keen on requiring systemd as an alternative to fixing that loop. On my system at least, /etc/insserv.conf defines network as follows: $network +networking +ifupdown so ifupdown is already optional. Can you not ship a snippet in /etc/insserv.conf.d that overrides that to something like: $network +networking +ifupdown +netscript or have I misunderstood the problem? I suspect ifupdown will have to be purged, not merely removed, to resolve the loop properly, or the override not include +ifupdown. Note that I've never tried to do this, I'm just going by the documentation. #773772/#773773 netscript-2.4: Interace names with '-' in them cannot be set up, and network configuration fails. Netscript overloads variable names by adding the interface name at the start. '-' are not acceptable parts of /bin/bash environment variable names. The changes for this convert '-' in interface names to '_', which also should be done to interface names in /etc/netscript/network.conf This bug was fixed in 5.4.7 and I forgot to put a 'Closes' in the changelog and had to close #773772/3 via the bugs.debian.org control interface. Those bugs are indeed closed, but you haven't given the BTS any versioning information so they still affect version 5.4.8. Until that's fixed it won't migrate. A small fix involving quoting misplacement to do with bridge configuration is also in 5.4.8. I know this is a minor change that fixes an 'Important' level bug I found. Mm, ok. -- Matt Grant, Debian and Linux Systems Administration and Consulting Mobile: 021 0267 0578 Email: m...@mattgrant.net.nz signature.asc Description: This is a digitally signed message part
Bug#774519: unblock: netscript-2.4/5.4.8
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package netscript-2.4
2 serious bugs have been fixed in 5.4.8:
#717871 netscript: fails to install due to insserv rejecting the script
header: There is a loop between service networking and netscript if started
This is due to the ifupdown providing insserv support for $network, and
netscript-2.4 also doing the same. Both packages configure networking. The
setting for $network is configured in /etc/insserv/insserv.conf, but there is
no way of overriding that, is there?
This is fixed by removing init.d support for insserv/sysvinit, and depending on
systemd-sysv
#773772/#773773 netscript-2.4: Interace names with '-' in them cannot be set
up, and network configuration fails.
Netscript overloads variable names by adding the interface name at the start.
'-' are not acceptable parts of /bin/bash environment variable names. The
changes for this convert '-' in interface names to '_', which also should be
done to interface names in /etc/netscript/network.conf
This bug was fixed in 5.4.7 and I forgot to put a 'Closes' in the changelog and
had to close #773772/3 via the bugs.debian.org control interface.
A small fix involving quoting misplacement to do with bridge configuration is
also in 5.4.8. I know this is a minor change that fixes an 'Important' level
bug I found.
I am the upstream author for Netscript and a Debian Developer (since the early
2000s), and upstream is actually released directly into Debian, hence no -1 -2
package release levels. It was one of my first Debian packages. I would
release it differently now. It has functional heurestics that would be nice to
have in ifupdown. The useful iptables handling is available as a seperate
package netscript-ipfilter, which is better than iptables-persistent as it has
history, and 'helper' chains.
The above fixes are all minor 5.4.x version bug fixes. Note that new 5.x
functionality has been added. Please unblock the package, even though it has
the bridge handling quoting fixes.
All the above has been tested on an openstack server on Jessie/unstable I am
setting up to learn about Openstack
Changlog entries for 5.4.7 and 5.4.8
(include/attach the debdiff against the package in testing)
unblock netscript-2.4/5.4.8
-- System Information:
Debian Release: 8.0
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_NZ.utf8, LC_CTYPE=en_NZ.utf8 (charmap=UTF-8)
diff -Nru netscript-2.4-5.4.6/debian/changelog netscript-2.4-5.4.8/debian/changelog
--- netscript-2.4-5.4.6/debian/changelog 2014-12-22 19:48:40.0 +1300
+++ netscript-2.4-5.4.8/debian/changelog 2014-12-23 18:05:08.0 +1300
@@ -1,6 +1,21 @@
+netscript-2.4 (5.4.8) unstable; urgency=medium
+
+ * Remove sysvint/inserv support for package. (Closes: #771871)
+Revert totally removing ifupdown emulation/Provides as this breaks too
+many things. This just removes the dependency loop in /etc/init.d files
+which is unfixable.
+
+ -- Matthew Grant m...@mattgrant.net.nz Tue, 23 Dec 2014 17:50:04 +1300
+
+netscript-2.4 (5.4.7) unstable; urgency=medium
+
+ * Convert '-' in interface names to '_' (Closes: #773772)
+
+ -- Matthew Grant m...@mattgrant.net.nz Mon, 22 Dec 2014 21:10:30 +1300
+
netscript-2.4 (5.4.6) unstable; urgency=medium
- * Remove ifupdown emulation (Closes: #771871)
+ * Remove ifupdown emulation
-- Matthew Grant m...@mattgrant.net.nz Mon, 22 Dec 2014 19:48:20 +1300
diff -Nru netscript-2.4-5.4.6/debian/control netscript-2.4-5.4.8/debian/control
--- netscript-2.4-5.4.6/debian/control 2014-12-22 19:50:08.0 +1300
+++ netscript-2.4-5.4.8/debian/control 2014-12-23 18:06:20.0 +1300
@@ -7,8 +7,8 @@
Package: netscript-2.4
Architecture: all
-Depends: iproute2 | iproute (= 20001007), bridge-utils (= 0.9.3), iptables, netbase, bash (= 2.03), isc-dhcp-client | dhcpcd | pump, ${misc:Depends}
-Provides: netscript
+Depends: iproute2 | iproute (= 20001007), bridge-utils (= 0.9.3), iptables, netbase, bash (= 2.03), isc-dhcp-client | dhcpcd | pump, systemd-sysv, ${misc:Depends}
+Provides: netscript, ifupdown
Conflicts: netscript, netscript-2.2, ifupdown, netscript-ipfilter
Replaces: netscript, ifupdown
Suggests: whereami, dnsmasq, resolvconf, wpasupplicant, wicd, quagga, radvd, bird
diff -Nru netscript-2.4-5.4.6/debian/netscript-2.4.links netscript-2.4-5.4.8/debian/netscript-2.4.links
--- netscript-2.4-5.4.6/debian/netscript-2.4.links 2014-12-22 19:46:26.0 +1300
+++ netscript-2.4-5.4.8/debian/netscript-2.4.links 2014-12-23 17:43:57.0 +1300
@@ -2,3 +2,7 @@
usr/share/man/man5/netscript-2.4.conf.5.gz usr/share/man/man5/if.conf.5.gz
usr/share/man/man5/netscript-2.4.conf.5.gz usr/share/man/man5/qos.conf.5.gz
usr/share/man/man5/netscript-2.4.conf.5.gz
Bug#774519: unblock: netscript-2.4/5.4.8
Control: tag -1 moreinfo On Sun, Jan 04, 2015 at 10:41:18AM +1300, Matthew Grant wrote: 2 serious bugs have been fixed in 5.4.8: #717871 netscript: fails to install due to insserv rejecting the script header: There is a loop between service networking and netscript if started This is due to the ifupdown providing insserv support for $network, and netscript-2.4 also doing the same. Both packages configure networking. The setting for $network is configured in /etc/insserv/insserv.conf, but there is no way of overriding that, is there? This is fixed by removing init.d support for insserv/sysvinit, and depending on systemd-sysv This is an interesting problem. You already conflict with ifupdown, and I'm not all that keen on requiring systemd as an alternative to fixing that loop. On my system at least, /etc/insserv.conf defines network as follows: $network +networking +ifupdown so ifupdown is already optional. Can you not ship a snippet in /etc/insserv.conf.d that overrides that to something like: $network +networking +ifupdown +netscript or have I misunderstood the problem? I suspect ifupdown will have to be purged, not merely removed, to resolve the loop properly, or the override not include +ifupdown. Note that I've never tried to do this, I'm just going by the documentation. #773772/#773773 netscript-2.4: Interace names with '-' in them cannot be set up, and network configuration fails. Netscript overloads variable names by adding the interface name at the start. '-' are not acceptable parts of /bin/bash environment variable names. The changes for this convert '-' in interface names to '_', which also should be done to interface names in /etc/netscript/network.conf This bug was fixed in 5.4.7 and I forgot to put a 'Closes' in the changelog and had to close #773772/3 via the bugs.debian.org control interface. Those bugs are indeed closed, but you haven't given the BTS any versioning information so they still affect version 5.4.8. Until that's fixed it won't migrate. A small fix involving quoting misplacement to do with bridge configuration is also in 5.4.8. I know this is a minor change that fixes an 'Important' level bug I found. Mm, ok. -- Jonathan Wiltshire j...@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51 signature.asc Description: Digital signature
