Bug#775341: chuck: new upstream version 1.3.5.0 available

2017-11-17 Thread Paul Brossier 
Hi Christoph,

thanks, long due update indeed, I will take a look ASAP.

Did you check the code in the new version complies with the DFSG ?

Best, piem

On 11/15/2017 06:46 PM, Christoph Biedl wrote:
> retitle 775341 chuck: new upstream version 1.3.5.2 available
> tags 775341 patch
> thanks
> 
>> There is a new upstream version available: 1.3.5.0
>> http://chuck.cs.princeton.edu/release/
> 
> Now it's already 1.3.5.2 ...
> 
> Somebody asked me about the efforts needed to bring chuck to the latest
> upstream version in order to benefit from new features. Turns out it's
> not *that* difficult. So in order to avoid work is done twice, the diff
> on debian/ is attached. For the upstream tarball, use uscan or plain
> wget on the upstream server and rename.
> 
> While declared a NMU, this diff goes far beyond that:
> 
> * Packaging has been modernized in every regard, also the previous
>   modifications went upstream, were no longer needed, or could be
>   worked around by a .install file.
> * Two commits were cherry-picked that fix obvious bugs, reported by gcc.
> * Repacking no longer happens as I fail to see why the affected files
>   are not dfsg compliant, I might be wrong.
> * Support for OSS was removed upstream, so here as well. The Linux
>   kernel will drop it soon.
> * Support for pulse(audio) was added.
> * The examples/ directory is now shipped in a separate -data package as
>   suggested by lintian, to avoid huge amounts of arch-independent
>   data in a arch-dependent package.
> 
> Status: Builds, and the pulse version works fine.
> 
> Things to do:
> 
> # Blocker
> 
> * Review license status of each and every file, update
>   debian/copyright where required.
> 
> # Upstream
> 
> * Ask upstream for license clarification of src/util_sndfile.c and
>   some more since it seems the chuck license was prepended
>   automatically.
> * Ask upstream to fix the FSF address in the license statements.
> * Ask upstream to use trusted certificates on their web server, then
>   switch to secure URLs in debian/control and elsewhere.
> * Bring the typo fixes upstream. There are more in comments.
> 
> # Packaging
> 
> * Perhaps there are nicer ways to write debian/rules
> * Is there really the need for three chuck binaries?
> * Are there more applications to build for, see ?
> * Something else worth to be cherry-picked from upstream git at
>   ?
> 
> Cheers,
> 
> Christoph
> 



signature.asc
Description: OpenPGP digital signature

Bug#775341: chuck: new upstream version 1.3.5.0 available

2017-11-15 Thread Christoph Biedl 
retitle 775341 chuck: new upstream version 1.3.5.2 available
tags 775341 patch
thanks

> There is a new upstream version available: 1.3.5.0
> http://chuck.cs.princeton.edu/release/

Now it's already 1.3.5.2 ...

Somebody asked me about the efforts needed to bring chuck to the latest
upstream version in order to benefit from new features. Turns out it's
not *that* difficult. So in order to avoid work is done twice, the diff
on debian/ is attached. For the upstream tarball, use uscan or plain
wget on the upstream server and rename.

While declared a NMU, this diff goes far beyond that:

* Packaging has been modernized in every regard, also the previous
  modifications went upstream, were no longer needed, or could be
  worked around by a .install file.
* Two commits were cherry-picked that fix obvious bugs, reported by gcc.
* Repacking no longer happens as I fail to see why the affected files
  are not dfsg compliant, I might be wrong.
* Support for OSS was removed upstream, so here as well. The Linux
  kernel will drop it soon.
* Support for pulse(audio) was added.
* The examples/ directory is now shipped in a separate -data package as
  suggested by lintian, to avoid huge amounts of arch-independent
  data in a arch-dependent package.

Status: Builds, and the pulse version works fine.

Things to do:

# Blocker

* Review license status of each and every file, update
  debian/copyright where required.

# Upstream

* Ask upstream for license clarification of src/util_sndfile.c and
  some more since it seems the chuck license was prepended
  automatically.
* Ask upstream to fix the FSF address in the license statements.
* Ask upstream to use trusted certificates on their web server, then
  switch to secure URLs in debian/control and elsewhere.
* Bring the typo fixes upstream. There are more in comments.

# Packaging

* Perhaps there are nicer ways to write debian/rules
* Is there really the need for three chuck binaries?
* Are there more applications to build for, see ?
* Something else worth to be cherry-picked from upstream git at
  ?

Cheers,

Christoph
diff --git a/debian/changelog b/debian/changelog
index 1029151..0f0f11c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+chuck (1.3.5.2-0.1) unstable; urgency=medium
+
+  * Non-maintainer upload
+  * New upstream version 1.3.5.2. Closes: #775341
+- Support for oss was dropped upstream
+- Support for pulseaudio added
+  * Modernize packaging
+  * Ship examples and data in a separate package
+
+ -- Christoph Biedl   Tue, 14 Nov 2017 21:17:43 +0100
+
 chuck (1.2.0.8.dfsg-1.5) unstable; urgency=medium
 
   * Non-maintainer upload.
@@ -58,7 +69,7 @@ chuck (1.2.0.7.dfsg-1) unstable; urgency=low
 
   * New upstream release, update debian/rules accordingly.
   * Removal src/util_opsc.{cpp,h} due to non DFSG compliant license.
-  * Upload to debian (closes: #267626) 
+  * Upload to debian (closes: #267626)
 
  -- Paul Brossier   Thu,  5 Oct 2006 18:44:33 +0200
 
@@ -125,4 +136,3 @@ chuck (1.1.4.3-1) unstable; urgency=low
   * Added missing manpage and watch file.
 
  -- Paul Brossier   Tue, 27 Jul 2004 00:48:01 +0200
-
diff --git a/debian/chuck-data.examples b/debian/chuck-data.examples
new file mode 100644
index 000..a99a719
--- /dev/null
+++ b/debian/chuck-data.examples
@@ -0,0 +1,2 @@
+
+examples/*
diff --git a/debian/chuck.docs b/debian/chuck.docs
new file mode 100644
index 000..50f33da
--- /dev/null
+++ b/debian/chuck.docs
@@ -0,0 +1,3 @@
+README
+THANKS
+TODO
diff --git a/debian/chuck.install b/debian/chuck.install
new file mode 100644
index 000..5d2ee40
--- /dev/null
+++ b/debian/chuck.install
@@ -0,0 +1,4 @@
+
+build/chuck.alsausr/bin/
+build/chuck.pulse   usr/bin/
+chuck   usr/bin/
diff --git a/debian/chuck.links b/debian/chuck.links
index 3492ccd..cc2adbc 100644
--- a/debian/chuck.links
+++ b/debian/chuck.links
@@ -1,2 +1,3 @@
-usr/share/man/man1/chuck.1.gz usr/share/man/man1/chuck.oss.1.gz
-usr/share/man/man1/chuck.1.gz usr/share/man/man1/chuck.alsa.1.gz
+
+usr/share/man/man1/chuck.1.gz   usr/share/man/man1/chuck.alsa.1.gz
+usr/share/man/man1/chuck.1.gz   usr/share/man/man1/chuck.pulse.1.gz
diff --git a/debian/chuck.manpages b/debian/chuck.manpages
new file mode 100644
index 000..3ef41fc
--- /dev/null
+++ b/debian/chuck.manpages
@@ -0,0 +1 @@
+build/chuck.1
diff --git a/debian/chuck.sgml b/debian/chuck.sgml
index 83e29b2..e8f3fba 100644
--- a/debian/chuck.sgml
+++ b/debian/chuck.sgml
@@ -132,7 +132,7 @@ program is running, without stopping or restarting.
 
 Use  for jack audio interfaces,
 .alsa to access alsa devices,
-and .oss to access oss devices.
+and .pulse to access pulse devices.
 
   
   
diff --git a/debian/control b/debian/control
index cbbe6d4..b63f0cf 100644
--- a/debian/control
+++ b/debian/control
@@ -1,15 +1,24 @@
 Source: chuck
-Section: sound
-Priority:

Bug#775341: chuck: new upstream version 1.3.5.0 available

2015-01-14 Thread chuck-debbug@discard.email 
Package: chuck
Version: 1.2.0.8.dfsg-1.4
 
There is a new upstream version available: 1.3.5.0
http://chuck.cs.princeton.edu/release/