Bug#775554: Please update dependency python-aptdaemon-gtk

[Petter Reinholdtsen]

We discussed it on IRC, and Julian had time to test a port to newer
APIs.  The draft untested patch is attached.

-- 
Happy hacking
Petter Reinholdtsen
>From 1eddeb90127be9f3e5cc665ce4fed0d97567 Mon Sep 17 00:00:00 2001
From: Julian Andres Klode 
Date: Thu, 1 Oct 2015 22:54:21 +0200
Subject: [PATCH] Port to GObject introspection

Closes: #775554
---
 debian/control | 18 ++
 isenkramd  | 19 ---
 2 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/debian/control b/debian/control
index d8cb828..224b1d1 100644
--- a/debian/control
+++ b/debian/control
@@ -5,12 +5,13 @@ Maintainer: Petter Reinholdtsen 
 Build-Depends: debhelper (>= 8), po-debconf
 Build-Depends-Indep: dash (>= 0.5.4-12)
   , python (>= 2.6.6-3~)
-  , python-gudev
-  , python-gobject
-  , python-notify
   , aptdaemon
-  , python-aptdaemon-gtk
+  , python-aptdaemon.gtk3widgets
   , libgnome2-perl
+  , python-gi,
+  , gir1.2-gudev-1.0
+  , gir1.2-gtk-3.0
+  , gir1.2-notify-0.7
 Standards-Version: 3.9.5
 XS-Testsuite: autopkgtest
 Vcs-Browser: http://anonscm.debian.org/cgit/collab-maint/isenkram.git
@@ -24,11 +25,12 @@ Architecture: all
 Depends: ${misc:Depends}
   , ${python:Depends}
   , isenkram-cli
-  , python-gudev
-  , python-gobject
-  , python-notify
-  , python-aptdaemon-gtk
+  , python-aptdaemon.gtk3widgets
   , libgnome2-perl
+  , python-gi,
+  , gir1.2-gudev-1.0
+  , gir1.2-gtk-3.0
+  , gir1.2-notify-0.7
 Recommends: aptdaemon
 Description: Suggest packages to install when inserting new hardware (GUI 
popup)
  Try to figure out which packages to suggest for use with a freshly
diff --git a/isenkramd b/isenkramd
index e279e53..5bb1fc9 100755
--- a/isenkramd
+++ b/isenkramd
@@ -28,16 +28,13 @@ __author__ = "Petter Reinholdtsen "
 
 import string
 #import pygtk
-import gtk
-import gobject
-import gudev
-import pynotify
+from gi.repository import GLib, Gtk, GUdev, Notify
 import subprocess
 import glob
 import fnmatch
 import isenkram.lookup
 import aptdaemon.client
-from aptdaemon.gtkwidgets import AptErrorDialog, \
+from aptdaemon.gtk3widgets import AptErrorDialog, \
  AptConfirmDialog, \
  AptProgressDialog
 import aptdaemon.errors
@@ -61,7 +58,7 @@ class AptDaemonGUIClient(object):
 dia = AptConfirmDialog(trans, parent=self.win)
 res = dia.run()
 dia.hide()
-if res != gtk.RESPONSE_OK:
+if res != Gtk.ResponseType.OK:
 return
 self._run_transaction(trans)
 
@@ -88,7 +85,7 @@ class AptDaemonGUIClient(object):
 def __init__(self, package):
 self.win = None
 self.package = package
-self.loop = gobject.MainLoop()
+self.loop = GLib.MainLoop()
 self.ac = aptdaemon.client.AptClient()
 
 def run(self):
@@ -116,12 +113,12 @@ def notify(bus, vendor, device, pkgs):
 print "info: " + text
 
 # Initializite pynotify
-if not pynotify.init("isenkramd"):
+if not Notify.init("isenkramd"):
 return False
 global n
 global npkgs
 npkgs = pkgs
-n = pynotify.Notification(title, text)
+n = Notify.Notification(summary=title, body=text)
 n.set_timeout(1)
 n.add_action("clicked",
  "Please install program(s)",
@@ -203,10 +200,10 @@ def uevent_callback(client, action, device, user_data):
 notify(bus, int(vendorid, 16), int(deviceid, 16), newpkg)
 
 def main():
-client = gudev.Client([])
+client = GUdev.Client()
 client.connect("uevent", uevent_callback, None)
 
-loop = gobject.MainLoop()
+loop = GLib.MainLoop()
 print "info: ready to accept hardware events"
 loop.run()
 
-- 
2.5.3

Bug#775554: Please update dependency python-aptdaemon-gtk

[Niels Thykier]

On Tue, 23 Jun 2015 17:50:55 +0200 Julian Andres Klode j...@debian.org
wrote:
 On Tue, Jun 23, 2015 at 05:48:31PM +0200, Andreas Beckmann wrote:
  [...]
  
  I don't use any (or know anything about any) of these packages - I just
  do some QA :-)
 
 Sure, I meant pere, but forgot to mention it.
 
  
  If you want to speed up src:aptdaemon migrating to testing, you should
  probably NMU isenkram.
 
 I probably should, the aptdaemon upload fixes CVE-2015-1323. 
 
 But I don't know how isenkram works, and I cannot really test it.
 
 -- 
 Julian Andres Klode  - Debian Developer, Ubuntu Member
 
 [...]

Hi,

Are there any updates on this?  It has currently been blocking the fix
for #789162 for a month now.

~Niels


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#775554: Please update dependency python-aptdaemon-gtk

[Julian Andres Klode]

On Tue, Jun 23, 2015 at 05:48:31PM +0200, Andreas Beckmann wrote:
 Control: tag -1 stretch sid
 
 On 2015-06-23 17:04, Julian Andres Klode wrote:
  On Fri, Jun 19, 2015 at 03:54:39PM +0200, Andreas Beckmann wrote:
  With the most recent aptdaemon upload to unstable, the
  python-aptdaemon-gtk package is now gone, making this B-D unavailable.
  
  Sorry, I thought everything looked reasonable and did not notice
  you were still using python-aptdaemon-gtk. If you are using gtk3widgets,
  the update should be just a matter of adjusting your dependencies.
 
 I don't use any (or know anything about any) of these packages - I just
 do some QA :-)

Sure, I meant pere, but forgot to mention it.

 
 If you want to speed up src:aptdaemon migrating to testing, you should
 probably NMU isenkram.

I probably should, the aptdaemon upload fixes CVE-2015-1323. 

But I don't know how isenkram works, and I cannot really test it.

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Be friendly, do not top-post, and follow RFC 1855 Netiquette.
- If you don't I might ignore you.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#775554: Please update dependency python-aptdaemon-gtk

[Julian Andres Klode]

On Fri, Jun 19, 2015 at 03:54:39PM +0200, Andreas Beckmann wrote:
 Control: severity -1 serious
 
 On Sat, 17 Jan 2015 11:23:27 +0100 Marius Kotsbak mar...@kotsbak.com
 wrote:
  python-aptdaemon-gtk is now a transitional package. It could probably
  be replaced by python-aptdaemon.gtk3widgets.
  
  This probably made the package disappear from recent Ubuntu versions,
  as the transitional package is not available there.
 
 With the most recent aptdaemon upload to unstable, the
 python-aptdaemon-gtk package is now gone, making this B-D unavailable.

Sorry, I thought everything looked reasonable and did not notice
you were still using python-aptdaemon-gtk. If you are using gtk3widgets,
the update should be just a matter of adjusting your dependencies.

Please upgrade as soon as possible.

Thanks,

Julian

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Be friendly, do not top-post, and follow RFC 1855 Netiquette.
- If you don't I might ignore you.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#775554: Please update dependency python-aptdaemon-gtk

[Andreas Beckmann]

Control: tag -1 stretch sid

On 2015-06-23 17:04, Julian Andres Klode wrote:
 On Fri, Jun 19, 2015 at 03:54:39PM +0200, Andreas Beckmann wrote:
 With the most recent aptdaemon upload to unstable, the
 python-aptdaemon-gtk package is now gone, making this B-D unavailable.
 
 Sorry, I thought everything looked reasonable and did not notice
 you were still using python-aptdaemon-gtk. If you are using gtk3widgets,
 the update should be just a matter of adjusting your dependencies.

I don't use any (or know anything about any) of these packages - I just
do some QA :-)

If you want to speed up src:aptdaemon migrating to testing, you should
probably NMU isenkram.


Andreas


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#775554: Please update dependency python-aptdaemon-gtk

[Andreas Beckmann]

Control: severity -1 serious

On Sat, 17 Jan 2015 11:23:27 +0100 Marius Kotsbak mar...@kotsbak.com
wrote:
 python-aptdaemon-gtk is now a transitional package. It could probably
 be replaced by python-aptdaemon.gtk3widgets.
 
 This probably made the package disappear from recent Ubuntu versions,
 as the transitional package is not available there.

With the most recent aptdaemon upload to unstable, the
python-aptdaemon-gtk package is now gone, making this B-D unavailable.


Andreas


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#775554: Please update dependency python-aptdaemon-gtk

[Petter Reinholdtsen]

[Marius Kotsbak]
 The attached patch should solve the problem, and let me build the package
 for Ubuntu.

Thank you.

I suspect the long term solution is to switch from aptdaemon to
packagekit, as proposed in URL: https://bugs.debian.org/742429 , but I
do not know the API and have not had time to look at it.

-- 
Happy hacking
Petter Reinholdtsen


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#775554: Please update dependency python-aptdaemon-gtk

[Marius Kotsbak]

Package: isenkram
Version: 0.18

python-aptdaemon-gtk is now a transitional package. It could probably
be replaced by python-aptdaemon.gtk3widgets.

This probably made the package disappear from recent Ubuntu versions,
as the transitional package is not available there.

--

Marius