Bug#776089: libatlas-base-dev: leaves alternatives after purge: /usr/lib/lib{blas, lapack}-3.{so, a}

2015-01-24 Thread Sébastien Villemot
Dear Andreas,

Le vendredi 23 janvier 2015 à 21:08 +0100, Andreas Beckmann a écrit :
 Package: libatlas-base-dev
 Version: 3.10.2-6
 Severity: important
 Tags: patch
 User: debian...@lists.debian.org
 Usertags: piuparts

 during a test with piuparts I noticed your package left unowned files on
 the system after purge, which is a violation of policy 6.8:
 
 https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails
 
 This was observed after an lenny - squeeze - wheezy - jessie upgrade.
 
 The leftover files are actually alternatives that were installed by the
 package but have not been properly removed.

[...]

 Attached is a patch that I have verified in piuparts to fix this issue.
 No intent to NMU, but if you upload this to sid, I'll take care of
 getting it unblocked.

Thanks for your patch. I'm ok to upload this to sid, but I'd prefer to
have the Release Team acknowledgement beforehand. Could you please take
care of that?

Cheers,

-- 
 .''`.Sébastien Villemot
: :' :Debian Developer
`. `' http://sebastien.villemot.name
  `-  GPG Key: 4096R/381A7594


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#776089: libatlas-base-dev: leaves alternatives after purge: /usr/lib/lib{blas, lapack}-3.{so, a}

2015-01-24 Thread Andreas Beckmann
Followup-For: Bug #776089

Hi,

pre-approval request filed: http://bugs.debian.org/776168

Updated debdiff attached (preinst action should be restricted to
install/upgrade).

Andreas
diff -Nru atlas-3.10.2/debian/changelog atlas-3.10.2/debian/changelog
--- atlas-3.10.2/debian/changelog	2014-11-22 13:37:44.0 +0100
+++ atlas-3.10.2/debian/changelog	2015-01-24 23:14:29.0 +0100
@@ -1,3 +1,11 @@
+atlas (3.10.2-7) unstable; urgency=medium
+
+  [ Andreas Beckmann ]
+  * libatlas-base-dev.preinst: Cleanup obsolete alternatives dating back to
+lenny.  (Closes: #776089)
+
+ -- Sébastien Villemot sebast...@debian.org  Sat, 24 Jan 2015 23:06:27 +0100
+
 atlas (3.10.2-6) unstable; urgency=medium
 
   * Add missing files in archdef for mips.
diff -Nru atlas-3.10.2/debian/libatlas-base-dev.preinst atlas-3.10.2/debian/libatlas-base-dev.preinst
--- atlas-3.10.2/debian/libatlas-base-dev.preinst	2014-07-12 12:23:26.0 +0200
+++ atlas-3.10.2/debian/libatlas-base-dev.preinst	2015-01-24 23:11:24.0 +0100
@@ -9,6 +9,13 @@
 update-alternatives --remove libblas.so	/usr/lib/atlas-base/atlas/libblas.so
 fi
 
+# Cleanup obsolete alternatives dating back to lenny
+if [ $1 = install ] || [ $1 = upgrade ]
+then
+update-alternatives --remove libblas-3.so /usr/lib/atlas/libblas.so
+update-alternatives --remove liblapack-3.so /usr/lib/atlas/liblapack.so
+fi
+
 # dh_installdeb will replace this with shell code automatically
 # generated by other debhelper scripts.
 


Bug#776089: libatlas-base-dev: leaves alternatives after purge: /usr/lib/lib{blas, lapack}-3.{so, a}

2015-01-23 Thread Andreas Beckmann
Package: libatlas-base-dev
Version: 3.10.2-6
Severity: important
Tags: patch
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy 6.8:

https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails

This was observed after an lenny - squeeze - wheezy - jessie upgrade.

The leftover files are actually alternatives that were installed by the
package but have not been properly removed.

While there is ongoing discussion how to remove alternatives correctly
(see https://bugs.debian.org/71621 for details) the following strategy
should work for regular cases:
* 'postinst configure' always installs the alternative
* 'prerm remove' removes the alternative
* 'postrm remove' and 'postrm disappear' remove the alternative
In all other cases a maintainer script is invoked (e.g. upgrade,
deconfigure) the alternatives are not modified to preserve user
configuration.
Removing the alternative in 'prerm remove' avoids having a dangling link
once the actual file gets removed, but 'prerm remove' is not called in
all cases (e.g. unpacked but not configured packages or disappearing
packages) so the postrm must remove the alternative again
(update-alternatives gracefully handles removal of non-existing
alternatives).

Note that the arguments for adding and removing alternatives differ, for
removal it's 'update-alternatives --remove name path'.

Filing this as important as having a piuparts clean archive is a release
goal since lenny.

From the attached log (scroll to the bottom...):

5m39.1s INFO: Warning: Package purging left files on system:
  /etc/alternatives/libblas-3.a - /usr/lib/atlas/libblas.a  not owned
  /etc/alternatives/libblas-3.so - /usr/lib/atlas/libblas.sonot owned
  /etc/alternatives/liblapack-3.a - /usr/lib/atlas/liblapack.a  not owned
  /etc/alternatives/liblapack-3.so - /usr/lib/atlas/liblapack.sonot 
owned
  /etc/ld.so.conf.d/atlas.conf   not owned
  /usr/lib/libblas-3.a - /etc/alternatives/libblas-3.a  not owned
  /usr/lib/libblas-3.so - /etc/alternatives/libblas-3.sonot owned
  /usr/lib/liblapack-3.a - /etc/alternatives/liblapack-3.a  not owned
  /usr/lib/liblapack-3.so - /etc/alternatives/liblapack-3.sonot owned

Attached is a patch that I have verified in piuparts to fix this issue.
No intent to NMU, but if you upload this to sid, I'll take care of
getting it unblocked.


cheers,

Andreas


libatlas-base-dev_3.10.2-6.log.gz
Description: application/gzip
diff -Nru atlas-3.10.2/debian/changelog atlas-3.10.2/debian/changelog
--- atlas-3.10.2/debian/changelog	2014-11-22 13:37:44.0 +0100
+++ atlas-3.10.2/debian/changelog	2015-01-23 20:24:54.0 +0100
@@ -1,3 +1,11 @@
+atlas (3.10.2-6.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * libatlas-base-dev: Cleanup obsolete alternatives dating back to lenny.
+(Closes: #xx)
+
+ -- Andreas Beckmann a...@debian.org  Fri, 23 Jan 2015 20:14:42 +0100
+
 atlas (3.10.2-6) unstable; urgency=medium
 
   * Add missing files in archdef for mips.
diff -Nru atlas-3.10.2/debian/libatlas-base-dev.preinst atlas-3.10.2/debian/libatlas-base-dev.preinst
--- atlas-3.10.2/debian/libatlas-base-dev.preinst	2014-07-12 12:23:26.0 +0200
+++ atlas-3.10.2/debian/libatlas-base-dev.preinst	2015-01-23 20:19:46.0 +0100
@@ -9,6 +9,10 @@
 update-alternatives --remove libblas.so	/usr/lib/atlas-base/atlas/libblas.so
 fi
 
+# Cleanup obsolete alternatives dating back to lenny
+update-alternatives --remove libblas-3.so /usr/lib/atlas/libblas.so
+update-alternatives --remove liblapack-3.so /usr/lib/atlas/liblapack.so
+
 # dh_installdeb will replace this with shell code automatically
 # generated by other debhelper scripts.