Bug#780633: f3: please include f3detect and f3fix
Hi, Debian is frozen now. When we have a new stable release (April?), I will migrate all packages from experimental to unstable. So, after this, I will able to upload a revision built by 'make experimental' to experimental. Cheers, Eriberto 2015-03-23 6:07 GMT-03:00 Michal Suchanek michal.sucha...@ruk.cuni.cz: Hello, the experimental binaries would be included in package in Debian experimental so I do not really see a problem here. I prefer them over the 'stable' ones either way. Man pages would be nice to have, yes. Can look into writing some. Thanks Michal Excerpts from Eriberto's message of Sun Mar 22 18:03:33 +0100 2015: Hi Michal, These executables are experimental, not stable, and need manpages. I preferred to wait for a new upstream version to include these elements in the package. Cheers, Eriberto 2015-03-17 4:24 GMT-03:00 Michal Suchanek michal.sucha...@ruk.cuni.cz: Package: f3 Version: 5.0-1 Severity: wishlist Hello, please provide f3detect and f3fix that are built using make experimental. Thanks Michal -- System Information: Debian Release: 8.0 APT prefers testing APT policy: (910, 'testing'), (900, 'stable'), (410, 'unstable'), (400, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.18.0-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8) Shell: /bin/sh linked to /bin/bash Init: systemd (via /run/systemd/system) Versions of packages f3 depends on: ii libc6 2.19-13 f3 recommends no packages. f3 suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780633: f3: please include f3detect and f3fix
Hello, the experimental binaries would be included in package in Debian experimental so I do not really see a problem here. I prefer them over the 'stable' ones either way. Man pages would be nice to have, yes. Can look into writing some. Thanks Michal Excerpts from Eriberto's message of Sun Mar 22 18:03:33 +0100 2015: Hi Michal, These executables are experimental, not stable, and need manpages. I preferred to wait for a new upstream version to include these elements in the package. Cheers, Eriberto 2015-03-17 4:24 GMT-03:00 Michal Suchanek michal.sucha...@ruk.cuni.cz: Package: f3 Version: 5.0-1 Severity: wishlist Hello, please provide f3detect and f3fix that are built using make experimental. Thanks Michal -- System Information: Debian Release: 8.0 APT prefers testing APT policy: (910, 'testing'), (900, 'stable'), (410, 'unstable'), (400, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.18.0-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8) Shell: /bin/sh linked to /bin/bash Init: systemd (via /run/systemd/system) Versions of packages f3 depends on: ii libc6 2.19-13 f3 recommends no packages. f3 suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780633: f3: please include f3detect and f3fix
Hi Michal, These executables are experimental, not stable, and need manpages. I preferred to wait for a new upstream version to include these elements in the package. Cheers, Eriberto 2015-03-17 4:24 GMT-03:00 Michal Suchanek michal.sucha...@ruk.cuni.cz: Package: f3 Version: 5.0-1 Severity: wishlist Hello, please provide f3detect and f3fix that are built using make experimental. Thanks Michal -- System Information: Debian Release: 8.0 APT prefers testing APT policy: (910, 'testing'), (900, 'stable'), (410, 'unstable'), (400, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.18.0-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8) Shell: /bin/sh linked to /bin/bash Init: systemd (via /run/systemd/system) Versions of packages f3 depends on: ii libc6 2.19-13 f3 recommends no packages. f3 suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780633: f3: please include f3detect and f3fix
Package: f3 Version: 5.0-1 Followup-For: Bug #780633 Hello, looks like I accidentally removed the include *.d line from makefile with the patch. Should not really make a difference for Debian builds either way but it's needless change. Thanks Michal -- System Information: Debian Release: 8.0 APT prefers testing APT policy: (910, 'testing'), (900, 'stable'), (410, 'unstable'), (400, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.18.0-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8) Shell: /bin/sh linked to /bin/bash Init: systemd (via /run/systemd/system) Versions of packages f3 depends on: ii libc6 2.19-17 ii libparted2 3.2-6 ii libudev1215-12 f3 recommends no packages. f3 suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780633: f3: please include f3detect and f3fix
Package: f3
Version: 5.0-1
Followup-For: Bug #780633
Hello,
Attaching patch.
I tested the experimental tools when built from the source locally but
not the packaged version.
Thanks
-- System Information:
Debian Release: 8.0
APT prefers testing
APT policy: (910, 'testing'), (900, 'stable'), (410, 'unstable'), (400,
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.18.0-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
Versions of packages f3 depends on:
ii libc6 2.19-17
f3 recommends no packages.
f3 suggests no packages.
-- no debconf information
diff -Nru f3-5.0/debian/changelog f3-5.0/debian/changelog
--- f3-5.0/debian/changelog 2015-02-23 17:32:29.0 +0100
+++ f3-5.0/debian/changelog 2015-03-17 08:43:09.0 +0100
@@ -1,3 +1,10 @@
+f3 (5.0-1ex1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Add experimental binaries.
+
+ -- Michal Suchanek hramr...@gmail.com Tue, 17 Mar 2015 08:42:35 +0100
+
f3 (5.0-1) experimental; urgency=medium
* New upstream release.
diff -Nru f3-5.0/debian/control f3-5.0/debian/control
--- f3-5.0/debian/control 2014-10-26 22:59:36.0 +0100
+++ f3-5.0/debian/control 2015-03-17 08:44:38.0 +0100
@@ -2,7 +2,7 @@
Section: utils
Priority: optional
Maintainer: Joao Eriberto Mota Filho eribe...@debian.org
-Build-Depends: debhelper (= 9)
+Build-Depends: debhelper (= 9), libparted-dev, libudev-dev
Standards-Version: 3.9.6
Homepage: http://oss.digirati.com.br/f3
Vcs-Browser: http://anonscm.debian.org/cgit/collab-maint/f3.git
diff -Nru f3-5.0/debian/install f3-5.0/debian/install
--- f3-5.0/debian/install 2014-09-19 23:59:59.0 +0200
+++ f3-5.0/debian/install 2015-03-18 18:25:28.0 +0100
@@ -1,4 +1,6 @@
f3read usr/bin
f3write usr/bin
+f3fix usr/bin
+f3probe usr/bin
f3write.h2w usr/share/f3
log-f3wr usr/share/f3
diff -Nru f3-5.0/debian/patches/Fix_crash_when_card_reader_lacks_serial_number f3-5.0/debian/patches/Fix_crash_when_card_reader_lacks_serial_number
--- f3-5.0/debian/patches/Fix_crash_when_card_reader_lacks_serial_number 1970-01-01 01:00:00.0 +0100
+++ f3-5.0/debian/patches/Fix_crash_when_card_reader_lacks_serial_number 2015-03-18 18:26:12.0 +0100
@@ -0,0 +1,60 @@
+Udev attributes can be null.
+ -- Michal Suchanek hramr...@gmail.com
+Index: f3-5.0/libdevs.c
+===
+--- f3-5.0.orig/libdevs.c 2014-12-24 16:10:47.0 +0100
f3-5.0/libdevs.c 2015-03-18 18:20:07.946835419 +0100
+@@ -418,6 +418,16 @@
+ return mon;
+ }
+
++static int compare_udev_attr(struct udev_device *usb_dev, const char * attr, const char * cmp)
++{
++const char * value = udev_device_get_sysattr_value(usb_dev, attr);
++if (!value !cmp) return 0;
++if (!value) return 1;
++if (!cmp) return -1;
++return strcmp(value, cmp);
++}
++
++
+ static char *wait_for_add_action(struct udev *udev,
+ const char *id_vendor, const char *id_product, const char *serial)
+ {
+@@ -439,12 +449,9 @@
+
+ usb_dev = map_dev_to_usb_dev(dev);
+ if (usb_dev
+- !strcmp(udev_device_get_sysattr_value(usb_dev,
+-idVendor), id_vendor)
+- !strcmp(udev_device_get_sysattr_value(usb_dev,
+-idProduct), id_product)
+- !strcmp(udev_device_get_sysattr_value(usb_dev,
+-serial), serial)) {
++ !compare_udev_attr(usb_dev, idVendor, id_vendor)
++ !compare_udev_attr(usb_dev, idProduct, id_product)
++ !compare_udev_attr(usb_dev, serial, serial)) {
+ devnode = strdup(udev_device_get_devnode(dev));
+ assert(devnode);
+ done = true;
+Index: f3-5.0/f3fix.c
+===
+--- f3-5.0.orig/f3fix.c 2014-12-24 16:10:47.0 +0100
f3-5.0/f3fix.c 2015-03-18 18:24:25.562844530 +0100
+@@ -74,14 +74,14 @@
+ args-disk_type = ped_disk_type_get(arg);
+ if (!args-disk_type)
+ argp_error(state,
+-Disk type `%s' is not supported; use --list-disk-types to see the supported types);
++Disk type `%s' is not supported; use --list-disk-types to see the supported types, arg);
+ break;
+
+ case 'f':
+ args-fs_type = ped_file_system_type_get(arg);
+ if (!args-fs_type)
+ argp_error(state,
+-File system type `%s' is not supported; use --list-fs-types to see the supported types);
++File system type `%s' is not supported; use --list-fs-types to see the supported types, arg);
+ break;
+
+ case 'b':
diff -Nru f3-5.0/debian/patches/Makefile f3-5.0/debian/patches/Makefile
--- f3-5.0/debian/patches/Makefile 2015-02-23 15:35:00.0 +0100
+++ f3-5.0/debian/patches/Makefile 2015-03-17 08:32:35.0 +0100
@@ -3,9 +3,9 @@
Last-Update: 2015-02-23
Index: f3-5.0/Makefile
===
f3-5.0.orig/Makefile
Bug#780633: f3: please include f3detect and f3fix
Package: f3 Version: 5.0-1 Severity: wishlist Hello, please provide f3detect and f3fix that are built using make experimental. Thanks Michal -- System Information: Debian Release: 8.0 APT prefers testing APT policy: (910, 'testing'), (900, 'stable'), (410, 'unstable'), (400, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.18.0-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8) Shell: /bin/sh linked to /bin/bash Init: systemd (via /run/systemd/system) Versions of packages f3 depends on: ii libc6 2.19-13 f3 recommends no packages. f3 suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
