Bug#781763: RFS: node-coffeeify/1.0.0-1 [ITP]
On 03/04/15 19:14, Sebastiaan Couwenberg wrote: On 04/03/2015 05:56 PM, Ross Gammon wrote: Thanks again for another review Bas. On 02/04/15 19:59, Sebastiaan Couwenberg wrote: You may want to consider extending Use_through2.patch to cover all files that use the through module, there are some tests that require it too. Since the test dependencies cannot be satisfied in Debian strictly required. I have fixed (I hope) all the other issues, but have one question before I finish. The package.json file also requires through. Should we leave this pristine so users know what upstream intended to be used (through), or also patch it to show what we used (through2)? I think the package.json installed by the Debian package should reflect the dependencies used by the package not npm. Kind Regards, Bas Okay - sounds logical. I updated the patch pushed the change to alioth. I am assuming you will take the change from there, and I am therefore deleting the version on mentors. Thanks for the clarification. Ross -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#781763: RFS: node-coffeeify/1.0.0-1 [ITP]
On 04/03/2015 05:56 PM, Ross Gammon wrote: Thanks again for another review Bas. On 02/04/15 19:59, Sebastiaan Couwenberg wrote: You may want to consider extending Use_through2.patch to cover all files that use the through module, there are some tests that require it too. Since the test dependencies cannot be satisfied in Debian strictly required. I have fixed (I hope) all the other issues, but have one question before I finish. The package.json file also requires through. Should we leave this pristine so users know what upstream intended to be used (through), or also patch it to show what we used (through2)? I think the package.json installed by the Debian package should reflect the dependencies used by the package not npm. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#781763: [Pkg-javascript-devel] Bug#781763: RFS: node-coffeeify/1.0.0-1 [ITP]
Thanks again for another review Bas. On 02/04/15 19:59, Sebastiaan Couwenberg wrote: You may want to consider extending Use_through2.patch to cover all files that use the through module, there are some tests that require it too. Since the test dependencies cannot be satisfied in Debian strictly required. I have fixed (I hope) all the other issues, but have one question before I finish. The package.json file also requires through. Should we leave this pristine so users know what upstream intended to be used (through), or also patch it to show what we used (through2)? Cheers, Ross -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#781763: RFS: node-coffeeify/1.0.0-1 [ITP]
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package node-coffeeify * Package name: node-coffeeify Version : 1.0.0-1 Upstream Author : Johan Nordberg h...@johan-nordberg.com * URL : https://github.com/jnordberg/coffeeify * License : Expat Section : web It builds this binary package: node-coffeeify - browserify plugin for coffee-script To access further information about this package, please visit the following URL: http://mentors.debian.net/package/node-coffeeify Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/n/node-coffeeify/node- coffeeify_1.0.0-1.dsc The Debian packaging can be cloned with: debcheckout --user username git://git.debian.org/pkg-javascript/node- coffeeify.git --git-track '*' Changes since the last upload: * Initial release (Closes: #780698) * Patch index.js to use through2 instead of through Regards, Ross Gammon -- System Information: Debian Release: 8.0 APT prefers testing-updates APT policy: (500, 'testing-updates'), (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#781763: [Pkg-javascript-devel] Bug#781763: RFS: node-coffeeify/1.0.0-1 [ITP]
Hi Ross, Also thanks for your work on this package. This package a few minor issues just like node-convert-source-map (#781701). The Testsuite header in the control file should be XS-Testsuite. The copyright year by npm2deb is not reflected in the upstream source, it doesn't list any so I suggest to drop the year and keep the author. The upstream sources contain several examples, you should consider including them in the package. You may want to consider extending Use_through2.patch to cover all files that use the through module, there are some tests that require it too. Since the test dependencies cannot be satisfied in Debian strictly required. Patching the readme.markdown to replace node executable with nodejs as it's called in Debian is also something you may want to consider. But the commands in question also require some of the missing test dependencies, so it's also not strictly required. The project name in the upstream metadata uses the node- prefix, but upstream doesn't. Dropping the prefix is better. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
