Bug#784323: gem2deb: generates broken debian/ruby-tests.rake by default

2015-05-05 Thread Antonio Terceiro
On Tue, May 05, 2015 at 01:30:06PM +0200, Lucas Nussbaum wrote:
> Package: gem2deb
> Version: 0.14
> Severity: minor
> 
> Hi,
> 
> By default, gem2deb generates a debian/ruby-tests.rake that looks like:
> Gem2Deb::Rake::TestTask.new do |t|
>t.test_files = FileList['test/**/*_test.rb']
> end
> 
> This breaks with net-ssh, that names its tests test_*.rb
> 
> It could also make sense to set "libs" to something sensible.
> 
> So maybe it should generate something such as:
> 
> Gem2Deb::Rake::TestTask.new do |t|
>t.libs = ["lib", "test"]

the install location under debian/$pkg is already added to the
$LOAD_PATH by the test runner, so you don't need/want lib/ there. But
adding test/ is indeed useful.

>t.test_files = FileList['test/**/*_test.rb'] FileList['test/**/test_*.rb']
> end

Yes. I just pushed a fix for this to the git repository.

-- 
Antonio Terceiro 


signature.asc
Description: Digital signature


Bug#784323: gem2deb: generates broken debian/ruby-tests.rake by default

2015-05-05 Thread Lucas Nussbaum
Package: gem2deb
Version: 0.14
Severity: minor

Hi,

By default, gem2deb generates a debian/ruby-tests.rake that looks like:
Gem2Deb::Rake::TestTask.new do |t|
   t.test_files = FileList['test/**/*_test.rb']
end

This breaks with net-ssh, that names its tests test_*.rb

It could also make sense to set "libs" to something sensible.

So maybe it should generate something such as:

Gem2Deb::Rake::TestTask.new do |t|
   t.libs = ["lib", "test"]
   t.test_files = FileList['test/**/*_test.rb'] FileList['test/**/test_*.rb']
end

?

- Lucas


-- System Information:
Debian Release: 8.0
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'oldstable'), 
(300, 'unstable'), (150, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.19.0-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages gem2deb depends on:
ii  build-essential  11.7
ii  debhelper9.20150101
ii  devscripts   2.15.3
ii  gem2deb-test-runner  0.14
ii  perl 5.20.2-3
ii  ruby 1:2.1.5
ii  ruby-all-dev 1:2.1.5
ii  ruby-setup   3.4.1-7

Versions of packages gem2deb recommends:
ii  apt-file  2.5.4

gem2deb suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org