Bug#784439: [Pkg-javascript-devel] Bug#784439: Bug#784439: uglifyjs version failing
2015-05-19 9:25 GMT+02:00 Jonas Smedegaard : > Quoting Jérémy Lal (2015-05-19 02:15:29) > > 2015-05-19 1:34 GMT+02:00 Jonas Smedegaard : > >> Please actually look at the uglifyjs source package - or just read > >> closely the original bugreport - before you comment further. I think > >> you will then agree that your remarks are totally irrelevant here. > > > > Well, i actually did that. > > So if you've setup the files with the same tree as in source, that is > > /usr/lib/nodejs/uglify-js/bin/uglifyjs > > /usr/lib/nodejs/uglify-js/lib/*.js > > /usr/lib/nodejs/uglify-js/package.json > > > > and a symlink /usr/lib/nodejs/uglify-js/bin/uglifyjs > > -> /usr/bin/uglifyjs there wouldn't be a need for the patches. > > > > As i said, i'm not questionning the dislike for keeping the original > > tree, i'm just saying that it avoids adding more patches. > > Ohh, now I get it. Thanks for spelling it out to me: I even considered > if you perhaps meant to install _everything_ including the script below > /usr/lib/nodejs but dismissed that as unrealistic. > > So Nodejs lookup path is not only /usr/lib/nodejs/$lib.js and > /usr/lib/$lib/index.js but also /usr/lib/nodejs/$lib/lib/index - or does > it take /usr/lib/nodejs/$lib/package.json into account (I notice there's > a mention of "main" in there - which is actually incorrect now with my > patching)? > > package.json it is Jérémy.
Bug#784439: [Pkg-javascript-devel] Bug#784439: Bug#784439: uglifyjs version failing
Quoting Jérémy Lal (2015-05-19 02:15:29) > 2015-05-19 1:34 GMT+02:00 Jonas Smedegaard : >> Please actually look at the uglifyjs source package - or just read >> closely the original bugreport - before you comment further. I think >> you will then agree that your remarks are totally irrelevant here. > > Well, i actually did that. > So if you've setup the files with the same tree as in source, that is > /usr/lib/nodejs/uglify-js/bin/uglifyjs > /usr/lib/nodejs/uglify-js/lib/*.js > /usr/lib/nodejs/uglify-js/package.json > > and a symlink /usr/lib/nodejs/uglify-js/bin/uglifyjs > -> /usr/bin/uglifyjs there wouldn't be a need for the patches. > > As i said, i'm not questionning the dislike for keeping the original > tree, i'm just saying that it avoids adding more patches. Ohh, now I get it. Thanks for spelling it out to me: I even considered if you perhaps meant to install _everything_ including the script below /usr/lib/nodejs but dismissed that as unrealistic. So Nodejs lookup path is not only /usr/lib/nodejs/$lib.js and /usr/lib/$lib/index.js but also /usr/lib/nodejs/$lib/lib/index - or does it take /usr/lib/nodejs/$lib/package.json into account (I notice there's a mention of "main" in there - which is actually incorrect now with my patching)? Or does "stuffing everything below /usr/lib/nodejs/$lib/ only solve internal lib paths, and I should still patch main lib to be .../index.js? - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#784439: [Pkg-javascript-devel] Bug#784439: Bug#784439: uglifyjs version failing
2015-05-19 1:34 GMT+02:00 Jonas Smedegaard : > Quoting Jérémy Lal (2015-05-18 19:33:34) > > 2015-05-18 19:19 GMT+02:00 Jonas Smedegaard : > >> Quoting Jérémy Lal (2015-05-06 14:08:09) > >>> 2015-05-06 13:31 GMT+02:00 Pau Garcia i Quiles : > The package.json file does exist: > >> [...] > /usr/lib/nodejs/uglify-js/package.json > >>> > >>> that's why it's usually simpler and safer to install original > >>> hierarchy with > >>> - package.json > >>> - lib/* > >>> in /usr/lib/nodejs/uglify-js, instead of changing it and not > >>> installing package.json. > >> > >> You are barking up the wrong tree, Jérémy: package.js *is* installed > >> at the *correct* location. Please read what Pau Garcia wrote. > >> > >> Problem is upstream script expecting to be installed in ~/bin/ and > >> assuming its library is in ~/lib/ > >> > >> I will extend 2001 to also cover hardcoded path to parse.js. > > > > What i was saying was that files were expected to be installed in > > /usr/lib/nodejs/uglify-js/package.json > > /usr/lib/nodejs/uglify-js/lib/* > > > > which is fine for me but i saw you prefer installing them up one dir + > > patch. > > Please actually look at the uglifyjs source package - or just read > closely the original bugreport - before you comment further. I think > you will then agree that your remarks are totally irrelevant here. > > Well, i actually did that. So if you've setup the files with the same tree as in source, that is /usr/lib/nodejs/uglify-js/bin/uglifyjs /usr/lib/nodejs/uglify-js/lib/*.js /usr/lib/nodejs/uglify-js/package.json and a symlink /usr/lib/nodejs/uglify-js/bin/uglifyjs -> /usr/bin/uglifyjs there wouldn't be a need for the patches. As i said, i'm not questionning the dislike for keeping the original tree, i'm just saying that it avoids adding more patches. Jérémy.
Bug#784439: [Pkg-javascript-devel] Bug#784439: uglifyjs version failing
Quoting Jérémy Lal (2015-05-18 19:33:34) > 2015-05-18 19:19 GMT+02:00 Jonas Smedegaard : >> Quoting Jérémy Lal (2015-05-06 14:08:09) >>> 2015-05-06 13:31 GMT+02:00 Pau Garcia i Quiles : The package.json file does exist: >> [...] /usr/lib/nodejs/uglify-js/package.json >>> >>> that's why it's usually simpler and safer to install original >>> hierarchy with >>> - package.json >>> - lib/* >>> in /usr/lib/nodejs/uglify-js, instead of changing it and not >>> installing package.json. >> >> You are barking up the wrong tree, Jérémy: package.js *is* installed >> at the *correct* location. Please read what Pau Garcia wrote. >> >> Problem is upstream script expecting to be installed in ~/bin/ and >> assuming its library is in ~/lib/ >> >> I will extend 2001 to also cover hardcoded path to parse.js. > > What i was saying was that files were expected to be installed in > /usr/lib/nodejs/uglify-js/package.json > /usr/lib/nodejs/uglify-js/lib/* > > which is fine for me but i saw you prefer installing them up one dir + > patch. Please actually look at the uglifyjs source package - or just read closely the original bugreport - before you comment further. I think you will then agree that your remarks are totally irrelevant here. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#784439: [Pkg-javascript-devel] Bug#784439: uglifyjs version failing
2015-05-18 19:19 GMT+02:00 Jonas Smedegaard : > Quoting Jérémy Lal (2015-05-06 14:08:09) > > 2015-05-06 13:31 GMT+02:00 Pau Garcia i Quiles : > > The package.json file does exist: > [...] > > /usr/lib/nodejs/uglify-js/package.json > > > that's why it's usually simpler and safer to install original > > hierarchy with > > - package.json > > - lib/* > > in /usr/lib/nodejs/uglify-js, instead of changing it and not > > installing package.json. > > You are barking up the wrong tree, Jérémy: package.js *is* installed at > the *correct* location. Please read what Pau Garcia wrote. > > Problem is upstream script expecting to be installed in ~/bin/ and > assuming its library is in ~/lib/ > > I will extend 2001 to also cover hardcoded path to parse.js. What i was saying was that files were expected to be installed in /usr/lib/nodejs/uglify-js/package.json /usr/lib/nodejs/uglify-js/lib/* which is fine for me but i saw you prefer installing them up one dir + patch. Jérémy.
Bug#784439: uglifyjs version failing
Quoting Jérémy Lal (2015-05-06 14:08:09) > 2015-05-06 13:31 GMT+02:00 Pau Garcia i Quiles : > The package.json file does exist: [...] > /usr/lib/nodejs/uglify-js/package.json > that's why it's usually simpler and safer to install original > hierarchy with > - package.json > - lib/* > in /usr/lib/nodejs/uglify-js, instead of changing it and not > installing package.json. You are barking up the wrong tree, Jérémy: package.js *is* installed at the *correct* location. Please read what Pau Garcia wrote. Problem is upstream script expecting to be installed in ~/bin/ and assuming its library is in ~/lib/ I will extend 2001 to also cover hardcoded path to parse.js. Thanks for your bugreport, Pau Garcia, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#784439: uglifyjs version failing
2015-05-06 13:31 GMT+02:00 Pau Garcia i Quiles :
> Package: node-uglify
> Version: 2.4.15-1
>
> Trying to find out the version of uglifyjs on your system fails:
>
> $ uglifyjs --version
>
> module.js:340
>throw err;
> ^
> Error: Cannot find module '../package.json'
>at Function.Module._resolveFilename (module.js:338:15)
>at Function.Module._load (module.js:280:25)
>at Module.require (module.js:364:17)
>at require (module.js:380:17)
>at Object. (/usr/bin/uglifyjs:118:16)
>at Module._compile (module.js:456:26)
>at Object.Module._extensions..js (module.js:474:10)
>at Module.load (module.js:356:32)
>at Function.Module._load (module.js:312:12)
>at Function.Module.runMain (module.js:497:10)
>
> The package.json file does exist:
>
> $ dpkg -L node-uglify
> /.
> /usr
> /usr/lib
> /usr/lib/nodejs
> /usr/lib/nodejs/uglify-js
> /usr/lib/nodejs/uglify-js/transform.js
> /usr/lib/nodejs/uglify-js/utils.js
> /usr/lib/nodejs/uglify-js/output.js
> /usr/lib/nodejs/uglify-js/index.js
> /usr/lib/nodejs/uglify-js/compress.js
> /usr/lib/nodejs/uglify-js/scope.js
> /usr/lib/nodejs/uglify-js/sourcemap.js
> /usr/lib/nodejs/uglify-js/ast.js
> /usr/lib/nodejs/uglify-js/mozilla-ast.js
> /usr/lib/nodejs/uglify-js/package.json
> /usr/lib/nodejs/uglify-js/parse.js
> /usr/share
> /usr/share/man
> /usr/share/man/man1
> /usr/share/man/man1/uglifyjs.1.gz
> /usr/share/doc
> /usr/share/doc/node-uglify
> /usr/share/doc/node-uglify/copyright
> /usr/share/doc/node-uglify/README.md.gz
> /usr/share/doc/node-uglify/changelog.Debian.gz
> /usr/bin
> /usr/bin/uglifyjs
>
> Problem is /usr/bin/uglifyjs looks for it in the wrong place:
>
> $ grep package.json /usr/bin/uglifyjs
>var json = require("../package.json");
Hi there,
that's why it's usually simpler and safer to install original hierarchy with
- package.json
- lib/*
in /usr/lib/nodejs/uglify-js, instead of changing it and not installing
package.json.
Regards,
Jérémy.
Bug#784439: uglifyjs version failing
Package: node-uglify
Version: 2.4.15-1
Trying to find out the version of uglifyjs on your system fails:
$ uglifyjs --version
module.js:340
throw err;
^
Error: Cannot find module '../package.json'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object. (/usr/bin/uglifyjs:118:16)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)
The package.json file does exist:
$ dpkg -L node-uglify
/.
/usr
/usr/lib
/usr/lib/nodejs
/usr/lib/nodejs/uglify-js
/usr/lib/nodejs/uglify-js/transform.js
/usr/lib/nodejs/uglify-js/utils.js
/usr/lib/nodejs/uglify-js/output.js
/usr/lib/nodejs/uglify-js/index.js
/usr/lib/nodejs/uglify-js/compress.js
/usr/lib/nodejs/uglify-js/scope.js
/usr/lib/nodejs/uglify-js/sourcemap.js
/usr/lib/nodejs/uglify-js/ast.js
/usr/lib/nodejs/uglify-js/mozilla-ast.js
/usr/lib/nodejs/uglify-js/package.json
/usr/lib/nodejs/uglify-js/parse.js
/usr/share
/usr/share/man
/usr/share/man/man1
/usr/share/man/man1/uglifyjs.1.gz
/usr/share/doc
/usr/share/doc/node-uglify
/usr/share/doc/node-uglify/copyright
/usr/share/doc/node-uglify/README.md.gz
/usr/share/doc/node-uglify/changelog.Debian.gz
/usr/bin
/usr/bin/uglifyjs
Problem is /usr/bin/uglifyjs looks for it in the wrong place:
$ grep package.json /usr/bin/uglifyjs
var json = require("../package.json");
--
Pau Garcia i Quiles
http://www.elpauer.org
(Due to my workload, I may need 10 days to answer)
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
