Bug#784898: RFS: duperemove/0.10-1 [ITP]

2015-10-15 Thread Gianfranco Costamagna


Hi Felix,

 Il Mercoledì 14 Ottobre 2015 20:21, Felix Zielcke  ha 
scritto:


>Thanks very much to both of you.
>I created now a github fork for it:
>
>https://github.com/fezie/duperemove
>
>Though I didn't do much yet.


https://github.com/fezie/duperemove/commit/958c4f520a6f9c2552f2b98a3bd1504ee2196073

lol :)
(please fix)

BTW, please upload on mentors too, I don't like to clone stuff from outside 
Debian
(and please consider joining collab-maint and creating a repository there)

>Thanks again very much.
>You can't imagine how good that feels to me :-)


well, this was directed to Mattia, who gives always useful hints to the 
community and he
is mostly there but not yet :)

anyway, I looked to your Debian activities, and you are really a good and 
prominent Maintainer,
let me know if you want to do the great jump, I can start looking deeply at 
your work and
sponsor your packages :)

cheers,

G.



Bug#784898: RFS: duperemove/0.10-1 [ITP]

2015-10-14 Thread Felix Zielcke
Am Mittwoch, den 14.10.2015, 18:41 +0100 schrieb Gianfranco Costamagna:


> thanks for the fix,

Thanks very much to both of you.
I created now a github fork for it:

https://github.com/fezie/duperemove

Though I didn't do much yet.

> 
> (please finish your NM process! we need you :p )


Thanks again very much.
You can't imagine how good that feels to me :-)

Regards
Felix



Bug#784898: RFS: duperemove/0.10-1 [ITP]

2015-10-14 Thread Gianfranco Costamagna
true story :)


bad copy/paste, sorry!


thanks for the fix,


(please finish your NM process! we need you :p )


G.

Sent from Yahoo Mail on Android

From:"Mattia Rizzolo" 
Date:Wed, 14 Oct, 2015 at 19:21
Subject:Bug#784898: RFS: duperemove/0.10-1 [ITP]

On Wed, Oct 14, 2015 at 04:14:16PM +, Gianfranco Costamagna wrote:
> 1) the first patch should be upstreamed
> 2) the second one should be:
> -PREFIX = /usr/local
> +PREFIX ?= /usr
> 
> this way you can upstream it too.
> (please forward and add link inside the patches)

well, to upstream that you need to do



-PREFIX = /usr/local
+PREFIX ?= /usr/local



then you can set PREFIX in d/rules

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                 `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia 

`-



Bug#784898: RFS: duperemove/0.10-1 [ITP]

2015-10-14 Thread Mattia Rizzolo
On Wed, Oct 14, 2015 at 04:14:16PM +, Gianfranco Costamagna wrote:
> 1) the first patch should be upstreamed
> 2) the second one should be:
> -PREFIX = /usr/local
> +PREFIX ?= /usr
> 
> this way you can upstream it too.
> (please forward and add link inside the patches)

well, to upstream that you need to do

-PREFIX = /usr/local
+PREFIX ?= /usr/local

then you can set PREFIX in d/rules

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  http://mapreri.org  : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Bug#784898: RFS: duperemove/0.10-1 [ITP]

2015-10-14 Thread Gianfranco Costamagna
Another issue:

http://debomatic-amd64.debian.net/distribution#unstable/duperemove/0.10-1/blhc

cheers,


G.



Bug#784898: RFS: duperemove/0.10-1 [ITP]

2015-10-14 Thread Gianfranco Costamagna
Control: owner -1 !
Control: tags -1 moreinfo


Hi Felix,

let's review.

1) the first patch should be upstreamed
2) the second one should be:
-PREFIX = /usr/local
+PREFIX ?= /usr


this way you can upstream it too.
(please forward and add link inside the patches)

3) copyright is outdated.

xxhash.c: BSD (2 clause)
xxhash.h: BSD (2 clause)


also many copyrights are missing
grep copyright . -Ri
lists a lot of stuff


the other stuff might look good.
the package seems to be working.

cheers,

G.



Bug#784898: RFS: duperemove/0.10-1 [ITP]

2015-10-13 Thread Felix Zielcke
Hi,

is there now anything missing for getting duperemove into Debian?