Bug#787328: RFS: mpd-sima/0.13.1-1

[Geoff]

Hi Gianfranco

Upstream switched to python3 but python-mpd is not ported to py3 (and 
it's actually abandoned).
Then they use python3-musicpd instead which is a pure python3 MPD module 
(backward compatible but on a different namespace).


Cheers
Geoff

2015-09-17 09:14, Gianfranco Costamagna wrote :

last things:

1) you dropped
 python-mpd (>= 0.3),  from runtime dependencies,

and now python3:Depends is picking up the correct new dependencies:

Depends: init-system-helpers (>= 1.18~), python3, python3-musicpd,
python3-requests, python3:any (>= 3.3.2-2~), adduser, lsb-base


so the question is: was python-mpd wrong? maybe you meant
python-musicpd instead and now it is correct?

or did upstream change the requirement?


cheers,
G.

Il Mercoledì 16 Settembre 2015 20:23, Geoff  ha 
scritto:

Changes committed and published in git.
I've just uploaded to mentors the new package.

Thanks for your reviews :)

Cheers,
Geoff

Bug#787328: RFS: mpd-sima/0.13.1-1

[Gianfranco Costamagna]

Hi again,

last things:

1) you dropped 
 python-mpd (>= 0.3),  from runtime dependencies, 

and now python3:Depends is picking up the correct new dependencies:

Depends: init-system-helpers (>= 1.18~), python3, python3-musicpd, 
python3-requests, python3:any (>= 3.3.2-2~), adduser, lsb-base


so the question is: was python-mpd wrong? maybe you meant python-musicpd 
instead and now it is correct?

or did upstream change the requirement?


cheers,
G.

Il Mercoledì 16 Settembre 2015 20:23, Geoff  ha scritto:
Changes committed and published in git.
I've just uploaded to mentors the new package.

Thanks for your reviews :)

Cheers,
Geoff


Le 16/09/2015 11:09, Geoff a écrit :
> Alright, got it.
> 
> I'll fix this and revert target to experimental.
> Thanks for spotting that
> 
> I'll update/uppload the package to mentor tonight (UTC+01:00)
> 
> Cheers
> 
> Le 2015-09-16 09:24, Gianfranco Costamagna  :
>> Hi Geoff
>>
> 2) entry 0.10.0-1 is targeted wrongly
>>> I don't get what you mean.
>>
>>
>> exactly what I wrote :)
>>
>> dget -x
>> http://http.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.10.0-2.dsc
>> dget -x
>> http://mentors.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.13.1-1.dsc
>>
>> debdiff mpd-sima_0.10.0-2.dsc mpd-sima_0.13.1-1.dsc > debdiff
>> filterdiff  debdiff -i "*debian*" > debdiff.filtered
>>
>> cat debdiff.filtered |grep "0.10.0-1"
>> -mpd-sima (0.10.0-1) experimental; urgency=low
>> +mpd-sima (0.10.0-1) unstable; urgency=low
>>
>>
>> you see to have changed the target series of a previous release.
>>
>> http://anonscm.debian.org/cgit/pkg-multimedia/mpd-sima.git/commit/debian/changelog?id=0edb56f2a0bf5e780d946eb25ceb93b3704f63f2
>>
> 

Bug#787328: RFS: mpd-sima/0.13.1-1

[Geoff]

Thanks Gianfranco

Le 2015-09-17 09:33, Gianfranco Costamagna a écrit :

Built, thanks for your contribution to Debian!

maybe that change was worth a mention in changelog, but I already
nitpicked enough
and it was already covered by the "major package refactoring" :)

cheers!

G.

Bug#787328: RFS: mpd-sima/0.13.1-1

[Geoff]

Alright, got it.

I'll fix this and revert target to experimental.
Thanks for spotting that

I'll update/uppload the package to mentor tonight (UTC+01:00)

Cheers

Le 2015-09-16 09:24, Gianfranco Costamagna  :

Hi Geoff


2) entry 0.10.0-1 is targeted wrongly

I don't get what you mean.



exactly what I wrote :)

dget -x 
http://http.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.10.0-2.dsc

dget -x
http://mentors.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.13.1-1.dsc
debdiff mpd-sima_0.10.0-2.dsc mpd-sima_0.13.1-1.dsc > debdiff
filterdiff  debdiff -i "*debian*" > debdiff.filtered

cat debdiff.filtered |grep "0.10.0-1"
-mpd-sima (0.10.0-1) experimental; urgency=low
+mpd-sima (0.10.0-1) unstable; urgency=low


you see to have changed the target series of a previous release.

http://anonscm.debian.org/cgit/pkg-multimedia/mpd-sima.git/commit/debian/changelog?id=0edb56f2a0bf5e780d946eb25ceb93b3704f63f2

Bug#787328: RFS: mpd-sima/0.13.1-1

[Gianfranco Costamagna]

Hi Geoff




>>> 2) entry 0.10.0-1 is targeted wrongly
>I don't get what you mean.


exactly what I wrote :)

dget -x http://http.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.10.0-2.dsc
dget -x 
http://mentors.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.13.1-1.dsc
debdiff mpd-sima_0.10.0-2.dsc mpd-sima_0.13.1-1.dsc > debdiff
filterdiff  debdiff -i "*debian*" > debdiff.filtered

cat debdiff.filtered |grep "0.10.0-1"
-mpd-sima (0.10.0-1) experimental; urgency=low
+mpd-sima (0.10.0-1) unstable; urgency=low


you see to have changed the target series of a previous release.

http://anonscm.debian.org/cgit/pkg-multimedia/mpd-sima.git/commit/debian/changelog?id=0edb56f2a0bf5e780d946eb25ceb93b3704f63f2

cheers

G.

Bug#787328: RFS: mpd-sima/0.13.1-1

[Geoff]

Changes committed and published in git.
I've just uploaded to mentors the new package.

Thanks for your reviews :)

Cheers,
Geoff

Le 16/09/2015 11:09, Geoff a écrit :
> Alright, got it.
> 
> I'll fix this and revert target to experimental.
> Thanks for spotting that
> 
> I'll update/uppload the package to mentor tonight (UTC+01:00)
> 
> Cheers
> 
> Le 2015-09-16 09:24, Gianfranco Costamagna  :
>> Hi Geoff
>>
> 2) entry 0.10.0-1 is targeted wrongly
>>> I don't get what you mean.
>>
>>
>> exactly what I wrote :)
>>
>> dget -x
>> http://http.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.10.0-2.dsc
>> dget -x
>> http://mentors.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.13.1-1.dsc
>>
>> debdiff mpd-sima_0.10.0-2.dsc mpd-sima_0.13.1-1.dsc > debdiff
>> filterdiff  debdiff -i "*debian*" > debdiff.filtered
>>
>> cat debdiff.filtered |grep "0.10.0-1"
>> -mpd-sima (0.10.0-1) experimental; urgency=low
>> +mpd-sima (0.10.0-1) unstable; urgency=low
>>
>>
>> you see to have changed the target series of a previous release.
>>
>> http://anonscm.debian.org/cgit/pkg-multimedia/mpd-sima.git/commit/debian/changelog?id=0edb56f2a0bf5e780d946eb25ceb93b3704f63f2
>>
> 



signature.asc
Description: OpenPGP digital signature

Bug#787328: RFS: mpd-sima/0.13.1-1

[Geoff]

Hi Christian, Gianfranco

First,t hanks for your careful reviews :)

git repo and package on mentors are updated.

Here follows my answers.

Le 14/09/2015 20:37, Christian Kastner wrote :
> Gianfranco already beat me to the review; nevertheless, here are some
> additional notes I had prepared, based on the package I saw on Sunday
> (the package is no longer visible on mentors.d.n).
> 
> On 2015-09-14 12:32, Gianfranco Costamagna wrote:
>> lets review:
>>
>> 1) you dropped 0.10.0-2 entry from changelog
Fixed, it disappeared somehow in the process :/

>> 2) entry 0.10.0-1 is targeted wrongly
I don't get what you mean.

>> 3) bump compat level not mentioned in changelog
Done

>> 4) according to setup.py
>> install_requires=['python-musicpd>=0.4.1', 'requests>= 2.0.2'],
>> so I guess there is no need to specify them to runtime dependencies

It is indeed useless to specify them explicitly, dh_python3 and
${python3:Depends}.

>> 5) please mention copyright updates
>> 6) mpd-sima.default
>> "+## NOTA BENE:"
>> this seems to be italian, please use english
Done

>>
>> 7)
>> +## only works with SysV init
>> +## With systemd init: "touch /etc/mpd-sima_not_to_be_run" to prevent 
>> mpd-sima from being started
>>
>>
>> well, can't you use some systemd facilities to do the same?

I did specify the systemd way to disable the script in mpd-sima.default.
I also removed support for this file in service file, this was only an
attempt to have systemd to work as SysV did.
I don't believe this is relevant.

> d/control:
>   - The Vcs-Browser URL refers to the gitweb viewer, whereas the current
> viewer seems to be cgit (the gitweb URL just redirects there)
Done

> d/changelog:
>   - typo: convertion -> conversion
>   - When bumping S-V, while not necessary, it is good practice to
> indicate what changes were made in the process, or "no changes
> needed" if that was the case
Done


>   - It is helpful to be more explicit about some changes. You mention,
> for example, that the package has been converted to Python 3. The
> fact that the Python 2 package has been dropped is merely implied.
> That is IMHO a significant change, and should be worth a hint
Indeed, though, this is not a python module but only an application.
It is not as important as it might be for python modules.
I did rephrase a bit the changelog anyway.

And I'll try to be more verbose in the future.

> d/copyright:
>   - The Upstream-Source URL lists something completely different to the
> the Homepage field in d/control. Could it be that one of them needs
> to be updated?
It does, thanks.
Fields updated.

> d/NEWS:
>   - The upgrade path suggestion for the conffile in /etc isn't
> really the prettiest solution, although I really don't know what
> other path I could suggest that wouldn't seem like overkill. How
> did upstream handle this change? Do they perhaps have a script or
> tool that could assist in this process?

Well, I'm actually upstream, I did not write any tool to migrate the
conf. Since the package is not that popular (popcon ~ 100) and because
target users are quite probably advanced users and command line lovers,
I did not try to handle a nice and smoothly conf upgrade.

Well I think the current tradeoff to be acceptable given the package
popularity and users profile.

> d/
>   - I encountered a lintian warning when building your package
> 
> Apologies for not providing more accurate references and/or possibly
> outdated information. I had your package source in /tmp, which of course
> didn't survive a reboot...

This was a lintian warning command-with-path-in-maintainer-script.
https://lintian.debian.org/full/pkg-multimedia-maintain...@lists.alioth.debian.org.html#mpd-sima_0.10.0-2

I fixed it using which instead of a test:
http://git.kaliko.me/?p=mpd-sima-debian.git;a=commitdiff;h=214b4926


Thanks again for the review.
Geoff



signature.asc
Description: OpenPGP digital signature

Bug#787328: RFS: mpd-sima/0.13.1-1

[Christian Kastner]

(replying just to the issues I raised)

On 2015-09-15 21:00, Geoff wrote:
>>   - It is helpful to be more explicit about some changes. You mention,
>> for example, that the package has been converted to Python 3. The
>> fact that the Python 2 package has been dropped is merely implied.
>> That is IMHO a significant change, and should be worth a hint
> Indeed, though, this is not a python module but only an application.

Oh, my bad! Sorry about that. (Hence also why I hadn't posted my notes
earlier -- the review was still somewhat rough)

>> d/NEWS:
>>   - The upgrade path suggestion for the conffile in /etc isn't
>> really the prettiest solution, although I really don't know what
>> other path I could suggest that wouldn't seem like overkill. How
>> did upstream handle this change? Do they perhaps have a script or
>> tool that could assist in this process?
> 
> Well, I'm actually upstream, I did not write any tool to migrate the
> conf.

Oh -- another thing I seem to have missed.

> Since the package is not that popular (popcon ~ 100) and because
> target users are quite probably advanced users and command line lovers,
> I did not try to handle a nice and smoothly conf upgrade.
> 
> Well I think the current tradeoff to be acceptable given the package
> popularity and users profile.

I believe you are right. After all, you are preserving possible user
changes to the conffile, in accordance with the Policy.

Regards,
Christian



signature.asc
Description: OpenPGP digital signature

Bug#787328: RFS: mpd-sima/0.13.1-1

[Gianfranco Costamagna]

Control: owner -1 !

Hi Geoff,

lets review:

1) you dropped 0.10.0-2 entry from changelog
2) entry 0.10.0-1 is targeted wrongly
3) bump compat level not mentioned in changelog
4) according to setup.py
install_requires=['python-musicpd>=0.4.1', 'requests>= 2.0.2'],

so I guess there is no need to specify them to runtime dependencies
(please check)

5) please mention copyright updates
6) mpd-sima.default
"+## NOTA BENE:"
this seems to be italian, please use english

7)
+## only works with SysV init
+## With systemd init: "touch /etc/mpd-sima_not_to_be_run" to prevent mpd-sima 
from being started


well, can't you use some systemd facilities to do the same?

http://www.freedesktop.org/software/systemd/man/systemd.unit.html
http://www.freedesktop.org/software/systemd/man/systemd.service.html

(or make systemv script behave in the same way)


the other stuff looks good to me



(note, some of them might be not issues or just nitpicks, feel free to tell me 
so if
you think they are good that way)

cheers,

G.


Il Sabato 12 Settembre 2015 16:21, Geoff  ha scritto:
Hi

I'm looking for a review|sponsor of my package (already in debian).
I'm posting on debian-python as well if someone wants to have a look at
the python packaging :)

My previous sponsor is not responding, so if somebody is willing to
upload the package, you're welcome to do so as well.

Thanks
Geoff

Le 31/05/2015 16:03, Geoff a écrit :
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "mpd-sima":
> 
>  * Package name: mpd-sima
>Version : 0.13.1-1
>Upstream Author : Jack Kaliko 
>  * URL : http://kaliko.me/code/mpd-sima/
>  * License : GPL3+
>Section : sound
> 
> It builds those binary packages:
> 
>mpd-sima   - Automagically add titles to MPD playlist
> 
> To access further information about this package, please visit the
> following URL:
> 
>  http://mentors.debian.net/package/mpd-sima
> 
> Alternatively, one can download the package with dget using this command:
> 
>   dget -x
> http://mentors.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.13.1-1.dsc
> 
> 
> Changes since the last upload:
> 
>   * python3 convertion, major package refactoring
>   * Migrate to dh-python
>   * Bumped Standards-Version to 3.9.6
>   * Add pgpsigurlmangle for uscan
>   * Depends on musicpd and requests
>   * Add service file (systemd)
> 
> Regards,
> Geoff
>

Bug#787328: RFS: mpd-sima/0.13.1-1

[Christian Kastner]

Hi Geoff,

Gianfranco already beat me to the review; nevertheless, here are some
additional notes I had prepared, based on the package I saw on Sunday
(the package is no longer visible on mentors.d.n).

On 2015-09-14 12:32, Gianfranco Costamagna wrote:
> lets review:
> 
> 1) you dropped 0.10.0-2 entry from changelog
> 2) entry 0.10.0-1 is targeted wrongly
> 3) bump compat level not mentioned in changelog
> 4) according to setup.py
> install_requires=['python-musicpd>=0.4.1', 'requests>= 2.0.2'],
> 
> so I guess there is no need to specify them to runtime dependencies
> (please check)
> 
> 5) please mention copyright updates
> 6) mpd-sima.default
> "+## NOTA BENE:"
> this seems to be italian, please use english
> 
> 7)
> +## only works with SysV init
> +## With systemd init: "touch /etc/mpd-sima_not_to_be_run" to prevent 
> mpd-sima from being started
> 
> 
> well, can't you use some systemd facilities to do the same?
> 
> http://www.freedesktop.org/software/systemd/man/systemd.unit.html
> http://www.freedesktop.org/software/systemd/man/systemd.service.html
> 
> (or make systemv script behave in the same way)

d/control:
  - The Vcs-Browser URL refers to the gitweb viewer, whereas the current
viewer seems to be cgit (the gitweb URL just redirects there)

d/changelog:
  - typo: convertion -> conversion
  - When bumping S-V, while not necessary, it is good practice to
indicate what changes were made in the process, or "no changes
needed" if that was the case
  - It is helpful to be more explicit about some changes. You mention,
for example, that the package has been converted to Python 3. The
fact that the Python 2 package has been dropped is merely implied.
That is IMHO a significant change, and should be worth a hint

d/copyright:
  - The Upstream-Source URL lists something completely different to the
the Homepage field in d/control. Could it be that one of them needs
to be updated?

d/NEWS:
  - The upgrade path suggestion for the conffile in /etc isn't
really the prettiest solution, although I really don't know what
other path I could suggest that wouldn't seem like overkill. How
did upstream handle this change? Do they perhaps have a script or
tool that could assist in this process?

d/
  - I encountered a lintian warning when building your package

Apologies for not providing more accurate references and/or possibly
outdated information. I had your package source in /tmp, which of course
didn't survive a reboot...

> (note, some of them might be not issues or just nitpicks, feel free to tell 
> me so if
> you think they are good that way)

Same here.



signature.asc
Description: OpenPGP digital signature

Bug#787328: RFS: mpd-sima/0.13.1-1

[Geoff]

Hi

I'm looking for a review|sponsor of my package (already in debian).
I'm posting on debian-python as well if someone wants to have a look at
the python packaging :)

My previous sponsor is not responding, so if somebody is willing to
upload the package, you're welcome to do so as well.

Thanks
Geoff

Le 31/05/2015 16:03, Geoff a écrit :
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "mpd-sima":
> 
>  * Package name: mpd-sima
>Version : 0.13.1-1
>Upstream Author : Jack Kaliko 
>  * URL : http://kaliko.me/code/mpd-sima/
>  * License : GPL3+
>Section : sound
> 
> It builds those binary packages:
> 
>mpd-sima   - Automagically add titles to MPD playlist
> 
> To access further information about this package, please visit the
> following URL:
> 
>   http://mentors.debian.net/package/mpd-sima
> 
> Alternatively, one can download the package with dget using this command:
> 
>   dget -x
> http://mentors.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.13.1-1.dsc
> 
> 
> Changes since the last upload:
> 
>   * python3 convertion, major package refactoring
>   * Migrate to dh-python
>   * Bumped Standards-Version to 3.9.6
>   * Add pgpsigurlmangle for uscan
>   * Depends on musicpd and requests
>   * Add service file (systemd)
> 
> Regards,
> Geoff
> 





signature.asc
Description: OpenPGP digital signature

Bug#787328: RFS: mpd-sima/0.13.1-1

[Geoff]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package mpd-sima:

 * Package name: mpd-sima
   Version : 0.13.1-1
   Upstream Author : Jack Kaliko kal...@azylum.org
 * URL : http://kaliko.me/code/mpd-sima/
 * License : GPL3+
   Section : sound

It builds those binary packages:

   mpd-sima   - Automagically add titles to MPD playlist

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/mpd-sima

Alternatively, one can download the package with dget using this command:

  dget -x
http://mentors.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.13.1-1.dsc


Changes since the last upload:

  * python3 convertion, major package refactoring
  * Migrate to dh-python
  * Bumped Standards-Version to 3.9.6
  * Add pgpsigurlmangle for uscan
  * Depends on musicpd and requests
  * Add service file (systemd)

Regards,
Geoff



signature.asc
Description: OpenPGP digital signature