Bug#787639: [pkg-gnupg-maint] Bug#787639: Bug#787639: [PATCH] pinentry_setbufferlen returns pin when already large enough

2015-06-05 Thread Werner Koch 
On Fri,  5 Jun 2015 04:08, d...@fifthhorseman.net said:

 It would be great if we could address
 https://bugs.gnupg.org/gnupg/issue1996 before the 0.9.4 release as well,

Okay, I delay the release until Neal has woken up.  @Neal: pls contact
via Jabber.


Salam-Shalom,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#787639: [pkg-gnupg-maint] Bug#787639: Bug#787639: [PATCH] pinentry_setbufferlen returns pin when already large enough

2015-06-04 Thread Daniel Kahn Gillmor 
On Thu 2015-06-04 15:44:06 -0400, Werner Koch wrote:
 On Thu,  4 Jun 2015 19:54, n...@walfield.org said:

 It's a pretty significant bug in that it renders the curses backend
 completely unusable.

 Okay.  I'll do it tomorrow.

It would be great if we could address
https://bugs.gnupg.org/gnupg/issue1996 before the 0.9.4 release as well,
as it represents a pretty nasty regression for users of pinentry-gtk2
with passwords longer than 31 characters.

Regards,

 --dkg



signature.asc
Description: PGP signature

Bug#787639: [pkg-gnupg-maint] Bug#787639: [PATCH] pinentry_setbufferlen returns pin when already large enough

2015-06-04 Thread Neal H. Walfield 
At Thu, 04 Jun 2015 18:24:14 +0200,
Werner Koch wrote:
 On Thu,  4 Jun 2015 17:47, n...@walfield.org said:
 
  I've applied this with a slightly different change log.
 
 Shall I do a new release tomorrow?

It's a pretty significant bug in that it renders the curses backend
completely unusable.

How about a 0.93.1 release rather 0.94 given that it is the only
change?

:) Neal


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#787639: [pkg-gnupg-maint] Bug#787639: [PATCH] pinentry_setbufferlen returns pin when already large enough

2015-06-04 Thread Werner Koch 
On Thu,  4 Jun 2015 19:54, n...@walfield.org said:

 It's a pretty significant bug in that it renders the curses backend
 completely unusable.

Okay.  I'll do it tomorrow.

 How about a 0.93.1 release rather 0.94 given that it is the only
 change?

Ah no.  0.9.4 is just fine.  


Shalom-Salam,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#787639: [pkg-gnupg-maint] Bug#787639: [PATCH] pinentry_setbufferlen returns pin when already large enough

2015-06-04 Thread Werner Koch 
On Thu,  4 Jun 2015 17:47, n...@walfield.org said:

 I've applied this with a slightly different change log.

Shall I do a new release tomorrow?


Shalom-Salam,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#787639: [PATCH] pinentry_setbufferlen returns pin when already large enough

2015-06-04 Thread Neal H. Walfield 
Hi Daniel,

At Wed,  3 Jun 2015 13:27:26 -0400,
Daniel Kahn Gillmor wrote:
 
 * pinentry/pinentry.c (pinentry_setbufferlen): when pin buffer is
   already large enough, return the buffer instead of NULL.
   pinentry-curses.c is the only place that checks this return value
   now, and it expects this behavior.

I've applied this with a slightly different change log.

Thanks!

:) Neal


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#787639: [PATCH] pinentry_setbufferlen returns pin when already large enough

2015-06-03 Thread Daniel Kahn Gillmor 
* pinentry/pinentry.c (pinentry_setbufferlen): when pin buffer is
  already large enough, return the buffer instead of NULL.
  pinentry-curses.c is the only place that checks this return value
  now, and it expects this behavior.

--

Signed-Off-By: Daniel Kahn Gillmor d...@fifthhorseman.net
Debian-Bug-Id: 787639
---
 pinentry/pinentry.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pinentry/pinentry.c b/pinentry/pinentry.c
index 9a6a090..94909dc 100644
--- a/pinentry/pinentry.c
+++ b/pinentry/pinentry.c
@@ -435,7 +435,7 @@ pinentry_setbufferlen (pinentry_t pin, int len)
 len = 2048;
 
   if (len = pin-pin_len)
-return NULL;
+return pin-pin;
 
   newp = secmem_realloc (pin-pin, len);
   if (newp)
-- 
2.1.4


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org