Bug#787698: supertux: FTBFS on big-endian archs

[Vincent Cheng]

Hi Fabian,

On Mon, Aug 17, 2015 at 4:06 AM, Fabian Greffrath fab...@greffrath.com wrote:
 Control: tags -1 + patch

 Am Montag, den 08.06.2015, 09:07 +0200 schrieb Fabian Greffrath:
   *((char *)buffer) = tmp;

 Correction: You'll also need to dereference the tmp pointer, i.e.:

 --- supertux-0.3.5a.orig/src/audio/wav_sound_file.cpp
 +++ supertux-0.3.5a/src/audio/wav_sound_file.cpp
 @@ -159,7 +159,7 @@ WavSoundFile::read(void* buffer, size_t
  tmp[2*i+1] = c;
}

 -  *buffer = tmp;
 +  *(char *)buffer = *tmp;
  #endif

return readsize;


Thanks for the patch, and sorry for dropping the ball on this! I'll
upload an updated package within the next hour.

Regards,
Vincent

Bug#787698: supertux: FTBFS on big-endian archs

[Fabian Greffrath]

Control: tags -1 + patch

Am Montag, den 08.06.2015, 09:07 +0200 schrieb Fabian Greffrath:
   *((char *)buffer) = tmp;

Correction: You'll also need to dereference the tmp pointer, i.e.:

--- supertux-0.3.5a.orig/src/audio/wav_sound_file.cpp
+++ supertux-0.3.5a/src/audio/wav_sound_file.cpp
@@ -159,7 +159,7 @@ WavSoundFile::read(void* buffer, size_t
 tmp[2*i+1] = c;
   }
 
-  *buffer = tmp;
+  *(char *)buffer = *tmp;
 #endif
 
   return readsize;

Cheers,

Fabian


signature.asc
Description: This is a digitally signed message part

Bug#787698: supertux: FTBFS on big-endian archs

[Fabian Greffrath]

Hi Vincent,

Am Donnerstag, den 04.06.2015, 00:40 -0700 schrieb Vincent Cheng: 
 /«PKGBUILDDIR»/src/audio/wav_sound_file.cpp:162:4: error: 'void*' is not a 
 pointer-to-object type
*buffer = tmp;
 ^
 make[3]: *** [CMakeFiles/supertux2.dir/src/audio/wav_sound_file.cpp.o] Error 1
 
 Any help (or better yet, patches) would be greatly appreciated!

in the WavSoundFile::read function, the buffer argument is a void
pointer, so de-referencing it is a bad idea. You might want to try
type-punning the pointer by e.g.

  *((char *)buffer) = tmp;

Hope that helps,

Fabian



signature.asc
Description: This is a digitally signed message part

Bug#787698: supertux: FTBFS on big-endian archs

[Vincent Cheng]

Package: supertux
Version: 0.3.5a-1
Severity: serious
Justification: fails to build from source (but built successfully in the past)

supertux/0.3.5a-1 currently FTBFS on mips, powerpc, s390x, and sparc. Build
logs can be found at [1]; tail of build log is as follows:

[ 89%] Building CXX object 
CMakeFiles/supertux2.dir/src/audio/wav_sound_file.cpp.o
/usr/bin/c++-g -O2 -fstack-protector-strong -Wformat 
-Werror=format-security -D_FORTIFY_SOURCE=2  -std=c++11 -I/usr/include/GL 
-I/usr/include/AL -I/«PKGBUILDDIR»/obj-mips-linux-gnu -I/«PKGBUILDDIR»/src 
-I/«PKGBUILDDIR»/external/squirrel/include 
-I/«PKGBUILDDIR»/external/tinygettext/include 
-I/«PKGBUILDDIR»/external/findlocale -I/«PKGBUILDDIR»/external/obstack -isystem 
/usr/include/SDL2-Wall -Wextra -Wno-unused-parameter -funit-at-a-time 
-fno-strict-aliasing -o CMakeFiles/supertux2.dir/src/audio/wav_sound_file.cpp.o 
-c /«PKGBUILDDIR»/src/audio/wav_sound_file.cpp
/«PKGBUILDDIR»/src/audio/wav_sound_file.cpp: In member function 'virtual size_t 
WavSoundFile::read(void*, size_t)':
/«PKGBUILDDIR»/src/audio/wav_sound_file.cpp:162:4: error: 'void*' is not a 
pointer-to-object type
   *buffer = tmp;
^
make[3]: *** [CMakeFiles/supertux2.dir/src/audio/wav_sound_file.cpp.o] Error 1

Any help (or better yet, patches) would be greatly appreciated!

Regards,
Vincent

[1] https://buildd.debian.org/status/package.php?p=supertuxsuite=unstable

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.0-4-vclaptop-amd64 (SMP w/8 CPU cores; PREEMPT)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages supertux depends on:
ii  libc6 2.19-18
ii  libcurl3-gnutls   7.42.1-2
ii  libgcc1   1:5.1.1-8
ii  libgl1-mesa-glx [libgl1]  10.5.5-1
ii  libglew1.10   1.10.0-3
ii  libglu1-mesa [libglu1]9.0.0-2
ii  libogg0   1.3.2-1
ii  libopenal11:1.16.0-3
ii  libphysfs12.0.3-2
ii  libsdl2-2.0-0 2.0.2+dfsg1-7
ii  libsdl2-image-2.0-0   2.0.0+dfsg-3+b4
ii  libstdc++65.1.1-8
ii  libvorbis0a   1.3.4-2
ii  libvorbisfile31.3.4-2
ii  supertux-data 0.3.5a-1

supertux recommends no packages.

supertux suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org