Bug#793674: [Pkg-hhvm-team] Bug#793674: hhvm: leaves alternatives after purge: php - /usr/bin/hhvm

[David Martínez Moreno]

tags 793674 + pending
thanks

On 7/26/15 5:44 AM, Andreas Beckmann wrote:
 Hi,
 
 during a test with piuparts I noticed your package left unowned files on
 the system after purge, which is a violation of policy 6.8:

This has been fixed as of
http://anonscm.debian.org/cgit/pkg-hhvm/hhvm.git/commit/?id=1b3b1f321b369747ca57c9ca7aef7a17d0a57b44
and it will be present in the next upload (hopefully when the dust due to the
GCC5 transition settles).


Ender.



signature.asc
Description: OpenPGP digital signature

Bug#793674: hhvm: leaves alternatives after purge: php - /usr/bin/hhvm

[Andreas Beckmann]

Package: hhvm
Version: 3.2.0+dfsg1-2
Severity: important
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy 6.8:

https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails

The leftover files are actually alternatives that were installed by the
package but have not been properly removed.

While there is ongoing discussion how to remove alternatives correctly
(see https://bugs.debian.org/71621 for details) the following strategy
should work for regular cases:
* 'postinst configure' always installs the alternative
* 'prerm remove' removes the alternative
* 'postrm remove' and 'postrm disappear' remove the alternative
In all other cases a maintainer script is invoked (e.g. upgrade,
deconfigure) the alternatives are not modified to preserve user
configuration.
Removing the alternative in 'prerm remove' avoids having a dangling link
once the actual file gets removed, but 'prerm remove' is not called in
all cases (e.g. unpacked but not configured packages or disappearing
packages) so the postrm must remove the alternative again
(update-alternatives gracefully handles removal of non-existing
alternatives).

Note that the arguments for adding and removing alternatives differ, for
removal it's 'update-alternatives --remove name path'.

Filing this as important as having a piuparts clean archive is a release
goal since lenny.

From the attached log (scroll to the bottom...):

1m15.6s ERROR: WARN: Broken symlinks:
  /usr/share/man/man1/php.1.gz - /etc/alternatives/php.1.gz
  /usr/bin/php - /etc/alternatives/php
  /etc/alternatives/php.1.gz - /usr/share/man/man1/hhvm.1.gz
  /etc/alternatives/php - /usr/bin/hhvm

1m17.7s ERROR: FAIL: Package purging left files on system:
  /etc/alternatives/php - /usr/bin/hhvm not owned
  /etc/alternatives/php.1.gz - /usr/share/man/man1/hhvm.1.gznot owned
  /usr/bin/php - /etc/alternatives/php  not owned
  /usr/share/man/man1/php.1.gz - /etc/alternatives/php.1.gz not owned


cheers,

Andreas


hhvm_3.2.0+dfsg1-2.log.gz
Description: application/gzip