Bug#797856: RFS: golang-github-mattn-go-sqlite3
On 03/09/15 01:49 AM, Dmitry Smirnov wrote: > Hmm, I'm getting "empty-binary-package" That is due to me working too late! There was a missing dh_auto_install call. I have just fixed it. > and second build fails due to local > changes in "go-sqlite3-1.0.0/sqlite3.go"... You cannot build twice with dpkg-buildpackage as the patches will stay applied. I suggest you use "gbp buildpackage" instead. Thank you Dimitry, -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On Thursday 03 September 2015 01:20:32 Alexandre Viau wrote: > I have excluded code/* from the tarball, added libsqlite3-dev as a > dependency and written a patch. > > Let me know if that works for you :) It seems to work when I drop "override_dh_auto_install" section from "rules". What were you trying to do in this override? -- Best wishes, Dmitry Smirnov. --- Continuous effort - not strength or intelligence - is the key to unlocking our potential. -- Winston Churchill signature.asc Description: This is a digitally signed message part.
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On 03/09/15 02:13 AM, Dmitry Smirnov wrote: > I don't understand what are you trying to do. Apparently your override do not > work as I see no difference in resulting packages whether I build with or > without override. It looks like the patch that remove the build tag is enough. I have removed the override. > If package FTBFS on second build is a bug so you are doing something wrong. Can you try again with master? I cannot reproduce. -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On 03/09/15 02:04 AM, Dmitry Smirnov wrote: > It seems to work when I drop "override_dh_auto_install" section from "rules". > What were you trying to do in this override? Looks like we are sending mails at the same time. This override is to avoid having a huge quilt patch. quilt generates huge patches for file renames. The go compiler uses build tags to determine which file to build, depending on the file name. In our case, we never want to compile against the bundled libsqlite3 code, so we want a different default. We have no use for the sqlite3.go and replacing it with sqlite3_libsqlite3.go. -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On Thursday 03 September 2015 02:20:39 Alexandre Viau wrote: > It looks like the patch that remove the build tag is enough. I have > removed the override. It is enough and lintian no longer complains about bundled SQLite3 in grafana. :) Very nice. > > If package FTBFS on second build is a bug so you are doing something > > wrong. > Can you try again with master? I cannot reproduce. It was because you've changed source tree from override. There is no such problem if you do modifications with patches. You fixed this problem when you removed override. -- Best wishes, Dmitry Smirnov. --- "All government, of course, is against liberty. -- H. L. Mencken signature.asc Description: This is a digitally signed message part.
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On Thursday 03 September 2015 02:08:53 Alexandre Viau wrote: > This override is to avoid having a huge quilt patch. quilt generates > huge patches for file renames. > > The go compiler uses build tags to determine which file to build, > depending on the file name. > > In our case, we never want to compile against the bundled libsqlite3 > code, so we want a different default. We have no use for the sqlite3.go > and replacing it with sqlite3_libsqlite3.go. I see... If I correctly understood what you are trying to do then you probably want to rename file in build directory before build so you just need: dh $@ --buildsystem=golang --with=golang --builddirectory=_build override_dh_auto_configure: dh_auto_configure mv -v _build/src/$(DH_GOPKG)/sqlite3.go _build/src/$(DH_GOPKG)/sqlite3_libsqlite3.go Although package seems to work even without rename. I'm illiterate in golang so I trust you to know better whether rename is really necessary... -- All the best, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On 03/09/15 02:28 AM, Dmitry Smirnov wrote: > Although package seems to work even without rename. Indeed, you are perfectly right. I have removed the override in my last commit, as the patch is enough. -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On Thursday 03 September 2015 02:32:03 Alexandre Viau wrote: > Indeed, you are perfectly right. I have removed the override in my last > commit, as the patch is enough. Thank you very much. All good (grafana works) and package builds nicely so I've just uploaded it. Well done. :) -- Cheers, Dmitry Smirnov. --- If any remedy is tested under controlled scientific conditions and proved to be effective, it will cease to be alternative and will simply become medicine. So-called alternative medicine either hasn't been tested or it has failed its tests. -- Richard Dawkins, 2007 signature.asc Description: This is a digitally signed message part.
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On 03/09/15 02:45 AM, Dmitry Smirnov wrote: > On Thursday 03 September 2015 02:32:03 Alexandre Viau wrote: >> Indeed, you are perfectly right. I have removed the override in my last >> commit, as the patch is enough. > > Thank you very much. All good (grafana works) and package builds nicely so > I've just uploaded it. Well done. :) > Yay! Thank you for your responsiveness Dimitry :) -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On Wednesday 02 September 2015 22:22:04 Alexandre Viau wrote: > Could you review golang-github-mattn-go-sqlite3? I'm still looking at it and I've noticed that you are using weird GitHub "watch" files in your packages... Why not use something like this: http://anonscm.debian.org/cgit/pkg-go/packages/golang-gogoprotobuf.git/commit/?id=f70e004c -- Cheers, Dmitry Smirnov. --- Believing is easier than thinking. Hence so many more believers than thinkers. -- Bruce Calvert signature.asc Description: This is a digitally signed message part.
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On Wednesday 02 September 2015 22:42:27 Alexandre Viau wrote: > On 02/09/15 10:35 PM, Dmitry Smirnov wrote: > > Why not use something like this: > > http://anonscm.debian.org/cgit/pkg-go/packages/golang-gogoprotobuf.gi > > t/commit/?id=f70e004c > Are you talking about the filenamemangle? It tells uscan to rename the > tarball properly. Isn't that what uscan's "--rename" argument does? Probably `origtargz` does not need it either. I don't use "filenamemangle" for GitHub and I've never had any problems without it... Actually I'm talking about the whole thing, including use of "/tags" instead of "/releases" etc... > See here: https://wiki.debian.org/debian/watch#GitHub O, that's where it came from. :) It looks like a slightly outdated recipe... > Otherwise, the name of the tarball would be "v1.0.0.tar.gz". Which is > not very verbose. Not sure about it althought it could be because I have USCAN_SYMLINK="rename" in "~/.devscripts"... Anyway "sepwatch" repo does not use "filenamemangle" for GitHub. -- Cheers, Dmitry Smirnov. --- I hate all sports as rabidly as a person who likes sports hates common sense. -- H. L. Mencken signature.asc Description: This is a digitally signed message part.
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On Thursday 03 September 2015 01:20:32 Alexandre Viau wrote: > I have excluded code/* from the tarball, added libsqlite3-dev as a > dependency and written a patch. Awesome. :) > Let me know if that works for you :) Hmm, I'm getting "empty-binary-package" and second build fails due to local changes in "go-sqlite3-1.0.0/sqlite3.go"... -- Best wishes, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#797856: RFS: golang-github-mattn-go-sqlite3
Control: tag -1 moreinfo On Wednesday 02 September 2015 22:22:04 Alexandre Viau wrote: > Could you review golang-github-mattn-go-sqlite3? "debian/copyright" is incomplete. Please document _example/mod_vtable/picojson.h and code/* sqlite3-binding.c, sqlite3-binding.h, sqlite3ext.h The latter is "amalgamation code that copied from SQLite3" i.e. bundled code copy. Please see if it is possible to use "libsqlite3-dev". I'd much like to avoid shipping bundled SQLite3 sources in this package. -- Regards, Dmitry Smirnov. --- To swallow and follow, whether old doctrine or new propaganda, is a weakness still dominating the human mind. -- Charlotte P. Gilman signature.asc Description: This is a digitally signed message part.
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On 02/09/15 10:57 PM, Dmitry Smirnov wrote: > On Wednesday 02 September 2015 22:42:27 Alexandre Viau wrote: >> On 02/09/15 10:35 PM, Dmitry Smirnov wrote: >>> Why not use something like this: >>> http://anonscm.debian.org/cgit/pkg-go/packages/golang-gogoprotobuf.gi >>> t/commit/?id=f70e004c >> Are you talking about the filenamemangle? It tells uscan to rename the >> tarball properly. > > Isn't that what uscan's "--rename" argument does? Probably `origtargz` does > not need it either. I don't use "filenamemangle" for GitHub and I've never > had any problems without it... > > Actually I'm talking about the whole thing, including use of "/tags" instead > of "/releases" etc... Looks like /tags contains more than /releases. I'm not sure if one is better than the other. This is somewhat documented here: - https://developer.github.com/v3/repos/releases/#list-releases-for-a-repository >> Otherwise, the name of the tarball would be "v1.0.0.tar.gz". Which is >> not very verbose. > > Not sure about it althought it could be because I have > > USCAN_SYMLINK="rename" > > in "~/.devscripts"... Anyway "sepwatch" repo does not use "filenamemangle" > for GitHub. I have tested. The tarball is named "v1.0.0.tar.gz" and a symlink is created. Looks like both solutions work fine. Simpler is always better. I have removed the filenamemangle and pushed a new version of the watch file. Thanks :) -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
Bug#797856: RFS: golang-github-mattn-go-sqlite3
Hello, On 02/09/15 10:35 PM, Dmitry Smirnov wrote: > I'm still looking at it and I've noticed that you are using weird GitHub > "watch" files in your packages... Why not use something like this: > > > http://anonscm.debian.org/cgit/pkg-go/packages/golang-gogoprotobuf.git/commit/?id=f70e004c Are you talking about the filenamemangle? It tells uscan to rename the tarball properly. See here: https://wiki.debian.org/debian/watch#GitHub Otherwise, the name of the tarball would be "v1.0.0.tar.gz". Which is not very verbose. -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
Bug#797856: RFS: golang-github-mattn-go-sqlite3
On Wednesday 02 September 2015 23:13:19 Alexandre Viau wrote: > Looks like /tags contains more than /releases. I'm not sure if one is > better than the other. This is somewhat documented here: > - > https://developer.github.com/v3/repos/releases/#list-releases-for-a-reposit > ory I've seen repositories where some tags are not releases. It confuses "uscan" and generates false notifications about new releases in PTS, DDPO, maintainer dashboard etc. Also sometimes you might need to be careful with (\d\S*) that can match alpha/beta pre-releases. Also it may be useful to check your "copyright" file with "cme check dpkg- copyright" and your "control" file with "cme check dpkg-control". ;) -- Regards, Dmitry Smirnov. --- Platitude: an idea (a) that is admitted to be true by everyone, and (b) that is not true. -- H. L. Mencken signature.asc Description: This is a digitally signed message part.
Bug#797856: RFS: golang-github-mattn-go-sqlite3
Hello Dimitry, Could you review golang-github-mattn-go-sqlite3? It is available on Alioth: - git.debian.org:/git/pkg-go/packages/golang-github-mattn-go-sqlite3 If you upload the package, please tag the repository <3 Thanks :) -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
Bug#797856: RFS: golang-github-mattn-go-sqlite3
Hello, On 02/09/15 11:12 PM, Dmitry Smirnov wrote: > Control: tag -1 moreinfo > > "debian/copyright" is incomplete. Please document > > _example/mod_vtable/picojson.h Fixed > and > code/* > sqlite3-binding.c, sqlite3-binding.h, sqlite3ext.h > > The latter is "amalgamation code that copied from SQLite3" i.e. bundled code > copy. Please see if it is possible to use "libsqlite3-dev". > > I'd much like to avoid shipping bundled SQLite3 sources in this package. I have excluded code/* from the tarball, added libsqlite3-dev as a dependency and written a patch. Let me know if that works for you :) -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
