Bug#798960: libvorbis: Please upgrade to 1.3.5
[Petter Reinholdtsen] > No-one objected, so I plan to upload the code in the > package-new-upstream-version branch to unstable soon, to get the latest > version into Debian way ahead of any code freeze. I've just merged the branch into main and uploaded a new version of libvorbis. I added a simple autopkgtest script to compile and run the example code, but otherwise the package was identical to the one in package-new-upstream-version. -- Happy hacking Petter Reinholdtsen
Bug#798960: libvorbis: Please upgrade to 1.3.5
[Petter Reinholdtsen] > I had a look and the library changes API and ABI in one case _ilog() > changed name to ov_ilog(). I suspect the _ilog() function is an > internal function. _ilog was presented lib/codebook.h and of_ilog() is > now presented in lib/misc.h. None of these header files are present in > libvorbis-dev, so I guess no changes was done in the public API and ABI. > Based on this, I believe it is safe to upgrade libvorbis without > requering a rebuild and that no migration is needed. > > Do you agree? No-one objected, so I plan to upload the code in the package-new-upstream-version branch to unstable soon, to get the latest version into Debian way ahead of any code freeze. The code have a unit test that is executed during build, so at least those parts tested by this code is still working as it should. -- Happy hacking Petter Reinholdtsen
Bug#798960: libvorbis: Please upgrade to 1.3.5
[Petter Reinholdtsen] > If the new library require a ABI change and a new soname, it is a > good idea to talk to the release team before uploading thew new > library, to check if it is a bad time to do such migration, but if > there is no soname change and the library work for the cases we have > time to test, lets get the library into wider testing. I had a look and the library changes API and ABI in one case _ilog() changed name to ov_ilog(). I suspect the _ilog() function is an internal function. _ilog was presented lib/codebook.h and of_ilog() is now presented in lib/misc.h. None of these header files are present in libvorbis-dev, so I guess no changes was done in the public API and ABI. Based on this, I believe it is safe to upgrade libvorbis without requering a rebuild and that no migration is needed. Do you agree? -- Happy hacking Petter Reinholdtsen
Bug#798960: libvorbis: Please upgrade to 1.3.5
[Martin Steghöfer] > But I guess, we could at least upload it to experimental. Petter, what > do you think? I think we should add some autopkgtest tests of vorbis-tools and verify that both the old and new library work with these tests, and upload to unstable when the basic functionallity is verified to be working. If the new library require a ABI change and a new soname, it is a good idea to talk to the release team before uploading thew new library, to check if it is a bad time to do such migration, but if there is no soname change and the library work for the cases we have time to test, lets get the library into wider testing. -- Happy hacking Petter Reinholdtsen
Bug#798960: libvorbis: Please upgrade to 1.3.5
No technical reason, just not enough time to test is as well as the number of reverse dependencies would demand it for a new upstream release. My testing efforts so far: * Test compilation of vorbis-tools against the libvorbis-dev package * Perform very basic tests of the ogg-vorbis related functionality of: audacity, vorbis-tools (oggenc, oggdec, ogg123), vlc, supertux, 0ad, audacious * Have it installed in my production system for several days (however, with very little ogg-vorbis related activity) But I guess, we could at least upload it to experimental. Petter, what do you think? Cheers, Martin Sebastien Bacher wrote: Hey there, is that update still being worked on or is it blocking on something?
Bug#798960: libvorbis: Please upgrade to 1.3.5
Hey there, is that update still being worked on or is it blocking on something?
Bug#798960: libvorbis: Please upgrade to 1.3.5
On 2015-09-23 3:30 AM, Martin Steghöfer wrote: > I can take care of forwarding them now. Thanks, Martin! -r
Bug#798960: libvorbis: Please upgrade to 1.3.5
El 22-09-2015 a les 23:40, Petter Reinholdtsen ha escrit:
Did you include all the patches in Debian into the 1.3.5 release?
Knowing which to keep will make the update a bit easier for us. The
complete set is available from
https://sources.debian.net/src/libvorbis/1.3.4-3/debian/patches/ >.
Most patches are actually backports of upstream commits anyway. Of the
ones that aren't, those that were actually forwarded to Xiph.org are all
included in 1.3.5. That leaves us with only two patches ("Fix build
failure with DSO link changes." and "Avoid SIGFPE when bytespersample is
zero") that have never been forwarded to upstream (probably because they
were introduced by NMUs) and are therefore not included in 1.3.5. I can
take care of forwarding them now.
I've started packaging 1.3.5 in the git branch
"package-new-upstream-version".
Cheers,
Martin
Bug#798960: libvorbis: Please upgrade to 1.3.5
[Ralph Giles] > There's a mistake in the release tarball. I forgot to change the date > before publishing. You can verify the source against > https://svn.xiph.org/tags/vorbis/libvorbis-1.3.5/CHANGES if you're > worried. Right. I was more worried I would release something I thought was 1.3.5 by mistake, only to discover that it was not. :) We will try to get it uploaded, now that this is cleared. Did you include all the patches in Debian into the 1.3.5 release? Knowing which to keep will make the update a bit easier for us. The complete set is available from https://sources.debian.net/src/libvorbis/1.3.4-3/debian/patches/ >. -- Happy hacking Petter Reinholdtsen
Bug#798960: libvorbis: Please upgrade to 1.3.5
On 2015-09-22 2:37 AM, Petter Reinholdtsen wrote: > But the CHANGES file in the tarball claim the version is unreleased. > Is it the wrong tarball, or did someone forget to update the CHANGES > file before release? There's a mistake in the release tarball. I forgot to change the date before publishing. You can verify the source against https://svn.xiph.org/tags/vorbis/libvorbis-1.3.5/CHANGES if you're worried. If you're worried about confusion in the debian package, backporting the release date from the repo as a patch would also be appropriate. https://git.xiph.org/?p=vorbis.git;a=commitdiff;h=e9a1fd561632f7c9b7d2f58c95d374f8c9ab24f4 -r
Bug#798960: libvorbis: Please upgrade to 1.3.5
Il 22/set/2015 11:37 AM, Petter Reinholdtsen ha scritto: > > [Fabio Pedretti] > > Dear Maintainer, > > Hi. Thank you for making contact. :) > > > 1.3.5 was released with some crash and other fixes: > > https://trac.xiph.org/browser/trunk/vorbis/CHANGES > > > > Please upgrade version in debian. > > But the CHANGES file in the tarball claim the version is unreleased. > Is it the wrong tarball, or did someone forget to update the CHANGES > file before release? I suppose it is the latter: http://trac.xiph.org/changeset/19460 which was updated just after the commit release: https://trac.xiph.org/changeset/19459
Bug#798960: libvorbis: Please upgrade to 1.3.5
[Fabio Pedretti] > Dear Maintainer, Hi. Thank you for making contact. :) > 1.3.5 was released with some crash and other fixes: > https://trac.xiph.org/browser/trunk/vorbis/CHANGES > > Please upgrade version in debian. But the CHANGES file in the tarball claim the version is unreleased. Is it the wrong tarball, or did someone forget to update the CHANGES file before release? -- Happy hacking Petter Reinholdtsen
Bug#798960: libvorbis: Please upgrade to 1.3.5
Package: libvorbis Version: 1.3.4-2 Severity: normal Dear Maintainer, 1.3.5 was released with some crash and other fixes: https://trac.xiph.org/browser/trunk/vorbis/CHANGES Please upgrade version in debian. Thanks.
